openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
714 stars 38 forks source link

[PRE REVIEW]: EMRI_MC: A GPU-based code for Bayesian inference of EMRI waveforms #6285

Closed editorialbot closed 8 months ago

editorialbot commented 8 months ago

Submitting author: !--author-handle-->@ippocratiss/<!--end-author-handle-- (Ippocratis Saltas) Repository: https://github.com/ippocratiss/EMRI_MC Branch with paper.md (empty if default branch): main Version: v1.0 Editor: Pending Reviewers: Pending Managing EiC: Dan Foreman-Mackey

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/3f2f92d97b79135ce83ef13ea7c48da7"><img src="https://joss.theoj.org/papers/3f2f92d97b79135ce83ef13ea7c48da7/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/3f2f92d97b79135ce83ef13ea7c48da7/status.svg)](https://joss.theoj.org/papers/3f2f92d97b79135ce83ef13ea7c48da7)

Author instructions

Thanks for submitting your paper to JOSS @ippocratiss/. Currently, there isn't a JOSS editor assigned to your paper.

@ippocratiss/ if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 8 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 8 months ago

Couldn't check the bibtex because branch name is incorrect: paper.md

editorialbot commented 8 months ago

Couldn't check the bibtex because branch name is incorrect: paper.md

editorialbot commented 8 months ago

:warning: An error happened when generating the pdf.

dfm commented 8 months ago

@editorialbot set main as branch

editorialbot commented 8 months ago

Done! branch is now main

dfm commented 8 months ago

@editorialbot check repository

editorialbot commented 8 months ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.04 s (282.5 files/s, 59150.7 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
TeX                              1             70              0            664
Python                           4            144            356            264
Markdown                         2            103              0            177
Jupyter Notebook                 2              0            240             53
YAML                             1              1              4             18
-------------------------------------------------------------------------------
SUM:                            10            318            600           1176
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 8 months ago

Wordcount for paper.md is 3762

dfm commented 8 months ago

@editorialbot check references

dfm commented 8 months ago

@editorialbot generate pdf

editorialbot commented 8 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1103/PhysRevD.104.062009 is OK
- 10.3847/1538-4357/ac9cd4 is OK
- 10.3847/1538-4365/ac9129 is OK
- 10.1103/PhysRevLett.113.191101 is OK
- 10.1103/PhysRevD.97.104037 is OK
- 10.1088/1475-7516/2022/08/031 is OK
- 10.1088/1475-7516/2014/07/050 is OK
- 10.1088/1475-7516/2023/05/030 is OK
- 10.1103/PhysRevD.98.023510 is OK
- 10.1103/PhysRevD.69.082005 is OK
- 10.1103/PhysRevD.75.042003 is OK
- 10.1088/0264-9381/24/17/R01 is OK
- 10.12942/lrr-2011-7 is OK
- 10.1088/1361-6633/aae552 is OK
- 10.1007/978-981-15-4702-7_38-1 is OK
- 10.1103/PhysRevD.103.104014 is OK
- 10.1103/PhysRevLett.126.051102 is OK
- 10.1103/PhysRevD.97.104033 is OK
- 10.1103/PhysRevLett.127.151102 is OK
- 10.1103/PhysRevLett.130.241402 is OK
- 10.1103/PhysRevD.104.064047 is OK
- 10.1103/PhysRev.131.435 is OK
- 10.1103/PhysRev.136.B1224 is OK
- 10.1088/0264-9381/32/23/232002 is OK
- 10.1103/PhysRevD.96.044005 is OK
- 10.1103/PhysRevD.66.064005 is OK
- 10.1103/PhysRevD.66.044002 is OK
- 10.1103/PhysRevD.73.064037 is OK
- 10.1103/PhysRevD.75.024005 is OK
- 10.1103/PhysRevLett.104.091102 is OK
- 10.1103/PhysRevD.83.044044 is OK
- 10.1103/PhysRevD.104.024067 is OK
- 10.1088/1475-7516/2022/09/012 is OK
- 10.1007/s10714-022-03016-0 is OK
- 10.1103/PhysRevD.67.024016 is OK
- 10.1103/PhysRevD.57.7089 is OK
- 10.1103/PhysRevD.49.6274 is OK
- 10.1088/1361-6382/ab1101 is OK
- 10.1088/1742-6596/840/1/012024 is OK
- 10.1086/670067 is OK
- 10.1088/0264-9381/29/14/145014 is OK
- 10.1103/RevModPhys.94.025001 is OK
- 10.1103/PhysRevD.77.042001 is OK
- 10.1088/1361-6382/aa85fa is OK
- 10.1103/PhysRevD.95.103012 is OK
- 10.1007/s41114-022-00036-9 is OK
- 10.1007/s41114-023-00045-2 is OK
- 10.1007/s41114-022-00041-y is OK
- 10.2140/camcos.2010.5.65 is OK

MISSING DOIs

- 10.1142/9789811258251_0157 may be a valid DOI for title: Modified gravity, gravitational waves and the large-scale structure of the Universe: A brief report

INVALID DOIs

- None
editorialbot commented 8 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 8 months ago

Five most similar historical JOSS papers:

GRChombo: An adaptable numerical relativity code for fundamental physics Submitting author: @kaclough Handling editor: @rkurchin (Active) Reviewers: @sbozzolo, @rashti-alireza Similarity score: 0.8062

emcee v3: A Python ensemble sampling toolkit for affine-invariant MCMC Submitting author: @dfm Handling editor: @xuanxu (Active) Reviewers: @benjaminrose, @mattpitkin Similarity score: 0.8015

swyft: Truncated Marginal Neural Ratio Estimation in Python Submitting author: @bkmi Handling editor: @pdebuyl (Active) Reviewers: @mattpitkin, @olgadoronina Similarity score: 0.8000

emg3d: A multigrid solver for 3D electromagnetic diffusion Submitting author: @prisae Handling editor: @jedbrown (Active) Reviewers: @akelbert, @emersodb, @lukeolson Similarity score: 0.7999

iharm3D: Vectorized General Relativistic Magnetohydrodynamics Submitting author: @bprather Handling editor: @eloisabentivegna (Active) Reviewers: @bgiacoma, @cpalenzuela Similarity score: 0.7981

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

dfm commented 8 months ago

@editorialbot query scope

@ippocratiss — Thanks for your submission! Given the limited size and history of the code base, and the limited documentation, packaging, and testing, I have submitted this pre-review for editorial review. This usually takes a week or two and I'll report back here as soon as I hear back from the rest of the editorial board. Thanks for your patience!

editorialbot commented 8 months ago

Submission flagged for editorial review.

dfm commented 8 months ago

@editorialbot reject

@ippocratiss — Apologies, I actually misspoke above. Given that this submission includes fewer than 300 lines of code, it is JOSS policy to desk reject such a minor submission. This is not a judgement on the scientific merit of the software, but such a submission is not considered within scope of the journal. Please feel free to consider a re-submission if the code reaches a more mature state.

editorialbot commented 8 months ago

Paper rejected.