search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
703 stars 36 forks source link

[PRE REVIEW]: TopologicalNumbers.jl: A Julia package for topological number computation #6287

Closed editorialbot closed 2 months ago

editorialbot commented 7 months ago

Submitting author: !--author-handle-->@KskAdch<!--end-author-handle-- (Keisuke Adachi) Repository: https://github.com/KskAdch/TopologicalNumbers.jl Branch with paper.md (empty if default branch): Version: v1.7.5 Editor: !--editor-->@olexandr-konovalov<!--end-editor-- Reviewers: @lf28, @michiexile Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/d5363597cf38cb06360482fbabb6d350"><img src="https://joss.theoj.org/papers/d5363597cf38cb06360482fbabb6d350/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/d5363597cf38cb06360482fbabb6d350/status.svg)](https://joss.theoj.org/papers/d5363597cf38cb06360482fbabb6d350)

Author instructions

Thanks for submitting your paper to JOSS @KskAdch. Currently, there isn't a JOSS editor assigned to your paper.

@KskAdch if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 7 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 7 months ago 
Software report:

github.com/AlDanial/cloc v 1.88  T=0.06 s (921.2 files/s, 181556.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Julia                           22           1267            463           5622
Markdown                        17            521              0           1316
TeX                              2             16              0            264
Jupyter Notebook                 1              0            997            149
SVG                              3             14              0            146
YAML                             5              1             29            143
TOML                             6             12              1             76
-------------------------------------------------------------------------------
SUM:                            56           1831           1490           7716
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 7 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1143/JPSJ.74.1674 is OK
- 10.48550/arXiv.2305.05615 is OK
- 10.1103/PhysRevB.96.235152 is OK
- 10.1103/PhysRevLett.114.206401 is OK
- 10.7566/JPSJ.87.041002 is OK
- 10.1103/PhysRevB.84.075129 is OK
- 10.1143/JPSJ.76.053702 is OK
- 10.1088/2058-9565/aae93b is OK
- 10.1145/2331130.2331138 is OK
- 10.1103/RevModPhys.82.3045 is OK
- 10.1103/RevModPhys.83.1057 is OK
- 10.1088/1367-2630/12/6/065010 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 7 months ago

Wordcount for paper.md is 757

editorialbot commented 7 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 7 months ago

Five most similar historical JOSS papers:

Kinetic.jl: A portable finite volume toolbox for scientific and neural computing Submitting author: @vavrines Handling editor: @diehlpk (Active) Reviewers: @rdeits, @jarvist Similarity score: 0.8045

MultilayerGraphs.jl: Multilayer Network Science in Julia Submitting author: @pitmonticone Handling editor: @diehlpk (Active) Reviewers: @TomKellyGenetics, @bgailleton Similarity score: 0.8019

Optim: A mathematical optimization package for Julia Submitting author: @anriseth Handling editor: @labarba (Retired) Reviewers: @ahwillia Similarity score: 0.7971

CarrierCapture.jl: Anharmonic Carrier Capture Submitting author: @frssp Handling editor: @danielskatz (Active) Reviewers: @utf, @taylor-a-barnes Similarity score: 0.7962

PolaronMobility.jl: Implementation of the Feynman variational polaron model Submitting author: @jarvist Handling editor: @lheagy (Retired) Reviewers: @yxqd Similarity score: 0.7959

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

kyleniemeyer commented 7 months ago

Hello @KskAdch, thanks for your submission to JOSS. We'll use this pre-review issue to assign an editor and find reviewers.

Unfortunately, we don't currently have an editor in this area available to handle your submission, so I'll put this on our waitlist until someone becomes available. In the meantime, any reviewer recommendations you can make would be welcome.

KskAdch commented 7 months ago

I have identified five individuals from the list of potential reviewers. Their GitHub usernames are mentioned below, without being tagged, and are listed in no specific order:

arfon commented 7 months ago

@kyleniemeyer – @olexandr-konovalov has agreed to take on this submission for us. I'll go ahead and assign him now – he will likely pick this up in the next couple of weeks.

arfon commented 7 months ago

@editorialbot assign @olexandr-konovalov as editor

editorialbot commented 7 months ago

Assigned! @olexandr-konovalov is now the editor

phjmsycc commented 4 months ago

Hi, @olexandr-konovalov. I'm a co-researcher on this project. Since @KskAdch graduated and left our laboratory this spring, I will primarily handle the revision of this work. As far as I know, you were assigned as the editor on February 9th, and now, over two months have passed. Could you please provide an update on the status of the review?

olexandr-konovalov commented 3 months ago

@jarvist and @PhilipVinc - would one or both of you be able to review this submission for JOSS, please?

If not, could you possibly recommend someone whom we may approach regarding this?

PhilipVinc commented 3 months ago

Not my field of expertise

olexandr-konovalov commented 3 months ago

Hello @Datseris, would you be able to review this submission for JOSS, please?

If not, could you possibly recommend someone whom we may approach regarding this?

Datseris commented 3 months ago

I'm sorry, I have no idea what topological numbers are, this is well outside my expertise.

olexandr-konovalov commented 3 months ago

Hi @Chronum94 and @santoshkumarradha - would one or both of you be able to review this submission for JOSS, please?

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. JOSS reviews involve downloading and installing the software, and inspecting the repository and submitted paper for key elements (see https://joss.readthedocs.io/en/latest/review_criteria.html). Editors and reviewers post comments on the Review issue, and authors respond to the comments and improve their submission until acceptance (or withdrawal, if they feel unable to satisfy the review). You can find more details in the reviewer guides at https://joss.readthedocs.io/.

If not, could you possibly recommend someone whom we may approach regarding this? Thank you!

olexandr-konovalov commented 3 months ago

Hi @vavrines and @zafeirakopoulos - would one or both of you be able to review this submission for JOSS, please? If not, could you possibly suggest someone whom we may approach regarding this?

vavrines commented 3 months ago

That's a little too far from where I'm going with my research. Maybe @Zhengyu-Huang is interested?

olexandr-konovalov commented 2 months ago

Hi @davibarreira and @brainandforce - would one or both of you be able to review this submission for JOSS, please? Please see details about our review process a few comments above. If not, could you possibly suggest someone whom we may approach regarding this?

davibarreira commented 2 months ago

@olexandr-konovalov , I'd love to help, but after taking a look at the package, this seems way out of my expertise. Although I do know some Topology, it is the first time I hear of topological numbers. I also don't know anybody with knowledge in this subject.

brainandforce commented 2 months ago

I am brand new to the field of topological data analysis and I would not be suited to verify anything about the software outside of its overall organization.

olexandr-konovalov commented 2 months ago

Hi @michiexile - long time since we been in touch! I am looking for reviewers of this JOSS paper about topological data analysis in Julia. Would you be interested, and/or possibly suggest someone else to review it? Please see details about our review process a few comments above.

olexandr-konovalov commented 2 months ago

@editorialbot add @lf28 as reviewer

editorialbot commented 2 months ago

@lf28 added to the reviewers list!

olexandr-konovalov commented 2 months ago

@lf28 thank you very much for agreeing to review this paper! As soon as we will find the 2nd reviewer, I will start the review process: there will be another issue opened, and all further conversation will move there, supported by review checklists.

michiexile commented 2 months ago

Hi @michiexile - long time since we been in touch! I am looking for reviewers of this JOSS paper about topological data analysis in Julia. Would you be interested, and/or possibly suggest someone else to review it? Please see details about our review process a few comments above.

Sorry for not responding earlier. I'm happy to review.

olexandr-konovalov commented 2 months ago

@editorialbot add @michiexile as reviewer

editorialbot commented 2 months ago

@michiexile added to the reviewers list!

olexandr-konovalov commented 2 months ago

@editorialbot start review

editorialbot commented 2 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6944.

olexandr-konovalov commented 2 months ago

Fantastic! Great to hear from you @michiexile, and thanks for agreeing to review it, both to you, and to @lf28! I have now started the review in #6944, and all further conversations will take place there. Please see #6944 for the instructions for the reviewers and other details, including the commands to generate your own checklists.