search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
709 stars 38 forks source link

[REVIEW]: MOLE: Mimetic Operators Library Enhanced #6288

Closed editorialbot closed 2 months ago

editorialbot commented 8 months ago

Submitting author: !--author-handle-->@jcorbino<!--end-author-handle-- (Johnny Corbino) Repository: https://github.com/jcorbino/mole Branch with paper.md (empty if default branch): Version: v1.0 Editor: !--editor-->@jedbrown<!--end-editor-- Reviewers: @jakelangham, @victorapm Archive: 10.5281/zenodo.12752946

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/a19d0799c87be56f189e125a12fb748a"><img src="https://joss.theoj.org/papers/a19d0799c87be56f189e125a12fb748a/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/a19d0799c87be56f189e125a12fb748a/status.svg)](https://joss.theoj.org/papers/a19d0799c87be56f189e125a12fb748a)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@jakelangham & @victorapm, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @jedbrown know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @jakelangham

📝 Checklist for @victorapm

editorialbot commented 8 months ago

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 8 months ago 
Software report:

github.com/AlDanial/cloc v 1.88  T=0.12 s (1803.7 files/s, 101041.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                            52            378            145           3778
MATLAB                         115            843            848           3046
C++                             14            180            122            824
PHP                              1             14             26            289
TeX                              1             16              0            177
JSON                             1              0              0            174
Markdown                         7             85              0            170
C/C++ Header                     8             43             23            128
make                             4             37              0             80
CSS                              1             13              0             77
YAML                             3              9             29             60
ProGuard                         1              8              5             25
-------------------------------------------------------------------------------
SUM:                           208           1626           1198           8828
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 8 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.cam.2019.06.042 is OK
- 10.1080/21681163.2021.1914733 is OK
- 10.1016/j.procs.2013.05.210 is OK
- 10.1190/geo2013-0371.1 is OK
- 10.1111/j.1365-246X.2007.03651.x is OK
- 10.1201/b14575 is OK
- 10.1137/S0895479801398025 is OK
- 10.21105/joss.00026 is OK
- 10.1016/j.cam.2013.12.046 is OK
- 10.1590/S1807-03022011000300012 is OK
- 10.1016/j.compfluid.2020.104746 is OK
- 10.5206/mase/10874 is OK
- 10.1016/j.compfluid.2023.105817 is OK
- 10.13140/RG.2.2.31741.95204 is OK
- 10.13140/RG.2.2.19919.25767 is OK
- 10.13140/RG.2.2.26630.14400 is OK
- 10.13140/RG.2.2.28307.86561 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 8 months ago

Wordcount for paper.md is 1012

editorialbot commented 8 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

jedbrown commented 8 months ago

Hi, @jakelangham and @victorapm :wave: Welcome to JOSS and thanks for agreeing to review! The comments from @editorialbot above outline the review process, which takes place in this thread (possibly with issues filed in the MOLE repository). I'll be watching this thread if you have any questions.

The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, the reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention this issue so that a link is created to this thread (and I can keep an eye on what is happening). Please also feel free to comment and ask questions on this thread. In my experience, it is better to post comments/questions/suggestions as you come across them instead of waiting until you've reviewed the entire package.

We aim for reviews to be completed within a month or two. Please let me know if you require some more time. We can also use editorialbot to set automatic reminders if you know you'll be away for a known period of time.

Please feel free to ping me (@jedbrown) if you have any questions/concerns.

jakelangham commented 8 months ago

Review checklist for @jakelangham

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

victorapm commented 8 months ago

Review checklist for @victorapm

Conflict of interest

Code of Conduct

General checks

Functionality

Documentation

Software paper

jedbrown commented 6 months ago

Hi, @jcorbino :wave: I wanted to check in about how things are going. I see the issues that were opened, but don't know who is waiting on whom at this point.

jcorbino commented 5 months ago

Hello @jedbrown - Apologies for the delayed response. I'm currently addressing the issues raised by Jake Langham. I think I'll have those ready by the end of this month.

At the same time, I see that a good portion of his checklist has non-checked items (unrelated to the issues he mentioned in the repo), such as the ones in the "Software paper" section. I don't know the status of that. I assume he's been busy, and he'll review those once I integrate the suggested modifications.

Thank you for your patience.

jakelangham commented 5 months ago

@jcorbino @jedbrown I am getting back to this presently. Actually I wasn't sure whether the right thing to do was wait for updates on the open issues or not, but I agree that other things (e.g. the paper) can be reviewed independently.

jcorbino commented 5 months ago

@editorialbot generate pdf

editorialbot commented 5 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

jcorbino commented 4 months ago

@editorialbot generate pdf

editorialbot commented 4 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

jcorbino commented 4 months ago

@editorialbot generate pdf

editorialbot commented 4 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

jakelangham commented 4 months ago

@jedbrown @jcorbino I have finished working my way through the review bullet points. From what I can see, MOLE is a nice piece of software that should be useful to numerical analysts and any scientists working in applications that would particularly benefit from solving PDEs via mimetic operators.

I have left some points unchecked for now, which relate to issues raised in the repository's tracker. Some of these are substantial. Nevertheless, I would recommend acceptance on their resolution.

Finally, I note that the C++ integration tests are failing at the moment, according to github. Looks like an easy issue, but suppose this should be fixed before any decision on publication!

jedbrown commented 4 months ago

Thanks, @jakelangham. @jcorbino Let us know your timeline for addressing these issues. I see @victorapm has left one unchecked item (Example usage) -- do you need clarification of what he's looking for?

jcorbino commented 4 months ago

Thanks, @jedbrown

I have all the information I need from the reviewers to finish the pending tasks. I've been quite busy with my job, so I estimate this will take me until the end of the month.

jedbrown commented 4 months ago

Sounds good, thanks!

victorapm commented 3 months ago

Hi Jed, I finished my review and would like to recommend publication. Thank you!

jedbrown commented 3 months ago

Thanks @victorapm!

@jcorbino Please let us know when you're ready for @jakelangham to have another look.

jcorbino commented 3 months ago

Hi @jedbrown , I believe it's ready now, so @jakelangham , please take another look whenever you have the time. Thanks!

jakelangham commented 3 months ago

Hi both, @jcorbino @jedbrown I have been away for a bit but am looking at this now.

jakelangham commented 3 months ago

@jcorbino @jedbrown I think there is still more to do regarding testing/functionality (cf https://github.com/jcorbino/mole/issues/12) but upon resolution of this I would gladly recommend acceptance.

jcorbino commented 3 months ago

Thank you, @jakelangham , for the feedback! I just pushed the updated version of the tests (both flavors) so they cover different orders of accuracy and grid resolutions. I hope this is sufficient to fulfill this requirement. @jedbrown , please let me know if anything else is required.

jcorbino commented 3 months ago

@editorialbot generate pdf

editorialbot commented 3 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

jakelangham commented 3 months ago

@jcorbino @jedbrown Hi both - I've finished my review now and think it's ready for publication. Thanks.

jcorbino commented 2 months ago

@jakelangham @victorapm Thank you both for reviewing the article and the library. @jedbrown, please let me know if anything else is required from my side.

jedbrown commented 2 months ago

Thanks for your patience. Please have a look at https://github.com/jcorbino/mole/pull/18 and merge if you feel it is acceptable. Then proceed to:

I can then move forward with recommending acceptance of the submission.

jcorbino commented 2 months ago

Not a problem! Thank you @jedbrown 👍🏻

I merged the PR, and here's the requested information:

jedbrown commented 2 months ago

Thanks. I just want to confirm that you are intentionally clobbering the previous v1.0 tag (there were previous tags up to v5.0) with this new versioning scheme. If so, I think you should update your CITATION.cff (which currently has version: v2.0 from last year). An alternative is to call this v6.0 than to start over with a new versioning scheme.

jcorbino commented 2 months ago

Thank you, @jedbrown - I completely overlooked that. I've now updated the CITATION.cff with the new version and DOI. I prefer keeping this as version 1.0. Thanks again for pointing that out! 👍🏻

jedbrown commented 2 months ago

@editorialbot set v1.0 as version

editorialbot commented 2 months ago

Done! version is now v1.0

jedbrown commented 2 months ago

@editorialbot set 10.5281/zenodo.12752946 as archive

editorialbot commented 2 months ago

Done! archive is now 10.5281/zenodo.12752946

jedbrown commented 2 months ago

@editorialbot recommend-accept

editorialbot commented 2 months ago 
Attempting dry run of processing paper acceptance...
editorialbot commented 2 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.cam.2019.06.042 is OK
- 10.1145/1089014.1089017 is OK
- 10.1080/21681163.2021.1914733 is OK
- 10.1016/j.procs.2013.05.210 is OK
- 10.1190/geo2013-0371.1 is OK
- 10.1111/j.1365-246X.2007.03651.x is OK
- 10.1201/b14575 is OK
- 10.1137/S0895479801398025 is OK
- 10.21105/joss.00026 is OK
- 10.1016/j.cam.2013.12.046 is OK
- 10.1590/S1807-03022011000300012 is OK
- 10.1016/j.compfluid.2020.104746 is OK
- 10.5206/mase/10874 is OK
- 10.1016/j.compfluid.2023.105817 is OK
- 10.13140/RG.2.2.31741.95204 is OK
- 10.13140/RG.2.2.19919.25767 is OK
- 10.13140/RG.2.2.26630.14400 is OK
- 10.13140/RG.2.2.28307.86561 is OK

MISSING DOIs

- No DOI given, and none found for title: OpenBLAS: An Optimized BLAS Library

INVALID DOIs

- None
editorialbot commented 2 months ago

:wave: @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5640, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

danielskatz commented 2 months ago

👋 @jcorbino - as the track chair, I've proofread this submission, and have a couple of small suggestions in https://github.com/jcorbino/mole/pull/19. Please merge this, or let me know what you disagree with.

jcorbino commented 2 months ago

Hi @danielskatz - Thank you for the PR; I just merged it 👍🏻

danielskatz commented 2 months ago

@editorialbot recommend-accept

editorialbot commented 2 months ago 
Attempting dry run of processing paper acceptance...
editorialbot commented 2 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.cam.2019.06.042 is OK
- 10.1145/1089014.1089017 is OK
- 10.1080/21681163.2021.1914733 is OK
- 10.1016/j.procs.2013.05.210 is OK
- 10.1190/geo2013-0371.1 is OK
- 10.1111/j.1365-246X.2007.03651.x is OK
- 10.1201/b14575 is OK
- 10.1137/S0895479801398025 is OK
- 10.21105/joss.00026 is OK
- 10.1016/j.cam.2013.12.046 is OK
- 10.1590/S1807-03022011000300012 is OK
- 10.1016/j.compfluid.2020.104746 is OK
- 10.5206/mase/10874 is OK
- 10.1016/j.compfluid.2023.105817 is OK
- 10.13140/RG.2.2.31741.95204 is OK
- 10.13140/RG.2.2.19919.25767 is OK
- 10.13140/RG.2.2.26630.14400 is OK
- 10.13140/RG.2.2.28307.86561 is OK

MISSING DOIs

- No DOI given, and none found for title: OpenBLAS: An Optimized BLAS Library

INVALID DOIs

- None
editorialbot commented 2 months ago

:wave: @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5643, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

danielskatz commented 2 months ago

@editorialbot accept