openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
714 stars 38 forks source link

[PRE REVIEW]: IKPLS: Improved Kernel Partial Least Squares and Fast Cross-Validation Algorithms for Python with CPU and GPU Implementations Using NumPy and JAX #6290

Closed editorialbot closed 6 months ago

editorialbot commented 8 months ago

Submitting author: !--author-handle-->@Sm00thix<!--end-author-handle-- (Ole-Christian Galbo Engstrøm) Repository: https://github.com/Sm00thix/IKPLS Branch with paper.md (empty if default branch): Version: v1.0.1 Editor: !--editor-->@boisgera<!--end-editor-- Reviewers: @parmentelat, @basileMarchand Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/ac559cbcdc6e6551f58bb3e573a73afc"><img src="https://joss.theoj.org/papers/ac559cbcdc6e6551f58bb3e573a73afc/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/ac559cbcdc6e6551f58bb3e573a73afc/status.svg)](https://joss.theoj.org/papers/ac559cbcdc6e6551f58bb3e573a73afc)

Author instructions

Thanks for submitting your paper to JOSS @Sm00thix. Currently, there isn't a JOSS editor assigned to your paper.

@Sm00thix if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 8 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 8 months ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.08 s (517.2 files/s, 100134.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          18            895           1936           4076
TeX                              1             20              0            188
YAML                             7             24             14            150
reStructuredText                10             73             61            123
Markdown                         1             30              0             76
DOS Batch                        1              8              1             26
TOML                             1              2              0             21
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            40           1056           2019           4669
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 8 months ago

Wordcount for paper.md is 1471

editorialbot commented 8 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 8 months ago

Five most similar historical JOSS papers:

PyKronecker: A Python Library for the Efficient Manipulation of Kronecker Products and Related Structures Submitting author: @nickelnine37 Handling editor: @Kevin-Mattheus-Moerman (Active) Reviewers: @JulianKarlBauer, @nicoguaro Similarity score: 0.8143

kalepy: a Python package for kernel density estimation, sampling and plotting Submitting author: @lzkelley Handling editor: @arfon (Active) Reviewers: @williamjameshandley, @kexinrong Similarity score: 0.8042

CR-Sparse: Hardware accelerated functional algorithms for sparse signal processing in Python using JAX Submitting author: @shailesh1729 Handling editor: @pdebuyl (Active) Reviewers: @Saran-nns, @mirca Similarity score: 0.7965

GGLasso - a Python package for General Graphical Lasso computation Submitting author: @fabian-sp Handling editor: @gkthiruvathukal (Active) Reviewers: @papachristoumarios, @jameschapman19 Similarity score: 0.7964

Pyglmnet: Python implementation of elastic-net regularized generalized linear models Submitting author: @jasmainak Handling editor: @arokem (Retired) Reviewers: @professoralkmin, @ryEllison Similarity score: 0.7938

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

editorialbot commented 8 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1016/s0169-7439(01)00155-1 may be a valid DOI for title: PLS-regression: a basic tool of chemometrics
- 10.1002/(sici)1099-128x(199701)11:1<73::aid-cem435>3.0.co;2-# may be a valid DOI for title: Improved PLS algorithms
- 10.1016/j.trac.2009.07.007 may be a valid DOI for title: Review of the most common pre-processing techniques for near-infrared spectra
- 10.1007/978-981-15-8648-4_7 may be a valid DOI for title: NIR Data Exploration and Regression by Chemometrics—A Primer
- 10.1111/1541-4337.12958 may be a valid DOI for title: Quantitative assessment of wheat quality using near-infrared spectroscopy: A comprehensive review
- 10.1007/s00362-009-0251-7 may be a valid DOI for title: Comparison of PLS algorithms when number of objects is much larger than number of variables
- 10.1002/cem.1248 may be a valid DOI for title: A comparison of nine PLS1 algorithms
- 10.1109/iccvw60793.2023.00055 may be a valid DOI for title: Improving Deep Learning on Hyperspectral Images of Grain by Incorporating Domain Knowledge from Chemometrics
- 10.1177/09670335221078356 may be a valid DOI for title: Hyperspectral imaging for classification of bulk grain samples with deep convolutional neural networks
- 10.1002/cem.3141 may be a valid DOI for title: Orders of magnitude speed increase in partial least squares feature selection with new simple indexing technique for very tall data sets
- 10.1002/cem.3201 may be a valid DOI for title: Much faster cross-validation in PLSR-modelling by avoiding redundant calculations
- 10.21105/joss.01190 may be a valid DOI for title: Multiblock PLS: Block dependent prediction modeling for Python

INVALID DOIs

- None
Sm00thix commented 8 months ago

From the list of reviewers I found three who seem particularly well-suited based on their interests and expertise - especially in the area of chemometrics. I mention them by GitHub username without tagging them. They are listed in no particular order:

arfon commented 8 months ago

@Sm00thix - thanks for your submission to JOSS. We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

arfon commented 7 months ago

@editorialbot invite @boisgera as editor

:wave: @boisgera – would you be willing to edit this submission for JOSS?

editorialbot commented 7 months ago

Invitation to edit this submission sent!

boisgera commented 7 months ago

@editorialbot invite @boisgera as editor

👋 @boisgera – would you be willing to edit this submission for JOSS?

Yes, sure!

arfon commented 7 months ago

@editorialbot assign @boisgera as editor

Thanks @boisgera!

editorialbot commented 7 months ago

Assigned! @boisgera is now the editor

Sm00thix commented 7 months ago

@boisgera thank you for agreeing to be editor. I have realized that I want to make a slight change to some of my code to improve usability. Am I allowed to do so or will it interfere with the review process?

boisgera commented 7 months ago

@boisgera thank you for agreeing to be editor. I have realized that I want to make a slight change to some of my code to improve usability. Am I allowed to do so or will it interfere with the review process?

Hi @Sm00thix,

Sure, go ahead.

Sm00thix commented 7 months ago

Thank you, @boisgera. I have now updated the main branch with my desired changes. Specifically, I included the option to center and/or scale the input data directly in the models. I have updated the documentation, tests, and examples to reflect the changes. I have also released the new version of the package on PyPI. The paper remains unchanged. Now, I am ready to continue with the peer review process.

Sm00thix commented 7 months ago

Hi again, I made some additional updates to the code. I updated the type annotations and added typeguard to the tests to verify the annotations. The documentation and package have been updated accordingly.

boisgera commented 6 months ago

Hi again, I made some additional updates to the code. I updated the type annotations and added typeguard to the tests to verify the annotations. The documentation and package have been updated accordingly.

OK, great! I am currently contacting potential reviewers for your paper ; I'll let you know as soon 2-3 of them are willing to make the review.

Sm00thix commented 6 months ago

Hi again, I made some additional updates to the code. I updated the type annotations and added typeguard to the tests to verify the annotations. The documentation and package have been updated accordingly.

OK, great! I am currently contacting potential reviewers for your paper ; I'll let you know as soon 2-3 of them are willing to make the review.

Sounds good, thank you! I look forward to it.

boisgera commented 6 months ago

@parmentelat has accepted to review your paper; thank you Thierry! 🙏 I'm going to widen a bit the set of potential reviewers that I have contacted to find another person. Some of my initial contacts were not available but gave me good leads.

Sm00thix commented 6 months ago

@parmentelat has accepted to review your paper; thank you Thierry! 🙏

I'm going to widen a bit the set of potential reviewers that I have contacted to find another person. Some of my initial contacts were not available but gave me good leads.

Thank you for the update, @boisgera, and thank you @parmentelat 🥳

boisgera commented 6 months ago

@basileMarchand has accepted to review your papier; thank you Basile! 🙏

I'd like to wait a few days to make sure that no other potential reviewers shows up, then we'll start the review.

boisgera commented 6 months ago

@editorialbot add @parmentelat as reviewer

editorialbot commented 6 months ago

@parmentelat added to the reviewers list!

boisgera commented 6 months ago

@editorialbot add @basileMarchand as reviewer

editorialbot commented 6 months ago

@basileMarchand added to the reviewers list!

Sm00thix commented 6 months ago

Sounds good, @boisgera - thank you for the update. And thank you, @basileMarchand for agreeing to review!

boisgera commented 6 months ago

@editorialbot start review

editorialbot commented 6 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6533.