openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
714 stars 38 forks source link

[REVIEW]: pyEQL: A Python interface for water chemistry #6295

Closed editorialbot closed 6 months ago

editorialbot commented 8 months ago

Submitting author: !--author-handle-->@rkingsbury<!--end-author-handle-- (Ryan Kingsbury) Repository: https://github.com/rkingsbury/pyEQL Branch with paper.md (empty if default branch): joss Version: v1.0.0 Editor: !--editor-->@lucydot<!--end-editor-- Reviewers: @orionarcher, @JacksonBurns, @yuxuanzhuang Archive: 10.5281/zenodo.8332915

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/bdd9e247ea9736a0fdbbd5fe12bef7a6"><img src="https://joss.theoj.org/papers/bdd9e247ea9736a0fdbbd5fe12bef7a6/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/bdd9e247ea9736a0fdbbd5fe12bef7a6/status.svg)](https://joss.theoj.org/papers/bdd9e247ea9736a0fdbbd5fe12bef7a6)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@orionarcher & @JacksonBurns & @yuxuanzhuang, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @lucydot know.

āœØ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest āœØ

Checklists

šŸ“ Checklist for @JacksonBurns

šŸ“ Checklist for @yuxuanzhuang

šŸ“ Checklist for @orionarcher

editorialbot commented 6 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

lucydot commented 6 months ago

@rkingsbury I think it may be a typo: you might need constitutive rather than constituitive.

rkingsbury commented 6 months ago

@rkingsbury I think it may be a typo: you might need constitutive rather than constituitive.

I see. Just fixed.

rkingsbury commented 6 months ago

@editorialbot generate pdf

editorialbot commented 6 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kthyng commented 6 months ago

Ha yeah wasn't sure if it was a word I was unfamiliar with or a typo.

Ok looks like we're all wrapped up!

kthyng commented 6 months ago

@editorialbot accept

editorialbot commented 6 months ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 6 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Kingsbury given-names: Ryan orcid: "https://orcid.org/0000-0002-7168-3967" doi: 10.5281/zenodo.8332915 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Kingsbury given-names: Ryan orcid: "https://orcid.org/0000-0002-7168-3967" date-published: 2024-03-25 doi: 10.21105/joss.06295 issn: 2475-9066 issue: 95 journal: Journal of Open Source Software publisher: name: Open Journals start: 6295 title: "pyEQL: A Python interface for water chemistry" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06295" volume: 9 title: "pyEQL: A Python interface for water chemistry" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 6 months ago

šŸ˜šŸ˜šŸ˜ šŸ‘‰ Toot for this paper šŸ‘ˆ šŸ˜šŸ˜šŸ˜

editorialbot commented 6 months ago

šŸšØšŸšØšŸšØ THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! šŸšØšŸšØšŸšØ

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5174
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06295
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! šŸŽ‰šŸŒˆšŸ¦„šŸ’ƒšŸ‘»šŸ¤˜

Any issues? Notify your editorial technical team...

rkingsbury commented 6 months ago

All looks great. Thank you @lucydot and @kthyng and reviewers!

kthyng commented 6 months ago

Congrats on your new publication @rkingsbury! Many thanks to editor @lucydot and reviewers @orionarcher, @JacksonBurns, and @yuxuanzhuang for your time, hard work, and expertise!!

editorialbot commented 6 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06295/status.svg)](https://doi.org/10.21105/joss.06295)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06295">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06295/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06295/status.svg
   :target: https://doi.org/10.21105/joss.06295

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

kthyng commented 6 months ago

@rkingsbury If you're interested in helping out in the future, please sign up at https://reviewers.joss.theoj.org/.

rkingsbury commented 6 months ago

@rkingsbury If you're interested in helping out in the future, please sign up at https://reviewers.joss.theoj.org/.

Done šŸ‘šŸ»

JacksonBurns commented 6 months ago

Happy to help and congratulations @rkingsbury !