[REVIEW]: Hyperelastics.jl: A Julia package for hyperelastic1 material modelling with a large collection of models

editorialbot commented 7 months ago

Submitting author: !--author-handle-->@cfarm6@AnjaliSandip<!--end-editor-- Reviewers: @fb456, @SotaYoshida Archive: 10.5281/zenodo.10903235

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/439f08d1e0ca104c5e8e1da37a05d3ce"><img src="https://joss.theoj.org/papers/439f08d1e0ca104c5e8e1da37a05d3ce/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/439f08d1e0ca104c5e8e1da37a05d3ce/status.svg)](https://joss.theoj.org/papers/439f08d1e0ca104c5e8e1da37a05d3ce)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@fb456 & @SotaYoshida, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @AnjaliSandip know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @SotaYoshida

📝 Checklist for @fb456

AnjaliSandip commented 5 months ago

@editorialbot check references

editorialbot commented 5 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.cma.2024.116751 is OK
- 10.1115/1.4063348 is OK
- 10.1016/j.heliyon.2024.e25379 is OK
- 10.1016/j.commatsci.2024.112885 is OK
- 10.5281/zenodo.5519971 is OK
- 10.1515/bmt-2014-0146 is OK
- 10.1016/j.eurpolymj.2013.10.006 is OK
- 10.5281/zenodo.7738525 is OK
- 10.1002/cnm.1105 is OK
- 10.1137/141000671 is OK
- 10.1063/1.1712836 is OK
- 10.1016/j.ijsolstr.2014.08.018 is OK
- 10.1002/app.41718 is OK
- 10.1002/polb.20308 is OK
- 10.1063/1.1712836 is OK
- 10.1039/tf9433900241 is OK
- 10.1063/1.1748111 is OK
- 10.1002/app.1975.070190723 is OK
- 10.1016/0022-5096(79)90034-6 is OK
- 10.5254/1.3538289 is OK
- 10.1016/S0022-5096(97)00028-8 is OK
- 10.1016/s0020-7683(03)00086-6 is OK
- 10.1007/s10659-010-9279-0 is OK
- 10.1002/app.41718 is OK
- 10.1155/2019/2832059 is OK
- 10.1007/bf00017296 is OK
- 10.1115/1.3225782 is OK
- 10.5254/1.3538706 is OK
- 10.1016/j.nanoms.2021.07.003 is OK
- 10.1002/polb.20308 is OK
- 10.1061/(ASCE)0733-9399(2006)132:1(54) is OK
- 10.1016/j.crme.2009.12.007 is OK
- 10.5254/rct.19.80387 is OK
- 10.1002/pen.10948 is OK
- 10.1007/bf01597242 is OK
- 10.1016/0020-7225(68)90006-2 is OK
- 10.1002/pol.1958.1202811814 is OK
- 10.1016/s0997-7538(99)00147-3 is OK
- 10.1016/j.euromechsol.2012.09.010 is OK
- 10.1007/bf01410637 is OK
- 10.1007/bfb0115432 is OK
- 10.1007/bf00254166 is OK
- 10.5254/1.3538357 is OK
- 10.1016/0021-9290(87)90262-4 is OK
- 10.1002/(sici)1099-0488(19970915)35:12<1919::aid-polb7>3.0.co;2-k is OK
- 10.5254/1.3547687 is OK
- 10.1007/s10659-005-4408-x is OK
- 10.1177/1081286507076405 is OK
- 10.1007/s10659-006-9085-x is OK
- 10.1063/1.1710039 is OK
- 10.1063/1.1661660 is OK
- 10.5254/1.3542910 is OK
- 10.1016/j.ijsolstr.2004.03.016 is OK
- 10.5254/1.3547576 is OK
- 10.22059/jcamech.2018.245070.204 is OK
- 10.1063/1.1586471 is OK
- 10.1021/ma00231a022 is OK
- 10.1021/ma00231a023 is OK
- 10.1016/0032-3861(86)90231-4 is OK
- 10.1021/ma00198a026 is OK
- 10.1016/s1089-3156(98)00010-5 is OK
- 10.1021/ma970364k is OK
- 10.1063/1.1723785 is OK
- 10.1016/0022-5096(93)90013-6 is OK
- 10.1088/0370-1328/92/1/303 is OK
- 10.5254/1.3538822 is OK
- 10.1016/s0032-3861(03)00411-7 is OK
- 10.1016/j.jmps.2004.03.011 is OK
- 10.1016/j.jmps.2004.10.006 is OK
- 10.1016/j.ijsolstr.2008.08.037 is OK
- 10.1016/j.jmps.2013.03.009 is OK
- 10.1016/j.jmps.2016.05.030 is OK
- 10.1016/j.jmps.2018.04.016 is OK
- 10.1098/rspa.1979.0163 is OK
- 10.1016/0093-6413(92)90021-2 is OK
- 10.1016/0022-5096(93)90043-f is OK
- 10.1016/s0020-7225(02)00140-4 is OK
- 10.1007/s004190000102 is OK
- 10.2324/gomu.65.517 is OK
- 10.1177/10812865211001094 is OK

MISSING DOIs

- No DOI given, and none found for title: Calculation of rubber parts
- No DOI given, and none found for title: A new isotropic hyperelastic strain energy functio...
- No DOI given, and none found for title: A new constitutive model for rubber-like materials
- No DOI given, and none found for title: Scratch behavior of polymers

INVALID DOIs

- None

AnjaliSandip commented 5 months ago

@editorialbot recommend-accept

editorialbot commented 5 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 5 months ago

:wave: @openjournals/pe-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5196, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

editorialbot commented 5 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.cma.2024.116751 is OK
- 10.1115/1.4063348 is OK
- 10.1016/j.heliyon.2024.e25379 is OK
- 10.1016/j.commatsci.2024.112885 is OK
- 10.5281/zenodo.5519971 is OK
- 10.1515/bmt-2014-0146 is OK
- 10.1016/j.eurpolymj.2013.10.006 is OK
- 10.5281/zenodo.7738525 is OK
- 10.1002/cnm.1105 is OK
- 10.1137/141000671 is OK
- 10.1063/1.1712836 is OK
- 10.1016/j.ijsolstr.2014.08.018 is OK
- 10.1002/app.41718 is OK
- 10.1002/polb.20308 is OK
- 10.1063/1.1712836 is OK
- 10.1039/tf9433900241 is OK
- 10.1063/1.1748111 is OK
- 10.1002/app.1975.070190723 is OK
- 10.1016/0022-5096(79)90034-6 is OK
- 10.5254/1.3538289 is OK
- 10.1016/S0022-5096(97)00028-8 is OK
- 10.1016/s0020-7683(03)00086-6 is OK
- 10.1007/s10659-010-9279-0 is OK
- 10.1002/app.41718 is OK
- 10.1155/2019/2832059 is OK
- 10.1007/bf00017296 is OK
- 10.1115/1.3225782 is OK
- 10.5254/1.3538706 is OK
- 10.1016/j.nanoms.2021.07.003 is OK
- 10.1002/polb.20308 is OK
- 10.1061/(ASCE)0733-9399(2006)132:1(54) is OK
- 10.1016/j.crme.2009.12.007 is OK
- 10.5254/rct.19.80387 is OK
- 10.1002/pen.10948 is OK
- 10.1007/bf01597242 is OK
- 10.1016/0020-7225(68)90006-2 is OK
- 10.1002/pol.1958.1202811814 is OK
- 10.1016/s0997-7538(99)00147-3 is OK
- 10.1016/j.euromechsol.2012.09.010 is OK
- 10.1007/bf01410637 is OK
- 10.1007/bfb0115432 is OK
- 10.1007/bf00254166 is OK
- 10.5254/1.3538357 is OK
- 10.1016/0021-9290(87)90262-4 is OK
- 10.1002/(sici)1099-0488(19970915)35:12<1919::aid-polb7>3.0.co;2-k is OK
- 10.5254/1.3547687 is OK
- 10.1007/s10659-005-4408-x is OK
- 10.1177/1081286507076405 is OK
- 10.1007/s10659-006-9085-x is OK
- 10.1063/1.1710039 is OK
- 10.1063/1.1661660 is OK
- 10.5254/1.3542910 is OK
- 10.1016/j.ijsolstr.2004.03.016 is OK
- 10.5254/1.3547576 is OK
- 10.22059/jcamech.2018.245070.204 is OK
- 10.1063/1.1586471 is OK
- 10.1021/ma00231a022 is OK
- 10.1021/ma00231a023 is OK
- 10.1016/0032-3861(86)90231-4 is OK
- 10.1021/ma00198a026 is OK
- 10.1016/s1089-3156(98)00010-5 is OK
- 10.1021/ma970364k is OK
- 10.1063/1.1723785 is OK
- 10.1016/0022-5096(93)90013-6 is OK
- 10.1088/0370-1328/92/1/303 is OK
- 10.5254/1.3538822 is OK
- 10.1016/s0032-3861(03)00411-7 is OK
- 10.1016/j.jmps.2004.03.011 is OK
- 10.1016/j.jmps.2004.10.006 is OK
- 10.1016/j.ijsolstr.2008.08.037 is OK
- 10.1016/j.jmps.2013.03.009 is OK
- 10.1016/j.jmps.2016.05.030 is OK
- 10.1016/j.jmps.2018.04.016 is OK
- 10.1098/rspa.1979.0163 is OK
- 10.1016/0093-6413(92)90021-2 is OK
- 10.1016/0022-5096(93)90043-f is OK
- 10.1016/s0020-7225(02)00140-4 is OK
- 10.1007/s004190000102 is OK
- 10.2324/gomu.65.517 is OK
- 10.1177/10812865211001094 is OK

MISSING DOIs

- No DOI given, and none found for title: Calculation of rubber parts
- No DOI given, and none found for title: A new isotropic hyperelastic strain energy functio...
- No DOI given, and none found for title: A new constitutive model for rubber-like materials
- No DOI given, and none found for title: Scratch behavior of polymers

INVALID DOIs

- None

kyleniemeyer commented 5 months ago

Hi @cfarm6, I'm doing some final checks before publishing.

In the paper text, can you remove the redundant "figure" word before the Figure 1 reference?
In the second paragraph of the Use Case section, please correct "The results are can then be plotted..."
In the Availability section, it should be "GitHub".

cfarm6 commented 5 months ago

@kyleniemeyer Thank you. Those changes have been made.

kyleniemeyer commented 5 months ago

@editorialbot generate pdf

editorialbot commented 5 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kyleniemeyer commented 5 months ago

@editorialbot accept

editorialbot commented 5 months ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 5 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Farmer given-names: Carson orcid: "https://orcid.org/0000-0002-0456-8301" - family-names: Medina given-names: Hector orcid: "https://orcid.org/0000-0003-1014-2275" doi: 10.5281/zenodo.10903235 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Farmer given-names: Carson orcid: "https://orcid.org/0000-0002-0456-8301" - family-names: Medina given-names: Hector orcid: "https://orcid.org/0000-0003-1014-2275" date-published: 2024-04-02 doi: 10.21105/joss.06314 issn: 2475-9066 issue: 96 journal: Journal of Open Source Software publisher: name: Open Journals start: 6314 title: "Hyperelastics.jl: A Julia package for hyperelastic material modelling with a large collection of models" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06314" volume: 9 title: "Hyperelastics.jl: A Julia package for hyperelastic material modelling with a large collection of models" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 5 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 5 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5200
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06314
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

kyleniemeyer commented 5 months ago

Congratulations @cfarm6 on your article's publication in JOSS! Please consider signing up as a reviewer if you haven't already.

Many thanks to @fb456 and @SotaYoshida for reviewing this, and @AnjaliSandip for editing.

editorialbot commented 5 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06314/status.svg)](https://doi.org/10.21105/joss.06314)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06314">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06314/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06314/status.svg
   :target: https://doi.org/10.21105/joss.06314

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

openjournals / joss-reviews