[REVIEW]: REMix: A GAMS-based framework for energy system optimization models

editorialbot commented 7 months ago

Submitting author: !--author-handle-->@mwetz@fraukewiese<!--end-editor-- Reviewers: @loeffko, @david-huck Archive: 10.5281/zenodo.11653916

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/2aea6e13a5f7d48f9ebaf166f1a24aca"><img src="https://joss.theoj.org/papers/2aea6e13a5f7d48f9ebaf166f1a24aca/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/2aea6e13a5f7d48f9ebaf166f1a24aca/status.svg)](https://joss.theoj.org/papers/2aea6e13a5f7d48f9ebaf166f1a24aca)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@loeffko & @david-huck, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @fraukewiese know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @loeffko

📝 Checklist for @david-huck

editorialbot commented 3 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

mwetz commented 3 months ago

Thanks @mwetz and @hcgils : Could you, in line 28 and 29 put spaces in front of the brackets, e.g. OSeMOSYS(Howells et al., 2011) -> OSeMOSYS (Howells et al., 2011) It is just a minor thing, but it would be great if you can correct it before the paper is published.

Hi @fraukewiese, should be fixed now!

fraukewiese commented 2 months ago

Thanks @mwetz and @hcgils and congratulations :)

fraukewiese commented 2 months ago

@editorialbot recommend-accept

editorialbot commented 2 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 2 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5334/jors.188 is OK
- 10.1016/j.eneco.2016.06.021 is OK
- 10.1016/j.renene.2021.08.016 is OK
- 10.1016/j.egyr.2021.07.005 is OK
- 10.1016/j.renene.2023.04.015 is OK
- 10.1016/j.apenergy.2016.12.023 is OK
- 10.1016/j.energy.2017.01.115 is OK
- 10.1016/j.renene.2016.12.043 is OK
- 10.3389/fenrg.2020.541495 is OK
- 10.1016/j.rser.2014.02.003 is OK
- 10.57676/w2rq-bj85 is OK
- 10.5281/zenodo.3865460 is OK
- 10.1016/j.enpol.2011.06.033 is OK
- 10.18419/opus-2015 is OK
- 10.3390/en12244656 is OK
- 10.1016/j.esr.2018.07.001 is OK
- 10.1016/j.simpa.2020.100028 is OK
- 10.3390/su10061916 is OK
- 10.1002/ese3.891 is OK
- 10.1016/j.est.2024.110959 is OK

MISSING DOIs

- No DOI given, and none found for title: Monitoring resilience of future energy systems
- No DOI given, and none found for title: SESAME SEEED project description
- No DOI given, and none found for title: UNSEEN project description
- No DOI given, and none found for title: ReMoDigital project description
- No DOI given, and none found for title: Welcome to oemof’s documentation! — oemof.solph 0....
- No DOI given, and none found for title: ENTSO-E: TYNDP - Market modelling data

INVALID DOIs

- None

editorialbot commented 2 months ago

:wave: @openjournals/pe-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5577, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

kyleniemeyer commented 2 months ago

@editorialbot set 10.5281/zenodo.11653916 as archive

editorialbot commented 2 months ago

Done! archive is now 10.5281/zenodo.11653916

kyleniemeyer commented 2 months ago

@editorialbot accept

editorialbot commented 2 months ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 2 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Wetzel given-names: Manuel orcid: "https://orcid.org/0000-0001-7838-2414" - family-names: Ruiz given-names: Eugenio Salvador Arellano orcid: "https://orcid.org/0000-0003-2508-3976" - family-names: Witte given-names: Francesco orcid: "https://orcid.org/0000-0003-4019-0390" - family-names: Schmugge given-names: Jens orcid: "https://orcid.org/0000-0002-8889-682X" - family-names: Sasanpour given-names: Shima orcid: "https://orcid.org/0000-0002-7502-6841" - family-names: Yeligeti given-names: Madhura orcid: "https://orcid.org/0000-0002-9643-465X" - family-names: Miorelli given-names: Fabia orcid: "https://orcid.org/0000-0001-5095-5401" - family-names: Buschmann given-names: Jan orcid: "https://orcid.org/0009-0002-8626-8413" - family-names: Cao given-names: Karl-Kiên orcid: "https://orcid.org/0000-0002-9720-0337" - family-names: Wulff given-names: Niklas orcid: "https://orcid.org/0000-0002-4659-6984" - family-names: Gardian given-names: Hedda orcid: "https://orcid.org/0000-0003-1113-0225" - family-names: Rubbert given-names: Alexander orcid: "https://orcid.org/0000-0001-6621-9900" - family-names: Fuchs given-names: Benjamin orcid: "https://orcid.org/0000-0002-7820-851X" - family-names: Scholz given-names: Yvonne orcid: "https://orcid.org/0000-0002-1633-3825" - family-names: Gils given-names: Hans Christian orcid: "https://orcid.org/0000-0001-6745-6609" contact: - family-names: Gils given-names: Hans Christian orcid: "https://orcid.org/0000-0001-6745-6609" doi: 10.5281/zenodo.11653916 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Wetzel given-names: Manuel orcid: "https://orcid.org/0000-0001-7838-2414" - family-names: Ruiz given-names: Eugenio Salvador Arellano orcid: "https://orcid.org/0000-0003-2508-3976" - family-names: Witte given-names: Francesco orcid: "https://orcid.org/0000-0003-4019-0390" - family-names: Schmugge given-names: Jens orcid: "https://orcid.org/0000-0002-8889-682X" - family-names: Sasanpour given-names: Shima orcid: "https://orcid.org/0000-0002-7502-6841" - family-names: Yeligeti given-names: Madhura orcid: "https://orcid.org/0000-0002-9643-465X" - family-names: Miorelli given-names: Fabia orcid: "https://orcid.org/0000-0001-5095-5401" - family-names: Buschmann given-names: Jan orcid: "https://orcid.org/0009-0002-8626-8413" - family-names: Cao given-names: Karl-Kiên orcid: "https://orcid.org/0000-0002-9720-0337" - family-names: Wulff given-names: Niklas orcid: "https://orcid.org/0000-0002-4659-6984" - family-names: Gardian given-names: Hedda orcid: "https://orcid.org/0000-0003-1113-0225" - family-names: Rubbert given-names: Alexander orcid: "https://orcid.org/0000-0001-6621-9900" - family-names: Fuchs given-names: Benjamin orcid: "https://orcid.org/0000-0002-7820-851X" - family-names: Scholz given-names: Yvonne orcid: "https://orcid.org/0000-0002-1633-3825" - family-names: Gils given-names: Hans Christian orcid: "https://orcid.org/0000-0001-6745-6609" date-published: 2024-07-08 doi: 10.21105/joss.06330 issn: 2475-9066 issue: 99 journal: Journal of Open Source Software publisher: name: Open Journals start: 6330 title: "REMix: A GAMS-based framework for optimizing energy system models" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06330" volume: 9 title: "REMix: A GAMS-based framework for optimizing energy system models" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 2 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 2 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5589
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06330
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

kyleniemeyer commented 2 months ago

Congratulations @mwetz and @hcgils on your article's publication in JOSS! Please consider signing up as a reviewer if you haven't already.

Many thanks to @loeffko and @david-huck for reviewing this, and @fraukewiese for editing.

editorialbot commented 2 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06330/status.svg)](https://doi.org/10.21105/joss.06330)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06330">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06330/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06330/status.svg
   :target: https://doi.org/10.21105/joss.06330

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

mwetz commented 2 months ago

Dear @kyleniemeyer, We did a final proofreading of the paper yesterday, as I expected that we would have to give a final approval of the proof from last Friday. We just finished the process and made some last minor changes (bad formatting of the lower 2 in CO2, some missing capitalization in the bibliography, and some AE/BE spelling adjustments). Everything is now committed to the git repository. Would it still be possible to include them in the final version of the published paper?

kyleniemeyer commented 2 months ago

@editorialbot reaccept

editorialbot commented 2 months ago

Rebuilding paper!

editorialbot commented 2 months ago

🌈 Paper updated!

New PDF and metadata files :point_right: https://github.com/openjournals/joss-papers/pull/5594

kyleniemeyer commented 2 months ago

@mwetz ok, the final PDF should be updated now. It may take a few minutes for the version on the JOSS website to reflect the changes, but the version at https://github.com/openjournals/joss-papers/pull/5594 looks updated.

mwetz commented 2 months ago

@kyleniemeyer Excellent, thanks for integrating our last minutes changes! The paper now looks as it should.

openjournals / joss-reviews