openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
719 stars 38 forks source link

[PRE REVIEW]: MarSwitching.jl: A Julia package for Markov switching dynamic models #6344

Closed editorialbot closed 7 months ago

editorialbot commented 8 months ago

Submitting author: !--author-handle-->@m-dadej<!--end-author-handle-- (Mateusz Dadej) Repository: https://github.com/m-dadej/MarSwitching.jl Branch with paper.md (empty if default branch): joss Version: 0.2.2 Editor: !--editor-->@jbytecode<!--end-editor-- Reviewers: @y1my1, @mkitti Managing EiC: Olivia Guest

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f0b33a8a4b30b3d9f0184dec014eb388"><img src="https://joss.theoj.org/papers/f0b33a8a4b30b3d9f0184dec014eb388/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f0b33a8a4b30b3d9f0184dec014eb388/status.svg)](https://joss.theoj.org/papers/f0b33a8a4b30b3d9f0184dec014eb388)

Author instructions

Thanks for submitting your paper to JOSS @m-dadej. Currently, there isn't a JOSS editor assigned to your paper.

@m-dadej if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 8 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 8 months ago

Couldn't check the bibtex because branch name is incorrect: https://github.com/m-dadej/MarSwitching.jl/tree/joss

editorialbot commented 8 months ago

Couldn't check the bibtex because branch name is incorrect: https://github.com/m-dadej/MarSwitching.jl/tree/joss

editorialbot commented 8 months ago

:warning: An error happened when generating the pdf.

m-dadej commented 8 months ago

@editorialbot commands

editorialbot commented 8 months ago

Hello @m-dadej, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers
m-dadej commented 8 months ago

@editorialbot set joss as branch

editorialbot commented 8 months ago

Done! branch is now joss

m-dadej commented 8 months ago

@editorialbot check repository

editorialbot commented 8 months ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.06 s (819.6 files/s, 112617.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
SVG                              9              0              0           2659
Julia                           11            405            124           1309
Markdown                         8            243              0            904
YAML                             8              5              8            189
TeX                              2             16              0            172
CSS                              1             12              0             76
R                                2             21              9             44
TOML                             2              4              0             29
Python                           1              5              1             26
MATLAB                           1              7              8             24
JSON                             1              4              0             17
-------------------------------------------------------------------------------
SUM:                            46            722            150           5449
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 8 months ago

Wordcount for paper.md is 1308

jbytecode commented 8 months ago

@editorialbot generate pdf

editorialbot commented 8 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 8 months ago

Five most similar historical JOSS papers:

MLJ: A Julia package for composable machine learning Submitting author: @ablaom Handling editor: @terrytangyuan (Retired) Reviewers: @degleris1, @henrykironde Similarity score: 0.8126

TimeseriesSurrogates.jl: a Julia package for generating surrogate data Submitting author: @kahaaga Handling editor: @jarvist (Active) Reviewers: @lucaferranti, @dawbarton Similarity score: 0.8108

ScenTrees.jl: A Julia Package for Generating Scenario Trees and Scenario Lattices for Multistage Stochastic Programming Submitting author: @kirui93 Handling editor: @melissawm (Retired) Reviewers: @juliohm, @matbesancon Similarity score: 0.8084

PyMSM: Python package for Competing Risks and Multi-State models for Survival Data Submitting author: @hrossman Handling editor: @majensen (Active) Reviewers: @CamDavidsonPilon, @stefanocoretta Similarity score: 0.8079

JMcDM: A Julia package for multiple-criteria decision-making tools Submitting author: @jbytecode Handling editor: @drvinceknight (Active) Reviewers: @brunaw, @sylvaticus Similarity score: 0.8033

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

oliviaguest commented 8 months ago

@jbytecode feel free to take this 😊

oliviaguest commented 8 months ago

@editorialbot assign @jbytecode as editor

editorialbot commented 8 months ago

Assigned! @jbytecode is now the editor

jbytecode commented 8 months ago

@m-dadej - Hi, thank you for submitting your work to JOSS. I am the handling editor. Do you have any suggestion for reviewers? You can use the potential reviewers list provided at the top of this issue. I think people interested in statistics and Julia would be a good fit. (The authors of Five most similar historical JOSS papers are high priority). If you have suggestions, please provide a list of potential reviewers here but do not use the @ character to avoid receiving unwanted notifications. Thank you in advance.

jbytecode commented 8 months ago

@editorialbot check references

editorialbot commented 8 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1142/S0219024902001523 is OK
- 10.1017/S0305004100030401 is OK

MISSING DOIs

- 10.1137/141000671 may be a valid DOI for title: Julia: A fresh approach to numerical computing
- 10.2307/1912559 may be a valid DOI for title: A New Approach to the Economic Analysis of Nonstationary Time Series and the Business Cycle
- 10.32614/rj-2019-012 may be a valid DOI for title: What’s for dynr: A package for linear and nonlinear dynamic modeling in R
- 10.25080/majora-92bf1922-011 may be a valid DOI for title: statsmodels: Econometric and statistical modeling with python
- 10.2139/ssrn.1714016 may be a valid DOI for title: MS_Regress - The MATLAB Package for Markov Regime Switching Models

INVALID DOIs

- https://doi.org/10.1016/j.ijforecast.2014.03.014 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.ejrh.2023.101374 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.csfx.2021.100059 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.joi.2020.101081 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/0304-4076(94)90036-1 is INVALID because of 'https://doi.org/' prefix
jbytecode commented 8 months ago

@m-dadej - Some of the citations have missing or invalid DOIs. Please fix them as the editorialbot suggests.

m-dadej commented 8 months ago

@editorialbot check references

editorialbot commented 8 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1137/141000671 is OK
- 10.2307/1912559 is OK
- 10.1142/S0219024902001523 is OK
- 10.1016/j.ijforecast.2014.03.014 is OK
- 10.1016/j.ejrh.2023.101374 is OK
- 10.1016/j.csfx.2021.100059 is OK
- 10.1016/j.joi.2020.101081 is OK
- 10.32614/rj-2019-012 is OK
- 10.25080/majora-92bf1922-011 is OK
- 10.2139/ssrn.1714016 is OK
- 10.2307/1392086 is OK
- 10.1017/S0305004100030401 is OK
- 10.1016/0304-4076(94)90036-1 is OK

MISSING DOIs

- None

INVALID DOIs

- None
m-dadej commented 8 months ago

Hi, I don't have any prior knowledge regarding appropriate reviewers but from looking at the list I think these could be good:

-daviddewhurst -Dom-Owens-UoB -SaranjeetKaur -yasinkutuk -mirca

jbytecode commented 8 months ago

πŸ‘‹πŸ‘‹πŸ‘‹ Dear @mirca, @Dom-Owens-UoB and @daviddewhurst πŸ‘‹πŸ‘‹πŸ‘‹

Would you be willing to assist in reviewing this submission for JOSS (Journal of Open Source Software)?

JOSS publishes articles about open source research software. The submission I'd like you to review is titled:

MarSwitching.jl: A Julia package for Markov switching dynamic models

You can find more information at the top of this Github issue (https://github.com/openjournals/joss-reviews/issues/6344).

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. If you have any questions please let me know.

This is the pre-review issue. After setting at least 2 reviewers we will start the review process in a separate thread. In that thread, there will be 23 check items for each single reviewer.

Thank you in advance!

jbytecode commented 8 months ago

πŸ‘‹πŸ‘‹πŸ‘‹ Dear @pitmonticone, @sgeorge91, and @felixcremer πŸ‘‹πŸ‘‹πŸ‘‹

Would you be willing to assist in reviewing this submission for JOSS (Journal of Open Source Software)?

JOSS publishes articles about open source research software. The submission I'd like you to review is titled:

MarSwitching.jl: A Julia package for Markov switching dynamic models

You can find more information at the top of this Github issue (https://github.com/openjournals/joss-reviews/issues/6344).

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. If you have any questions please let me know.

This is the pre-review issue. After setting at least 2 reviewers we will start the review process in a separate thread. In that thread, there will be 23 check items for each single reviewer.

Thank you in advance!

jbytecode commented 8 months ago

πŸ‘‹πŸ‘‹πŸ‘‹ Dear @SaranjeetKaur and @yasinkutuk πŸ‘‹πŸ‘‹πŸ‘‹

Would you be willing to assist in reviewing this submission for JOSS (Journal of Open Source Software)?

JOSS publishes articles about open source research software. The submission I'd like you to review is titled:

MarSwitching.jl: A Julia package for Markov switching dynamic models

You can find more information at the top of this Github issue (https://github.com/openjournals/joss-reviews/issues/6344).

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. If you have any questions please let me know.

This is the pre-review issue. After setting at least 2 reviewers we will start the review process in a separate thread. In that thread, there will be 23 check items for each single reviewer.

Thank you in advance!

jbytecode commented 7 months ago

@m-dadej - Do you have any other suggestions for suitable reviewers?

m-dadej commented 7 months ago

From what I see on the list these might fit the role:

jbytecode commented 7 months ago

πŸ‘‹πŸ‘‹πŸ‘‹ Dear @y1my1, @Edenhofer, and @vankesteren πŸ‘‹πŸ‘‹πŸ‘‹

Would you be willing to assist in reviewing this submission for JOSS (Journal of Open Source Software)?

JOSS publishes articles about open source research software. The submission I'd like you to review is titled:

MarSwitching.jl: A Julia package for Markov switching dynamic models

You can find more information at the top of this Github issue (https://github.com/openjournals/joss-reviews/issues/6344).

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. If you have any questions please let me know.

This is the pre-review issue. After setting at least 2 reviewers we will start the review process in a separate thread. In that thread, there will be 23 check items for each single reviewer.

Thank you in advance!

Edenhofer commented 7 months ago

I don't think the paper is quite up my alley. Sorry.

y1my1 commented 7 months ago

Yes, I can help review this.

jbytecode commented 7 months ago

@editorialbot add @y1my1 as reviewer

@y1my1 - Thank you for accepting our invitation. Whenever we assign at least one more reviewer, we will start review in a separate thread.

editorialbot commented 7 months ago

@y1my1 added to the reviewers list!

vankesteren commented 7 months ago

Sorry, not available currently!

jbytecode commented 7 months ago

πŸ‘‹πŸ‘‹πŸ‘‹ Dear @harishsiravuri and @ManuelStapper πŸ‘‹πŸ‘‹πŸ‘‹

Would you be willing to assist in reviewing this submission for JOSS (Journal of Open Source Software)?

JOSS publishes articles about open source research software. The submission I'd like you to review is titled:

MarSwitching.jl: A Julia package for Markov switching dynamic models

You can find more information at the top of this Github issue (https://github.com/openjournals/joss-reviews/issues/6344).

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. If you have any questions please let me know.

This is the pre-review issue. After setting at least 2 reviewers we will start the review process in a separate thread. In that thread, there will be 23 check items for each single reviewer.

Thank you in advance!

jbytecode commented 7 months ago

@mkitti - Do you a have time span to perform a review for this paper? We have difficulties finding suitable reviewers for this paper. The software developed in this submission is written with Julia. Thank you in advance.

mkitti commented 7 months ago

Yes, I can take this on if there are no other reviewers

jbytecode commented 7 months ago

@editorialbot add @mkitti as reviewer

editorialbot commented 7 months ago

@mkitti added to the reviewers list!

jbytecode commented 7 months ago

@mkitti - Thank you for accepting our invitation.

@y1my1, @mkitti - The review will start in a separate thread. I will introduce the instruction there. Thank you in advance.

@m-dadej - Please keep in touch in the review thread.

Now, I am closing this issue

jbytecode commented 7 months ago

@editorialbot start review

editorialbot commented 7 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6441.