[REVIEW]: TelescopeML -- I. An End-to-End Python Package for Interpreting Telescope Datasets through Training Machine Learning Models, Generating Statistical Reports, and Visualizing Results

editorialbot commented 9 months ago

Submitting author: !--author-handle-->@EhsanGharibNezhad@plaplant<!--end-editor-- Reviewers: @oparisot, @mwalmsley Archive: 10.5281/zenodo.11553655

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/341c09d394beb3918d85a6b176eb9b83"><img src="https://joss.theoj.org/papers/341c09d394beb3918d85a6b176eb9b83/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/341c09d394beb3918d85a6b176eb9b83/status.svg)](https://joss.theoj.org/papers/341c09d394beb3918d85a6b176eb9b83)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@oparisot, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @plaplant know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @oparisot

📝 Checklist for @mwalmsley

plaplant commented 4 months ago

@editorialbot generate pdf

editorialbot commented 4 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

plaplant commented 4 months ago

@editorialbot check references

editorialbot commented 4 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.ymssp.2020.107398 is OK
- 10.3847/1538-3881/aae77c is OK
- 10.3847/2041-8213/acb04a is OK
- 10.1038/s41586-022-05591-3 is OK
- 10.1088/1538-3873/acd1b5 is OK
- 10.48550/arXiv.1705.05165 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.21105/joss.03021 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.5281/zenodo.3509134 is OK
- 10.3847/1538-4357/ac7c74 is OK
- 10.1016/j.jqsrt.2007.11.006 is OK
- 10.1093/mnras/stab1405 is OK
- 10.1088/0004-637X/802/2/107 is OK
- 10.1088/1538-3873/aaf5ad is OK
- 10.1051/0004-6361/201935470 is OK
- 10.1088/0004-637X/775/2/137 is OK
- 10.21105/joss.04873 is OK
- 10.1038/s41550-018-0504-2 is OK
- 10.1088/0004-637X/812/2/128 is OK
- 10.1146/annurev-astro-082214-122522 is OK
- 10.3847/1538-4357/acabc2 is OK
- 10.3847/1538-4357/ab1b51 is OK
- 10.3847/1538-4357/ace530 is OK

MISSING DOIs

- No DOI given, and none found for title: Deep Learning
- No DOI given, and none found for title: Bokeh: Python library for interactive visualizatio...
- No DOI given, and none found for title:  TensorFlow: Large-Scale Machine Learning on Heter...
- No DOI given, and none found for title: Scikit-learn: Machine Learning in Python
- 10.3847/1538-4357/ac141d may be a valid DOI for title: The Sonora Brown Dwarf Atmosphere and Evolution Mo...
- 10.1088/0004-637x/783/2/70 may be a valid DOI for title: A systematic retrieval analysis of secondary eclip...
- 10.3847/1538-4357/ac4399 may be a valid DOI for title: ExoMiner: A Highly Accurate and Explainable Deep L...

INVALID DOIs

- None

plaplant commented 4 months ago

@EhsanGharibNezhad thanks for addressing the remaining issues! I made a small PR here that should resolve a few small citation and reference issues. Once that's merged in, I think this will be ready to accept!

EhsanGharibNezhad commented 4 months ago

Accepted your PR! Thanks! :)

plaplant commented 4 months ago

@editorialbot generate pdf

editorialbot commented 4 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

plaplant commented 4 months ago

@editorialbot check references

editorialbot commented 4 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.ymssp.2020.107398 is OK
- 10.3847/1538-3881/aae77c is OK
- 10.3847/2041-8213/acb04a is OK
- 10.1038/s41586-022-05591-3 is OK
- 10.1088/1538-3873/acd1b5 is OK
- 10.48550/arXiv.1705.05165 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.21105/joss.03021 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.5281/zenodo.3509134 is OK
- 10.3847/1538-4357/ac7c74 is OK
- 10.1016/j.jqsrt.2007.11.006 is OK
- 10.1093/mnras/stab1405 is OK
- 10.1088/0004-637X/802/2/107 is OK
- 10.1088/1538-3873/aaf5ad is OK
- 10.1051/0004-6361/201935470 is OK
- 10.1088/0004-637X/775/2/137 is OK
- 10.21105/joss.04873 is OK
- 10.1038/s41550-018-0504-2 is OK
- 10.1088/0004-637X/812/2/128 is OK
- 10.3847/1538-4357/ac141d is OK
- 10.1146/annurev-astro-082214-122522 is OK
- 10.1088/0004-637x/783/2/70 is OK
- 10.3847/1538-4357/acabc2 is OK
- 10.3847/1538-4357/ab1b51 is OK
- 10.3847/1538-4357/ac4399 is OK
- 10.3847/1538-4357/ace530 is OK

MISSING DOIs

- No DOI given, and none found for title: Deep Learning
- No DOI given, and none found for title: Bokeh: Python library for interactive visualizatio...
- No DOI given, and none found for title:  TensorFlow: Large-Scale Machine Learning on Heter...
- No DOI given, and none found for title: Scikit-learn: Machine Learning in Python

INVALID DOIs

- None

plaplant commented 4 months ago

@editorialbot recommend-accept

editorialbot commented 4 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 4 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.ymssp.2020.107398 is OK
- 10.3847/1538-3881/aae77c is OK
- 10.3847/2041-8213/acb04a is OK
- 10.1038/s41586-022-05591-3 is OK
- 10.1088/1538-3873/acd1b5 is OK
- 10.48550/arXiv.1705.05165 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.21105/joss.03021 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.5281/zenodo.3509134 is OK
- 10.3847/1538-4357/ac7c74 is OK
- 10.1016/j.jqsrt.2007.11.006 is OK
- 10.1093/mnras/stab1405 is OK
- 10.1088/0004-637X/802/2/107 is OK
- 10.1088/1538-3873/aaf5ad is OK
- 10.1051/0004-6361/201935470 is OK
- 10.1088/0004-637X/775/2/137 is OK
- 10.21105/joss.04873 is OK
- 10.1038/s41550-018-0504-2 is OK
- 10.1088/0004-637X/812/2/128 is OK
- 10.3847/1538-4357/ac141d is OK
- 10.1146/annurev-astro-082214-122522 is OK
- 10.1088/0004-637x/783/2/70 is OK
- 10.3847/1538-4357/acabc2 is OK
- 10.3847/1538-4357/ab1b51 is OK
- 10.3847/1538-4357/ac4399 is OK
- 10.3847/1538-4357/ace530 is OK

MISSING DOIs

- No DOI given, and none found for title: Deep Learning
- No DOI given, and none found for title: Bokeh: Python library for interactive visualizatio...
- No DOI given, and none found for title:  TensorFlow: Large-Scale Machine Learning on Heter...
- No DOI given, and none found for title: Scikit-learn: Machine Learning in Python

INVALID DOIs

- None

editorialbot commented 4 months ago

:wave: @openjournals/aass-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5587, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

EhsanGharibNezhad commented 4 months ago

@editorialbot accept

editorialbot commented 4 months ago

I'm sorry @EhsanGharibNezhad, I'm afraid I can't do that. That's something only eics are allowed to do.

EhsanGharibNezhad commented 4 months ago

👋 @openjournals/aass-eics, this paper is ready to be accepted and published.

Check final proof 👉📄 Download article

If the paper PDF and the deposit XML files look good in openjournals/joss-papers#5587, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

@plaplant I'm not sure if I need to compile that command?

plaplant commented 4 months ago

@EhsanGharibNezhad apologies for the confusion. I don't personally have the authority to officially accept a publication, as that can only be done by one of the Editors-in-Chief (eics). I have recommended its acceptance, so now it goes to them to officially accept. This process usually happens within a few days, but I will follow up early next week if it hasn't happened by then.

EhsanGharibNezhad commented 4 months ago

No problem! Thank you! :)

dfm commented 4 months ago

@EhsanGharibNezhad — I've opened a small PR with some typographic edits. Once you merge that I can proceed with acceptance.

EhsanGharibNezhad commented 4 months ago

@dfm Done! Thanks!

dfm commented 3 months ago

@editorialbot recommend-accept

editorialbot commented 3 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 3 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.ymssp.2020.107398 is OK
- 10.3847/1538-3881/aae77c is OK
- 10.3847/2041-8213/acb04a is OK
- 10.1038/s41586-022-05591-3 is OK
- 10.1088/1538-3873/acd1b5 is OK
- 10.48550/arXiv.1705.05165 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.21105/joss.03021 is OK
- 10.1109/MCSE.2007.55 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.5281/zenodo.3509134 is OK
- 10.3847/1538-4357/ac7c74 is OK
- 10.1016/j.jqsrt.2007.11.006 is OK
- 10.1093/mnras/stab1405 is OK
- 10.1088/0004-637X/802/2/107 is OK
- 10.1088/1538-3873/aaf5ad is OK
- 10.1051/0004-6361/201935470 is OK
- 10.1088/0004-637X/775/2/137 is OK
- 10.21105/joss.04873 is OK
- 10.1038/s41550-018-0504-2 is OK
- 10.1088/0004-637X/812/2/128 is OK
- 10.3847/1538-4357/ac141d is OK
- 10.1146/annurev-astro-082214-122522 is OK
- 10.1088/0004-637x/783/2/70 is OK
- 10.3847/1538-4357/acabc2 is OK
- 10.3847/1538-4357/ab1b51 is OK
- 10.3847/1538-4357/ac4399 is OK
- 10.3847/1538-4357/ace530 is OK

MISSING DOIs

- No DOI given, and none found for title: Deep Learning
- No DOI given, and none found for title: Bokeh: Python library for interactive visualizatio...
- No DOI given, and none found for title:  TensorFlow: Large-Scale Machine Learning on Heter...
- No DOI given, and none found for title: Scikit-learn: Machine Learning in Python

INVALID DOIs

- None

editorialbot commented 3 months ago

:wave: @openjournals/aass-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5649, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

dfm commented 3 months ago

@editorialbot accept

editorialbot commented 3 months ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 3 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Gharib-Nezhad given-names: Ehsan (Sam) orcid: "https://orcid.org/0000-0002-4088-7262" - family-names: Batalha given-names: Natasha E. orcid: "https://orcid.org/0000-0003-1240-6844" - family-names: Valizadegan given-names: Hamed orcid: "https://orcid.org/0000-0001-6732-0840" - family-names: Martinho given-names: Miguel J. S. orcid: "https://orcid.org/0000-0002-2188-0807" - family-names: Habibi given-names: Mahdi orcid: "https://orcid.org/0000-0001-8530-7746" - family-names: Nookula given-names: Gopal doi: 10.5281/zenodo.11553655 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Gharib-Nezhad given-names: Ehsan (Sam) orcid: "https://orcid.org/0000-0002-4088-7262" - family-names: Batalha given-names: Natasha E. orcid: "https://orcid.org/0000-0003-1240-6844" - family-names: Valizadegan given-names: Hamed orcid: "https://orcid.org/0000-0001-6732-0840" - family-names: Martinho given-names: Miguel J. S. orcid: "https://orcid.org/0000-0002-2188-0807" - family-names: Habibi given-names: Mahdi orcid: "https://orcid.org/0000-0001-8530-7746" - family-names: Nookula given-names: Gopal date-published: 2024-07-18 doi: 10.21105/joss.06346 issn: 2475-9066 issue: 99 journal: Journal of Open Source Software publisher: name: Open Journals start: 6346 title: TelescopeML -- I. An End-to-End Python Package for Interpreting Telescope Datasets through Training Machine Learning Models, Generating Statistical Reports, and Visualizing Results type: article url: "https://joss.theoj.org/papers/10.21105/joss.06346" volume: 9 title: TelescopeML -- I. An End-to-End Python Package for Interpreting Telescope Datasets through Training Machine Learning Models, Generating Statistical Reports, and Visualizing Results ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 3 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 3 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5650
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06346
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

dfm commented 3 months ago

Many thanks to @oparisot and @mwalmsley for reviewing and to @plaplant for editing! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you!!

@EhsanGharibNezhad — Your paper is now accepted and published in JOSS! :zap::rocket::boom:

Note: I'm currently seeing that the PDF isn't appearing on the DOI page. This sometimes happens for a few hours because of some caching issues on the back end. If this doesn't resolve itself by tomorrow, let me know and I'll look into it!

editorialbot commented 3 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06346/status.svg)](https://doi.org/10.21105/joss.06346)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06346">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06346/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06346/status.svg
   :target: https://doi.org/10.21105/joss.06346

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

EhsanGharibNezhad commented 3 months ago

Many thanks to @oparisot and @mwalmsley for reviewing and to @plaplant for editing! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you!!

@EhsanGharibNezhad — Your paper is now accepted and published in JOSS! ⚡🚀💥

Note: I'm currently seeing that the PDF isn't appearing on the DOI page. This sometimes happens for a few hours because of some caching issues on the back end. If this doesn't resolve itself by tomorrow, let me know and I'll look into it!

Thank you all! It was a wonderful experience going through all steps! :)

openjournals / joss-reviews