openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
696 stars 36 forks source link

[PRE REVIEW]: EddyProfSync: A MATLAB tools for collocating coherent eddy and hydrographic datasets #6347

Closed editorialbot closed 5 months ago

editorialbot commented 5 months ago

Submitting author: !--author-handle-->@rampatels<!--end-author-handle-- (Ramkrushnbhai Shaileshbhai Patel) Repository: https://github.com/rampatels/EddyProfileCollocator Branch with paper.md (empty if default branch): Version: v1.0.0 Editor: Pending Reviewers: Pending Managing EiC: Kristen Thyng

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/43c30827f0893d2dc1f292cae03b0203"><img src="https://joss.theoj.org/papers/43c30827f0893d2dc1f292cae03b0203/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/43c30827f0893d2dc1f292cae03b0203/status.svg)](https://joss.theoj.org/papers/43c30827f0893d2dc1f292cae03b0203)

Author instructions

Thanks for submitting your paper to JOSS @rampatels. Currently, there isn't a JOSS editor assigned to your paper.

@rampatels if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 5 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 5 months ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.17 s (109.4 files/s, 363606.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                             2           3398              4          42333
MATLAB                          11            157            387            424
Jupyter Notebook                 2              0          15865            327
TeX                              1             12              0            107
Markdown                         2             33              0             92
JSON                             1              0              0              3
-------------------------------------------------------------------------------
SUM:                            19           3600          16256          43286
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 5 months ago

Wordcount for paper.md is 483

editorialbot commented 5 months ago

Failed to discover a valid open source license

editorialbot commented 5 months ago

Failed to discover a Statement of need section in paper

editorialbot commented 5 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 5 months ago

Five most similar historical JOSS papers:

ecopath_matlab: A Matlab-based implementation of the Ecopath food web algorithm Submitting author: @kakearney Handling editor: @Kevin-Mattheus-Moerman (Active) Reviewers: @roliveros-ramos Similarity score: 0.8285

BioSigKit: A Matlab Toolbox and Interface for Analysis of BioSignals Submitting author: @hooman650 Handling editor: @Kevin-Mattheus-Moerman (Active) Reviewers: @marianux, @fernandoandreotti, @bzenger Similarity score: 0.8192

eddy: Extracting Protoplanetary Disk Dynamics with Python Submitting author: @richteague Handling editor: @arfon (Active) Reviewers: @kevin-flaherty Similarity score: 0.8109

Hytool: an open source matlab toolbox for the interpretation of hydraulic tests using analytical solutions Submitting author: @philipperenard Handling editor: @kyleniemeyer (Active) Reviewers: @pboesu Similarity score: 0.8060

uDALES: large-eddy-simulation software for urban flow, dispersion, and microclimate modelling Submitting author: @tomgrylls Handling editor: @Kevin-Mattheus-Moerman (Active) Reviewers: @wimvanderbauwhede, @p-costa, @ashwinvis Similarity score: 0.8059

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

kthyng commented 5 months ago

@rampatels I'm sorry for the confusion. In the previous submission pre-review issue for this package, I was not asking you to justify reviewing this submission despite its very small number of lines of code. I was trying to check to make sure I wasn't missing something because it is unusually small. To estimate the number of lines of code, I am looking in this case at the line

MATLAB                          11            157            387            424

I have now had the chance to look at the details and I see that, yes, it is indeed quite small. I see that you have added a matlab file to the tutorials since your previous submission, but this does not "count" as additional content and I will defer to the previous submission's count in this case, which was:

MATLAB                           9             64            209            197

This is under the number of lines of code for desk reject (<300 LOC). I'm sorry, this is just too small of an effort to be published as a paper through JOSS. Please note that there are other ways to publish your code; check here for more info: https://joss.readthedocs.io/en/latest/submitting.html#other-venues-for-reviewing-and-publishing-software-packages

kthyng commented 5 months ago

@editorialbot reject

editorialbot commented 5 months ago

Paper rejected.