openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: Aquatracker: Data Visualization and Analysis for Acoustic Telemetry #635

Closed whedon closed 6 years ago

whedon commented 6 years ago

Submitting author: @reefpicker (Jose) Repository: https://github.com/reefpicker/AquaTracker Version: 2.41 Editor: Pending Reviewer: Pending

Author instructions

Thanks for submitting your paper to JOSS @reefpicker. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@reefpicker if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 6 years ago

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks. @karthik it looks like you're currently assigned as the editor for this paper :tada:

For a list of things I can do to help you, just type:

@whedon commands
whedon commented 6 years ago
Attempting PDF compilation. Reticulating splines etc...
whedon commented 6 years ago

PDF failed to compile for issue #635 with the following error:

Can't find any papers to compile :-(

arfon commented 6 years ago

👋 @karthik - the submitting author suggested you as the handling editor.

arfon commented 6 years ago

👋@reefpicker - please take another look at our submission requirements. This repository appears to be missing:

arfon commented 6 years ago

@whedon commands

whedon commented 6 years ago

Here are some things you can ask me to do:

# List all of Whedon's capabilities
@whedon commands

# Assign a GitHub user as the reviewer of this submission
@whedon assign @username as reviewer

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Change editorial assignment
@whedon assign @username as editor

# Set the software archive DOI at the top of the issue e.g.
@whedon set 10.0000/zenodo.00000 as archive

# Open the review issue
@whedon start review

🚧 🚧 🚧 Experimental Whedon features 🚧 🚧 🚧

# Compile the paper
@whedon generate pdf
karthik commented 6 years ago

@arfon Thanks, on it.

karthik commented 6 years ago

@AquaTracker Thanks for the submission. Your software has no README file describing what the software does, how one might use it, or anything other information about installation requirements. There is a paper.bib.txt but no paper. Hidden inside https://raw.githubusercontent.com/reefpicker/AquaTracker/master/summary.txt is a note that this is Visual Basic software. I don't use it myself, so can you suggest reviewers who are able to judge your work?

reefpicker commented 6 years ago

Karthik,

Sorry, I have been a bit busy with work. Yes, I understand what it is missing and was planning out on adding the readme.

I believe anyone with C# or .NET skills could review the software source code. The software itself is available for download as an exe file at the NOAA website also so if you don't have the VB IDE/compiler, you could in theory review the materials submitted. It is very likely that folks who list having .NET and C# knowledge also have VB6 sitting around somewhere.

There is a spreadsheet I got from whedon (I think it was bot generated). I can pick names from there and submit them to you. How many should I select?

Thanks

On Mon, Mar 19, 2018 at 2:49 PM, Karthik Ram notifications@github.com wrote:

@aquatracker Thanks for the submission. Your software has no README file describing what the software does, how one might use it, or anything other information about installation requirements. There is a paper.bib.txt but no paper. Hidden inside https://raw.githubusercontent. com/reefpicker/AquaTracker/master/summary.txt is a note that this is Visual Basic software. I don't use it myself, so can you suggest reviewers who are able to judge your work?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/635#issuecomment-374346870, or mute the thread https://github.com/notifications/unsubscribe-auth/ARNVBOryq15kBTNJVP34-HuHD0cibEd4ks5tgAvIgaJpZM4SvKHZ .

karthik commented 6 years ago

Hi @reefpicker Yes please suggest two to three names from that list and we can go from there.

karthik commented 6 years ago

@reefpicker A quick reminder for reviewer names.

reefpicker commented 6 years ago

@karthik https://github.com/karthik

Reviewers email addresses from that list:

claudio.benghi@northmbria.ac.uk michael@scivision.co

Thanks!

On Mon, Apr 16, 2018 at 12:34 PM, Karthik Ram notifications@github.com wrote:

@reefpicker https://github.com/reefpicker A quick reminder for reviewer names.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/635#issuecomment-381686877, or mute the thread https://github.com/notifications/unsubscribe-auth/ARNVBAsO_J31l15-3ih89NOyaonC7VWKks5tpNY9gaJpZM4SvKHZ .

karthik commented 6 years ago

@reefpicker I realize this submission is out of scope for me to serve as an editor. I'm not familiar with evaluating Visual Basic code or finding appropriate editors for it. So I'm going to excuse myself as an editor for this one and hand it back to @arfon

arfon commented 6 years ago

@CBenghi @Scivision - would you be willing to review this submission for JOSS?

CBenghi commented 6 years ago

Hello @arfon, I'll have a chat with the author to see what are the technical requirements. I don't think I have the tool-set at the moment, but if i can get it, I will happily review.

reefpicker commented 6 years ago

@whedon commands

On Thu, Apr 26, 2018 at 11:43 AM, Claudio Benghi notifications@github.com wrote:

Hello @arfon https://github.com/arfon, I'll have a chat with the author to see what are the technical requirements. I don't think I have the tool-set at the moment, but if i can get it, I will happily review.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/635#issuecomment-384709680, or mute the thread https://github.com/notifications/unsubscribe-auth/ARNVBLOQWRDNr8o5AwrvraU28ti6tGL0ks5tsfkZgaJpZM4SvKHZ .

whedon commented 6 years ago

Here are some things you can ask me to do:

# List all of Whedon's capabilities
@whedon commands

# Assign a GitHub user as the sole reviewer of this submission
@whedon assign @username as reviewer

# Add a GitHub user to the reviewers of this submission
@whedon add @username as reviewer

# Remove a GitHub user from the reviewers of this submission
@whedon remove @username as reviewer

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Change editorial assignment
@whedon assign @username as editor

# Set the software archive DOI at the top of the issue e.g.
@whedon set 10.0000/zenodo.00000 as archive

# Open the review issue
@whedon start review

🚧 🚧 🚧 Experimental Whedon features 🚧 🚧 🚧

# Compile the paper
@whedon generate pdf
reefpicker commented 6 years ago

@whedon list reviewers

On Sat, Apr 28, 2018 at 11:45 PM, whedon notifications@github.com wrote:

Here are some things you can ask me to do:

List all of Whedon's capabilities

@whedon commands

Assign a GitHub user as the sole reviewer of this submission

@whedon assign @username as reviewer

Add a GitHub user to the reviewers of this submission

@whedon add @username as reviewer

Remove a GitHub user from the reviewers of this submission

@whedon remove @username as reviewer

List of editor GitHub usernames

@whedon list editors

List of reviewers together with programming language preferences and domain expertise

@whedon list reviewers

Change editorial assignment

@whedon assign @username as editor

Set the software archive DOI at the top of the issue e.g.

@whedon set 10.0000/zenodo.00000 as archive

Open the review issue

@whedon start review 🚧 🚧 🚧 Experimental Whedon features 🚧 🚧 🚧

Compile the paper

@whedon generate pdf

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/635#issuecomment-385225525, or mute the thread https://github.com/notifications/unsubscribe-auth/ARNVBH7oiZIPIZ7mLI7lEhSxH1axvGnlks5ttUVigaJpZM4SvKHZ .

whedon commented 6 years ago

Here's the current list of reviewers: https://bit.ly/joss-reviewers

arfon commented 6 years ago

I don't think I have the tool-set at the moment, but if i can get it, I will happily review.

@CBenghi - I think we'd like to take you up on this offer if you're still willing?

@reefpicker - are there any other potential reviewers in the list above or people you'd recommend elsewhere on GitHub?

CBenghi commented 6 years ago

@arfon there's been a bit of back an forth with @reefpicker on a There was code missing in repository that prevented me from trying to convert/open in my development environment. This has been addressed a few days ago, but I've not been able to look into the updated version yet. I should be able to determine in a couple of days.

arfon commented 6 years ago

I should be able to determine in a couple of days.

OK thanks @CBenghi - please let me know here if you think you're able to review this.

CBenghi commented 6 years ago

@arfon, more files missing from the initial repository.

I doubt you'll find something else using vb6 in the editor's list. It's a 15 years old technology now discontinued by Microsoft. My plan is to try and get the code to working in a current development environment before review.

I'll keep working with @reefpicker and keep you informed if/when we manage.

reefpicker commented 6 years ago

I will like to officially retract this submission.

Thanks!

On Tue, May 15, 2018 at 5:12 AM Claudio Benghi notifications@github.com wrote:

@arfon https://github.com/arfon, more files missing from the initial repository.

I doubt you'll find something else using vb6 in the editor's list. It's a 15 years old technology now discontinued by Microsoft. My plan is to try and get the code to working in a current development environment before review.

I'll keep working @reefpicker https://github.com/reefpicker and keep you informed if/when we manage.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/635#issuecomment-389116029, or mute the thread https://github.com/notifications/unsubscribe-auth/ARNVBGIcRyjD38jO8JrVNGL89WXB2QGuks5tyqopgaJpZM4SvKHZ .

arfon commented 6 years ago

OK thanks for letting us know @reefpicker!