[REVIEW]: QSOnic: fast quasar continuum fitting

editorialbot commented 8 months ago

Submitting author: !--author-handle-->@p-slash@ivastar<!--end-editor-- Reviewers: @gcalderone, @corentinravoux Archive: 10.5281/zenodo.11105006

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/e12beb52b1db87776c325993c713a822"><img src="https://joss.theoj.org/papers/e12beb52b1db87776c325993c713a822/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/e12beb52b1db87776c325993c713a822/status.svg)](https://joss.theoj.org/papers/e12beb52b1db87776c325993c713a822)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@gcalderone & @corentinravoux, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @ivastar know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @corentinravoux

📝 Checklist for @gcalderone

ivastar commented 6 months ago

@editorialbot generate pdf

editorialbot commented 6 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

ivastar commented 6 months ago

@editorialbot check references

editorialbot commented 6 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.3847/1538-4357/abb085 is OK
- 10.1103/PhysRevD.96.023522 is OK
- 10.1088/1475-7516/2015/02/045 is OK
- 10.1093/mnras/stab3201 is OK
- 10.1093/mnras/stae171 is OK
- 10.1093/mnras/stad3008 is OK
- 10.48550/arXiv.1611.00036 is OK
- 10.1093/mnras/stx1870 is OK
- 10.1086/427976 is OK

MISSING DOIs

- None

INVALID DOIs

- None

ivastar commented 6 months ago

@editorialbot recommend-accept

editorialbot commented 6 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 6 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.3847/1538-4357/abb085 is OK
- 10.1103/PhysRevD.96.023522 is OK
- 10.1088/1475-7516/2015/02/045 is OK
- 10.1093/mnras/stab3201 is OK
- 10.1093/mnras/stae171 is OK
- 10.1093/mnras/stad3008 is OK
- 10.48550/arXiv.1611.00036 is OK
- 10.1093/mnras/stx1870 is OK
- 10.1086/427976 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 6 months ago

:wave: @openjournals/aass-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5301, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

dfm commented 6 months ago

I've opened a small PR and I can proceed with publication after that has been merged. Thanks!

p-slash commented 6 months ago

Merged. Thanks for fixing the references!

dfm commented 6 months ago

@editorialbot generate pdf

editorialbot commented 6 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

p-slash commented 6 months ago

@dfm I found another error in the references. It is the first reference.

p-slash commented 6 months ago

@editorialbot generate pdf

editorialbot commented 6 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

dfm commented 6 months ago

@editorialbot recommend-accept

editorialbot commented 6 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 6 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.3847/1538-4357/abb085 is OK
- 10.1103/PhysRevD.96.023522 is OK
- 10.1088/1475-7516/2015/02/045 is OK
- 10.1093/mnras/stab3201 is OK
- 10.1093/mnras/stae171 is OK
- 10.1093/mnras/stad3008 is OK
- 10.48550/arXiv.1611.00036 is OK
- 10.1093/mnras/stx1870 is OK
- 10.1086/427976 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 6 months ago

:wave: @openjournals/aass-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5324, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

dfm commented 6 months ago

@editorialbot accept

editorialbot commented 6 months ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 6 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Karaçaylı given-names: Naim Göksel orcid: "https://orcid.org/0000-0001-7336-8912" doi: 10.5281/zenodo.11105006 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Karaçaylı given-names: Naim Göksel orcid: "https://orcid.org/0000-0001-7336-8912" date-published: 2024-05-08 doi: 10.21105/joss.06373 issn: 2475-9066 issue: 97 journal: Journal of Open Source Software publisher: name: Open Journals start: 6373 title: "QSOnic: fast quasar continuum fitting" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06373" volume: 9 title: "QSOnic: fast quasar continuum fitting" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 6 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 6 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5325
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06373
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

dfm commented 6 months ago

Many thanks to @gcalderone and @corentinravoux for reviewing and to @ivastar for editing! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you!!

@p-slash — Your paper is now accepted and published in JOSS! :zap::rocket::boom:

editorialbot commented 6 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06373/status.svg)](https://doi.org/10.21105/joss.06373)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06373">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06373/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06373/status.svg
   :target: https://doi.org/10.21105/joss.06373

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

openjournals / joss-reviews