openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: gollum: An intuitive programmatic and visual interface for precomputed synthetic spectral model grids #6381

Closed editorialbot closed 7 months ago

editorialbot commented 8 months ago

Submitting author: !--author-handle-->@Sujay-Shankar<!--end-author-handle-- (Sujay Shankar) Repository: https://github.com/BrownDwarf/gollum Branch with paper.md (empty if default branch): Version: v0.3.0 Editor: !--editor-->@warrickball<!--end-editor-- Reviewers: @rhdtownsend, @DanielAndreasen Managing EiC: Dan Foreman-Mackey

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/8d3f0bad9a8df509972891c15daf21b1"><img src="https://joss.theoj.org/papers/8d3f0bad9a8df509972891c15daf21b1/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/8d3f0bad9a8df509972891c15daf21b1/status.svg)](https://joss.theoj.org/papers/8d3f0bad9a8df509972891c15daf21b1)

Author instructions

Thanks for submitting your paper to JOSS @SujayShankar2001. Currently, there isn't a JOSS editor assigned to your paper.

@SujayShankar2001 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 8 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 8 months ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.05 s (725.9 files/s, 154263.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          14            588            714           2865
TeX                              1             17              0            259
Jupyter Notebook                10              0           2933            225
YAML                             4              5              2            133
reStructuredText                 5             70             41             84
Markdown                         2             22              0             63
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            38            714           3698           3664
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 8 months ago

Wordcount for paper.md is 710

editorialbot commented 8 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/s41586-020-2649-2 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.3847/1538-4357/ac7c74 is OK
- 10.5281/zenodo.10016569 is OK
- 10.5281/zenodo.6539458 is OK
- 10.3847/1538-4357/aca0a2 is OK
- 10.1088/0004-637X/812/2/128 is OK
- 10.1051/0004-6361/201219058 is OK
- 10.3847/1538-4357/ac141d is OK
- 10.48550/arXiv.2402.00758 is OK
- 10.3847/1538-4357/acc8cb is OK
- 10.48550/arXiv.2402.00756 is OK

MISSING DOIs

- None

INVALID DOIs

- None
dfm commented 8 months ago

@SujayShankar2001 — Thanks for your submission! All the suitable JOSS editors are currently working at capacity so I'm going to "waitlist" this review until an editor with the relevant expertise is available to take it on. Thanks for your patience!

editorialbot commented 8 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 8 months ago

Five most similar historical JOSS papers:

Astronomical échelle spectroscopy data analysis with muler Submitting author: @gully Handling editor: @xuanxu (Active) Reviewers: @bmorris3, @wtgee Similarity score: 0.8338

The Dusty Evolved Star Kit (DESK): A Python package for fitting the Spectral Energy Distribution of Evolved Stars Submitting author: @s-goldman Handling editor: @arfon (Active) Reviewers: @Deech08, @TomGoffrey Similarity score: 0.8233

PyAutoGalaxy: Open-Source Multiwavelength Galaxy Structure & Morphology Submitting author: @Jammy2211 Handling editor: @christinahedges (Retired) Reviewers: @alexandergagliano, @sloneil Similarity score: 0.8229

Gala: A Python package for galactic dynamics Submitting author: @adrn Handling editor: @arfon (Active) Reviewers: @crawfordsm Similarity score: 0.8211

FASMA 2.0: A Python package for stellar parameters and chemical abundances Submitting author: @MariaTsantaki Handling editor: @xuanxu (Active) Reviewers: @warrickball, @ipelupessy Similarity score: 0.8204

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

warrickball commented 7 months ago

@editorialbot assign me as editor

editorialbot commented 7 months ago

Assigned! @warrickball is now the editor

warrickball commented 7 months ago

@editorialbot add @rhdtownsend as reviewer

editorialbot commented 7 months ago

@rhdtownsend added to the reviewers list!

warrickball commented 7 months ago

@editorialbot add @DanielAndreasen as reviewer

editorialbot commented 7 months ago

@DanielAndreasen added to the reviewers list!

warrickball commented 7 months ago

Hi @SujayShankar2001, sorry for the long wait. The editors have all collectively been very busy but, as you can see, I picked this up a few days ago and our reviewers, @rhdtownsend and @DanielAndreasen, have kindly agreed to review very quickly.

I'll start the main review in a moment after I've double checked the submission metadata.

warrickball commented 7 months ago

Is the author's GitHub username @Sujay-Shankar or @SujayShankar2001? I suspect the former but the metadata has been populated with the latter. @Sujay-Shankar, could you let us know which is correct? I think this is generated from your JOSS profile, so you might want to check that you've put the correct username there.

Sujay-Shankar commented 7 months ago

Hi @warrickball , thanks for picking up our paper for review! Sorry about the name mismatch, I recently changed my GitHub username. Sujay-Shankar is the new and current one, SujayShankar2001 is the old one. I just went into my JOSS profile and updated the username, thanks for reminding me!

warrickball commented 7 months ago

No problem! It's easy to fix. I just wanted to check before doing so. I'll start the review proper in a moment.

warrickball commented 7 months ago

@editorialbot start review

editorialbot commented 7 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6601.