[REVIEW]: gcamfaostat: An R package to prepare, process, and synthesize FAOSTAT data for global agroeconomic and multisector dynamic modeling

editorialbot commented 8 months ago

Submitting author: !--author-handle-->@realxinzhao@hugoledoux<!--end-editor-- Reviewers: @klau506, @HenriKajasilta Archive: 10.5281/zenodo.10967067

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/bf4762e8bef702f36b800e0cb4d478a8"><img src="https://joss.theoj.org/papers/bf4762e8bef702f36b800e0cb4d478a8/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/bf4762e8bef702f36b800e0cb4d478a8/status.svg)](https://joss.theoj.org/papers/bf4762e8bef702f36b800e0cb4d478a8)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@klau506 & @HenriKajasilta, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @hugoledoux know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @klau506

📝 Checklist for @HenriKajasilta

hugoledoux commented 6 months ago

@editorialbot generate pdf

editorialbot commented 6 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

hugoledoux commented 6 months ago

@editorialbot set 10.5281/zenodo.10967067 as archive

editorialbot commented 6 months ago

Done! archive is now 10.5281/zenodo.10967067

hugoledoux commented 6 months ago

@editorialbot set v1.0.0 as version

editorialbot commented 6 months ago

Done! version is now v1.0.0

hugoledoux commented 6 months ago

@editorialbot recommend-accept

editorialbot commented 6 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 6 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.8260225 is OK
- 10.1088/1748-9326/ac5766 is OK
- 10.1038/s43016-022-00464-4 is OK
- 10.1017/9781009157926.022 is OK
- 10.1038/s41558-023-01661-0 is OK
- 10.1016/j.oneear.2023.08.003 is OK
- 10.1029/2022EF003063 is OK
- 10.1371/journal.pone.0291577 is OK
- 10.1088/1748-9326/ac2965 is OK
- 10.1016/j.scitotenv.2021.146238 is OK
- 10.1142/s2010007820500049 is OK
- 10.1021/acs.est.9b03554 is OK
- 10.5194/gmd-15-429-2022 is OK
- 10.21642/JGEA.070101AF is OK
- 10.1016/j.eap.2021.07.007 is OK
- 10.1111/agec.12086 is OK
- 10.21105/joss.00550 is OK
- 10.5281/zenodo.8010145 is OK
- 10.5194/gmd-12-677-2019 is OK
- 10.5334/jors.232 is OK
- 10.5334/jors.266 is OK
- 10.5334/jors.208 is OK
- 10.1038/s41467-024-46575-3 is OK
- 10.1038/sdata.2016.18 is OK

MISSING DOIs

- No DOI given, and none found for title: FAOSTAT Database
- No DOI given, and none found for title: Core Model Proposal# 360: GCAM agriculture and lan...

INVALID DOIs

- None

editorialbot commented 6 months ago

:wave: @openjournals/ese-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5251, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

kthyng commented 6 months ago

Hi! I'll take over now as Track Associate Editor in Chief to do some final submission editing checks. After these checks are complete, I will publish your submission!

[x] Check that version was updated and make sure the version from JOSS matches github and Zenodo.
[x] Check that software archive exists, has been input to JOSS, and title and author list match JOSS paper (or purposefully do not).
[x] Check paper.

kthyng commented 6 months ago

Paper comments:

page 3: paragraph before last paragraph — looks like some of the markdown is off like is one of these supposed to be a link but there is a space so it isn't coming through correctly? Including the parentheses in the links looks strange too.
Also please check the capitalization in your references. You can preserve capitalization by placing {} around characters/words in your .bib file.

realxinzhao commented 6 months ago

@editorialbot generate pdf

editorialbot commented 6 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

realxinzhao commented 6 months ago

Thank you so much, @kthyng!!

The formatting in that paragraph is now fixed.
Two places in .bib file is also fixed (with better capitalizations).

kthyng commented 6 months ago

@realxinzhao I didn't look through all references but at least looks like "R" isn't capitalized yet.

realxinzhao commented 6 months ago

@editorialbot generate pdf

editorialbot commented 6 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

realxinzhao commented 6 months ago

@kthyng Thank you so much!

These are fixed now in the references. Sorry about the inconvenience (also good to learn the tricks).

kthyng commented 6 months ago

Ok good @realxinzhao! That R is capitalized, though I see a number of other proper nouns in references that should still be capitalized.

realxinzhao commented 6 months ago

@editorialbot generate pdf

editorialbot commented 6 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

realxinzhao commented 6 months ago

Oops... yes! @kthyng I think they are fixed now (the titles all match the ones that appear in their journal articles now). Thank you!

kthyng commented 6 months ago

Ok then we are ready to go!

kthyng commented 6 months ago

@editorialbot accept

editorialbot commented 6 months ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 6 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Zhao given-names: Xin orcid: "https://orcid.org/0000-0002-1801-4393" - family-names: Chepeliev given-names: Maksym orcid: "https://orcid.org/0000-0001-8585-2314" - family-names: Patel given-names: Pralit orcid: "https://orcid.org/0000-0003-3992-1061" - family-names: Wise given-names: Marshall orcid: "https://orcid.org/0000-0002-2718-0051" - family-names: Calvin given-names: Katherine orcid: "https://orcid.org/0000-0003-2191-4189" - family-names: Narayan given-names: Kanishka orcid: "https://orcid.org/0000-0001-8483-6216" - family-names: Vernon given-names: Chris orcid: "https://orcid.org/0000-0002-3406-6214" doi: 10.5281/zenodo.10967067 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Zhao given-names: Xin orcid: "https://orcid.org/0000-0002-1801-4393" - family-names: Chepeliev given-names: Maksym orcid: "https://orcid.org/0000-0001-8585-2314" - family-names: Patel given-names: Pralit orcid: "https://orcid.org/0000-0003-3992-1061" - family-names: Wise given-names: Marshall orcid: "https://orcid.org/0000-0002-2718-0051" - family-names: Calvin given-names: Katherine orcid: "https://orcid.org/0000-0003-2191-4189" - family-names: Narayan given-names: Kanishka orcid: "https://orcid.org/0000-0001-8483-6216" - family-names: Vernon given-names: Chris orcid: "https://orcid.org/0000-0002-3406-6214" date-published: 2024-04-22 doi: 10.21105/joss.06388 issn: 2475-9066 issue: 96 journal: Journal of Open Source Software publisher: name: Open Journals start: 6388 title: "gcamfaostat: An R package to prepare, process, and synthesize FAOSTAT data for global agroeconomic and multisector dynamic modeling" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06388" volume: 9 title: "gcamfaostat: An R package to prepare, process, and synthesize FAOSTAT data for global agroeconomic and multisector dynamic modeling" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 6 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 6 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5263
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06388
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

kthyng commented 6 months ago

Congrats on your new publication @realxinzhao! Many thanks to editor @hugoledoux and reviewers @klau506 and @HenriKajasilta for your time, hard work, and expertise!!

editorialbot commented 6 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06388/status.svg)](https://doi.org/10.21105/joss.06388)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06388">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06388/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06388/status.svg
   :target: https://doi.org/10.21105/joss.06388

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

kthyng commented 6 months ago

@realxinzhao If you'd like to sign up as a reviewer, you can do so here: https://reviewers.joss.theoj.org/.

realxinzhao commented 6 months ago

Congrats on your new publication @realxinzhao! Many thanks to editor @hugoledoux and reviewers @klau506 and @HenriKajasilta for your time, hard work, and expertise!!

Thank you all so much, All! This experience of leading a software publication as an economist/human-earth system modeler has been incredibly rewarding. I've learned a tremendous amount from the process, and I deeply appreciate the time and effort you've dedicated to enhancing both the software and the paper.

Best regards, Xin

openjournals / joss-reviews