[REVIEW]: XRTpy : A Hinode X-Ray Telescope Python Package

editorialbot commented 7 months ago

Submitting author: !--author-handle-->@joyvelasquez@dfm<!--end-editor-- Reviewers: @dpshelio, @Cadair Archive: 10.5281/zenodo.13157913

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/e8ae2a0f5cb2140907456c60f2c694ac"><img src="https://joss.theoj.org/papers/e8ae2a0f5cb2140907456c60f2c694ac/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/e8ae2a0f5cb2140907456c60f2c694ac/status.svg)](https://joss.theoj.org/papers/e8ae2a0f5cb2140907456c60f2c694ac)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@dpshelio & @Cadair, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @dfm know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @Cadair

📝 Checklist for @dpshelio

joyvelasquez commented 1 month ago

Hi @dfm , I missed it too! I've made the updated. May take a few minutes to run test. Change made to XRTpy's main branch. Would need me to do anything else after this?

dfm commented 1 month ago

@editorialbot recommend-accept

editorialbot commented 1 month ago

Attempting dry run of processing paper acceptance...

editorialbot commented 1 month ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1146/annurev.astro.46.060407.145222 is OK
- 10.21105/joss.02801 is OK
- 10.1051/aas:1997368 is OK
- 10.1086/191698 is OK
- 10.1007/s11207-007-0182-1 is OK
- 10.1007/s11214-007-9173-7 is OK
- 10.1088/0004-637X/800/1/54 is OK
- 10.1007/s11207-007-9014-6 is OK
- 10.1086/337949 is OK
- 10.1007/s11207-010-9685-2 is OK
- 10.1007/s11207-013-0368-7 is OK
- 10.1088/0004-637X/755/1/33 is OK
- 10.1051/0004-6361/201424110 is OK
- 10.3847/1538-4357/ab4f7a is OK
- 10.21105/joss.04914 is OK

MISSING DOIs

- No DOI given, and none found for title: CHIANTI - An Atomic Database for Emission Lines. P...
- No DOI given, and none found for title: The absolute coronal abundances of sulfur, calcium...

INVALID DOIs

- None

editorialbot commented 1 month ago

:wave: @openjournals/aass-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5749, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

dfm commented 1 month ago

@editorialbot accept

editorialbot commented 1 month ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 1 month ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Velasquez given-names: Joy orcid: "https://orcid.org/0009-0005-4804-0946" - family-names: Murphy given-names: Nicholas A. orcid: "https://orcid.org/0000-0001-6628-8033" - family-names: Reeves given-names: Katharine K. orcid: "https://orcid.org/0000-0002-6903-6832" - family-names: Slavin given-names: Jonathan orcid: "https://orcid.org/0000-0002-7597-6935" - family-names: Weber given-names: Mark orcid: "https://orcid.org/0000-0001-7098-7064" - family-names: Barnes given-names: Will T. orcid: "https://orcid.org/0000-0001-9642-6089" contact: - family-names: Murphy given-names: Nicholas A. orcid: "https://orcid.org/0000-0001-6628-8033" - family-names: Slavin given-names: Jonathan orcid: "https://orcid.org/0000-0002-7597-6935" - family-names: Weber given-names: Mark orcid: "https://orcid.org/0000-0001-7098-7064" doi: 10.5281/zenodo.13157913 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Velasquez given-names: Joy orcid: "https://orcid.org/0009-0005-4804-0946" - family-names: Murphy given-names: Nicholas A. orcid: "https://orcid.org/0000-0001-6628-8033" - family-names: Reeves given-names: Katharine K. orcid: "https://orcid.org/0000-0002-6903-6832" - family-names: Slavin given-names: Jonathan orcid: "https://orcid.org/0000-0002-7597-6935" - family-names: Weber given-names: Mark orcid: "https://orcid.org/0000-0001-7098-7064" - family-names: Barnes given-names: Will T. orcid: "https://orcid.org/0000-0001-9642-6089" date-published: 2024-08-09 doi: 10.21105/joss.06396 issn: 2475-9066 issue: 100 journal: Journal of Open Source Software publisher: name: Open Journals start: 6396 title: "XRTpy: A Hinode-X-Ray Telescope Python Package" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06396" volume: 9 title: "XRTpy: A Hinode-X-Ray Telescope Python Package" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 1 month ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 1 month ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5750
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06396
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

dfm commented 1 month ago

@dpshelio, @Cadair — Many thanks for your reviews here! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you!!

@joyvelasquez — Your paper is now accepted and published in JOSS! :zap::rocket::boom:

Note: It looks like the PDF isn't rendering (at least for me) at the DOI. This happens sometimes because of caching issues with our servers. Let's check back tomorrow if it doesn't resolve automatically.

editorialbot commented 1 month ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06396/status.svg)](https://doi.org/10.21105/joss.06396)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06396">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06396/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06396/status.svg
   :target: https://doi.org/10.21105/joss.06396

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

Cadair commented 1 month ago

Thanks @dfm always happy to review JOSS papers :)

Cadair commented 1 month ago

@joyvelasquez Thanks for writing XRTPy! Don't forget to add XRTPy to the list of sunpy affiliated packages :)

openjournals / joss-reviews