openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
715 stars 38 forks source link

[PRE REVIEW]: Upscale and map scattered points onto OpenGeoSys GINA and Gmsh meshes formats: a Tkinter Graphical User Interface Python code #6404

Closed editorialbot closed 7 months ago

editorialbot commented 7 months ago

Submitting author: !--author-handle-->@benitez9rh<!--end-author-handle-- (Goncalo Cunha) Repository: https://github.com/benitez9rh/tkinterGmshOGS-GINA_UpscaleMapping Branch with paper.md (empty if default branch): main Version: v1.0 Editor: Pending Reviewers: Pending Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/4f0c06cf284545b5ec08f102f9349508"><img src="https://joss.theoj.org/papers/4f0c06cf284545b5ec08f102f9349508/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/4f0c06cf284545b5ec08f102f9349508/status.svg)](https://joss.theoj.org/papers/4f0c06cf284545b5ec08f102f9349508)

Author instructions

Thanks for submitting your paper to JOSS @benitez9rh. Currently, there isn't a JOSS editor assigned to your paper.

@benitez9rh if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 7 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 7 months ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.03 s (204.8 files/s, 44370.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                           1             49            166            526
TeX                              1             14              0            271
Markdown                         2             63              0            139
GLSL                             1              8              0             41
YAML                             1              1              4             18
-------------------------------------------------------------------------------
SUM:                             6            135            170            995
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 7 months ago

Wordcount for paper.md is 490

editorialbot commented 7 months ago

:warning: An error happened when generating the pdf. Author (Gonçalo Benitez Cunha) is missing affiliation.

editorialbot commented 7 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1038/s41586-020-2649-2 is OK
- 10.1007/978-3-319-29224-3 is OK
- 10.5281/zenodo.7092676 is OK
- 10.1007/s12665-015-4769-9 is OK

MISSING DOIs

- 10.21105/joss.01450 may be a valid DOI for title: "PyVista: 3D plotting and mesh analysis through a streamlined interface for the Visualization Toolkit (VTK)"
- 10.25080/majora-92bf1922-00a may be a valid DOI for title: "Data Structures for Statistical Computing in Python"
- 10.1109/mcse.2007.55 may be a valid DOI for title: "Matplotlib: A 2D graphics environment"

INVALID DOIs

- https://doi.org/10.1038/s41592-019-0686-2 is INVALID because of 'https://doi.org/' prefix
- 10.1007/s12665-012-1546 is INVALID
danielskatz commented 7 months ago

👋 @benitez9rh - note that your paper does not compile. Please follow the example paper and note that you can click on the error above to find out more about it (though in this case, it is shown above: Author (Gonçalo Benitez Cunha) is missing affiliation). In addition, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf after making changes to the .md file or when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

In addition, due to the relatively small amount of code, the editors will now discuss if it meets the substantial scholarly effort criterion for review by JOSS. They will also discuss if this is research software as defined by JOSS. You should hear back in a week or so.

danielskatz commented 7 months ago

@editorialbot query scope

editorialbot commented 7 months ago

Submission flagged for editorial review.

g9cunha commented 7 months ago

@editorialbot commands

editorialbot commented 7 months ago

Hello @benitez9rh, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers
g9cunha commented 7 months ago

@editorialbot check references

editorialbot commented 7 months ago

Checking the BibTeX entries failed with the following error:

Failed to parse BibTeX on value "doi" (NAME) [#<BibTeX::Bibliography data=[9]>, "@", #<BibTeX::Entry >, {:title=>["\"Matplotlib: A 2D graphics environment\""], :author=>["Hunter, John D"], :journal=>["Computing in science \\& engineering"], :volume=>["9"], :number=>["3"], :pages=>["90"], :year=>["2007"], :publisher=>["IEEE Computer Society"]}]
g9cunha commented 7 months ago

@editorialbot check references

editorialbot commented 7 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.01450 is OK
- 10.25080/majora-92bf1922-00a is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1109/mcse.2007.55 is OK
- 10.1007/s12665-012-1546-x is OK
- 10.1007/978-3-319-29224-3 is OK
- 10.5281/zenodo.7092676 is OK
- 10.1007/s12665-015-4769-9 is OK

MISSING DOIs

- None

INVALID DOIs

- None
g9cunha commented 7 months ago

@editorialbot generate pdf

editorialbot commented 7 months ago

:warning: An error happened when generating the pdf. Author (Gonçalo Benitez Cunha) is missing affiliation.

g9cunha commented 7 months ago

@editorialbot generate pdf

editorialbot commented 7 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

danielskatz commented 7 months ago

@benitez9rh - thanks for your updates

danielskatz commented 7 months ago

👋 @benitez9rh - I'm sorry to say that after discussion amongst the JOSS editors, we have decided that this submission does not meet the substantial scholarly effort criterion for review by JOSS, in part due to the amount of code and in part, because it appears to be mainly wrapping existing software. Please see https://joss.readthedocs.io/en/latest/submitting.html#other-venues-for-reviewing-and-publishing-software-packages for other suggestions for how you might receive credit for your work.

danielskatz commented 7 months ago

@editorialbot reject

editorialbot commented 7 months ago

Paper rejected.

g9cunha commented 7 months ago

@danielskatz The software is new, i.e. I developed it myself to make it easier to include a property in OGS (that one existing yes) models. Regardless, thank you all for taking the time. I truly appreciate your efforts. Best wishes.