openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
696 stars 36 forks source link

[PRE REVIEW]: nnR: A package to perform algebraic operations on neural networks #6407

Closed editorialbot closed 4 months ago

editorialbot commented 4 months ago

Submitting author: !--author-handle-->@2shakilrafi<!--end-author-handle-- (Shakil Rafi) Repository: https://github.com/2shakilrafi/nnR Branch with paper.md (empty if default branch): Version: 0.1.0-2 Editor: Pending Reviewers: Pending Managing EiC: Daniel S. Katz

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/a22df709c002b4d97ceed3e9c9075a7b"><img src="https://joss.theoj.org/papers/a22df709c002b4d97ceed3e9c9075a7b/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/a22df709c002b4d97ceed3e9c9075a7b/status.svg)](https://joss.theoj.org/papers/a22df709c002b4d97ceed3e9c9075a7b)

Author instructions

Thanks for submitting your paper to JOSS @2shakilrafi. Currently, there isn't a JOSS editor assigned to your paper.

@2shakilrafi if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 4 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 4 months ago
Software report:

github.com/AlDanial/cloc v 1.88  T=0.04 s (1222.4 files/s, 115501.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
R                               45            216            990           1211
TeX                              2            174              0           1156
Markdown                         3            150              0            624
Rmd                              1            110            285             65
YAML                             2              2              4             21
-------------------------------------------------------------------------------
SUM:                            53            652           1279           3077
-------------------------------------------------------------------------------

gitinspector failed to run statistical information for the repository
editorialbot commented 4 months ago

Wordcount for paper.md is 642

editorialbot commented 4 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

2shakilrafi commented 4 months ago

Robert Baker Francesco Paolo Lovergine Abinash Satapathy

danielskatz commented 4 months ago

@2shakilrafi - if you can provide their github usernames (but not tagged with @), please do

danielskatz commented 4 months ago

@2shakilrafi - also, because of the relatively small amount of code here and the relatively short commit history (in both the current repo as well as https://github.com/2shakilrafi/R-simulations/), I'm going to ask the JOSS editors to check this for scope, to see if it meets the substantial scholarly effort criterion for review by JOSS. You should hear back in a week or so.

danielskatz commented 4 months ago

@editorialbot query scope

editorialbot commented 4 months ago

Submission flagged for editorial review.

danielskatz commented 4 months ago

@editorialbot check references

editorialbot commented 4 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/s10444-022-09970-2 is OK
- 10.1007/s42985-021-00100-z is OK
- 10.1017/CBO9780511997044.004 is OK
- 10.1098/rspa.2019.0630 is OK
- 10.3934/dcdsb.2020320 is OK
- 10.1142/s0219493721500489 is OK
- 10.48550/arXiv.2110.08297 is OK
- 10.1090/S0273-0979-1992-00266-5 is OK
- 10.1017/CBO9780511543210 is OK
- 10.1007/s10959-008-0155-9 is OK
- 10.1214/20-EJP423 is OK
- 10.1142/S0219493721500489 is OK
- 10.1038/s41467-021-27838-9 is OK
- 10.1038/s42005-023-01334-6 is OK
- 10.1007/s42985-021-00089-5 is OK
- 10.1007/s10915-018-00903-0 is OK
- 10.1609/aaai.v35i8.16826 is OK
- 10.1109/CVPR.2017.195 is OK
- 10.1016/j.neunet.2018.08.019 is OK
- 10.1007/BF02478259 is OK
- 10.1007/BF02551274 is OK
- 10.1109/72.712178 is OK
- 10.48550/arXiv.1811.01122 is OK
- 10.1609/aaai.v35i8.16826 is OK

MISSING DOIs

- 10.1093/acprof:oso/9780190241148.003.0012 may be a valid DOI for title: Brownian Motion and Stochastic Calculus
- 10.1090/memo/1410 may be a valid DOI for title: A proof that artificial neural networks overcome the curse of dimensionality in the numerical approximation of Black-Scholes partial differential equations
- 10.1201/9781420035827-8 may be a valid DOI for title: Matrix Computations
- 10.18653/v1/p19-1355 may be a valid DOI for title: Energy and Policy Considerations for Deep Learning in NLP
- 10.1016/0893-6080(91)90009-t may be a valid DOI for title: Approximation capabilities of multilayer feedforward networks

INVALID DOIs

- https://doi.org/10.1016/j.exco.2021.100035 is INVALID because of 'https://doi.org/' prefix
danielskatz commented 4 months ago

@2shakilrafi - finally, you could work on the possibly missing DOIs that editorialbot suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @editorialbot check references to check again, and the command @editorialbot generate pdf when the references are right to make a new PDF. editorialbot commands need to be the first entry in a new comment.

2shakilrafi commented 4 months ago

fpl RobLBaker Abinashbunty

danielskatz commented 4 months ago

@2shakilrafi - for the future, if you can provide their github usernames (but not tagged with @), please do meant to not put the @ in front of their usernames so they didn't get notified about this until an editor decided to ask them.

Abinashbunty commented 4 months ago

@danielskatz I'm done with my latest review, so I'm available for this paper. Feel free to assign me as reviewer or I'll wait for editor as well. 🙂

danielskatz commented 4 months ago

Thanks @Abinashbunty - the editor should do the assigning

2shakilrafi commented 4 months ago

@2shakilrafi - for the future, if you can provide their github usernames (but not tagged with @), please do meant to not put the @ in front of their usernames so they didn't get notified about this until an editor decided to ask them.

Ooops my bad, sorry about that.

danielskatz commented 4 months ago

@2shakilrafi - I apologize for the delay in getting back to you, and I'm also sorry to say that after discussion amongst the JOSS editors, we have decided that this submission does not meet the substantial scholarly effort criterion for review by JOSS. Please see https://joss.readthedocs.io/en/latest/submitting.html#other-venues-for-reviewing-and-publishing-software-packages for other suggestions for how you might receive credit for your work.

Some comments from editors on the current version include

This was fairly close, and if you further develop the software (perhaps adding to it in some way, and adding more documentation), we would encourage you to submit again in a year or so, or when you think you've made more progress.

danielskatz commented 4 months ago

@editorialbot reject

editorialbot commented 4 months ago

Paper rejected.