[REVIEW]: xCDAT: A Python package for simple climate data analysis on structured grids

editorialbot commented 8 months ago

Submitting author: !--author-handle-->@tomvothecoder@arfon<!--end-editor-- Reviewers: @brian-rose, @mgrover1 Archive: 10.5281/zenodo.12522560

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/aeeaf960da55c95d4b0d6b690442578a"><img src="https://joss.theoj.org/papers/aeeaf960da55c95d4b0d6b690442578a/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/aeeaf960da55c95d4b0d6b690442578a/status.svg)](https://joss.theoj.org/papers/aeeaf960da55c95d4b0d6b690442578a)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@brian-rose & @mgrover1, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @arfon know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @mgrover1

📝 Checklist for @brian-rose

arfon commented 4 months ago

@editorialbot recommend-accept

editorialbot commented 4 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 4 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1029/2022MS003156 is OK
- 10.5194/gmd-10-4619-2017 is OK
- 10.5334/jors.148 is OK
- 10.5194/egusphere-2023-2720 is OK
- 10.1073/pnas.2209431119 is OK
- 10.1109/ICDMW.2009.64 is OK
- 10.1002/2014EO420002 is OK
- 10.5194/gmd-15-9031-2022 is OK
- 10.5281/zenodo.2586088 is OK
- 10.5281/zenodo.10038784 is OK
- 10.5281/zenodo.8339034 is OK
- 10.5281/zenodo.10236521 is OK
- 10.5281/zenodo.8356796 is OK
- 10.5281/zenodo.7348619 is OK

MISSING DOIs

- No DOI given, and none found for title: Dask: Library for dynamic task scheduling
- No DOI given, and none found for title: E3SM-Unified: A metapackage for a unified anaconda...

INVALID DOIs

- None

editorialbot commented 4 months ago

:wave: @openjournals/ese-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5552, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

arfon commented 4 months ago

@editorialbot accept

editorialbot commented 4 months ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 4 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Vo given-names: Tom orcid: "https://orcid.org/0000-0002-2461-0191" - family-names: Po-Chedley given-names: Stephen orcid: "https://orcid.org/0000-0002-0390-238X" - family-names: Boutte given-names: Jason orcid: "https://orcid.org/0009-0009-3996-3772" - family-names: Lee given-names: Jiwoo orcid: "https://orcid.org/0000-0002-0016-7199" - family-names: Zhang given-names: Chengzhu orcid: "https://orcid.org/0000-0002-9632-0716" doi: 10.5281/zenodo.12522560 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Vo given-names: Tom orcid: "https://orcid.org/0000-0002-2461-0191" - family-names: Po-Chedley given-names: Stephen orcid: "https://orcid.org/0000-0002-0390-238X" - family-names: Boutte given-names: Jason orcid: "https://orcid.org/0009-0009-3996-3772" - family-names: Lee given-names: Jiwoo orcid: "https://orcid.org/0000-0002-0016-7199" - family-names: Zhang given-names: Chengzhu orcid: "https://orcid.org/0000-0002-9632-0716" date-published: 2024-06-29 doi: 10.21105/joss.06426 issn: 2475-9066 issue: 98 journal: Journal of Open Source Software publisher: name: Open Journals start: 6426 title: "xCDAT: A Python Package for Simple and Robust Analysis of Climate Data" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06426" volume: 9 title: "xCDAT: A Python Package for Simple and Robust Analysis of Climate Data" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 4 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 4 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5553
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06426
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

arfon commented 4 months ago

@brian-rose, @mgrover1 – many thanks for your reviews here! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨

@tomvothecoder – your paper is now accepted and published in JOSS :zap::rocket::boom:

editorialbot commented 4 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06426/status.svg)](https://doi.org/10.21105/joss.06426)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06426">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06426/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06426/status.svg
   :target: https://doi.org/10.21105/joss.06426

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

tomvothecoder commented 4 months ago

@brian-rose, @mgrover1 – many thanks for your reviews here! JOSS relies upon the volunteer effort of people like you and we simply wouldn't be able to do this without you ✨

@tomvothecoder – your paper is now accepted and published in JOSS ⚡🚀💥

Thanks @arfon for facilitating the review process for this paper! I am grateful and excited to have this xCDAT paper published in JOSS. This is a great milestone for the project.

And big thanks to @brian-rose and @mgrover1 for your diligent review. I appreciate your time and interest in xCDAT! Feel free to reach out if you ever need anything xCDAT related (or a review of a paper like this) :)

openjournals / joss-reviews