[REVIEW]: MapReader: v1.1.0

editorialbot commented 7 months ago

Submitting author: !--author-handle-->@kmcdono2@emdupre<!--end-editor-- Reviewers: @geekysquirrel, @PipGrylls, @jordibc Archive: 10.5281/zenodo.13643609

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/96e2d51da2c283a40c38101856f1f15c"><img src="https://joss.theoj.org/papers/96e2d51da2c283a40c38101856f1f15c/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/96e2d51da2c283a40c38101856f1f15c/status.svg)](https://joss.theoj.org/papers/96e2d51da2c283a40c38101856f1f15c)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@geekysquirrel & @PipGrylls & @jordibc, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @emdupre know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @PipGrylls

📝 Checklist for @jordibc

📝 Checklist for @geekysquirrel

editorialbot commented 1 month ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

emdupre commented 1 month ago

Thank you, @rwood-97 ! I've updated the archive and confirmed that it the paper rendering looks correct.

I'm now happy to recommend MapReader to the JOSS EiC team for publication.

Thank you again to @geekysquirrel, @PipGrylls, and @jordibc for all of your work throughout this review process ! 💐

emdupre commented 1 month ago

@editorialbot recommend-accept

editorialbot commented 1 month ago

Attempting dry run of processing paper acceptance...

editorialbot commented 1 month ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1145/3557919.3565812 is OK
- 10.5281/ZENODO.7147906 is OK
- 10.1093/jvcult/vcab009 is OK
- 10.1016/j.regsciurbeco.2021.103711 is OK
- 10.1145/3394486.3403381 is OK
- 10.48550/ARXIV.2101.12478 is OK
- 10.21105/joss.01800 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Dynamic phenotyping of whole oilseed rape (Brassic...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

editorialbot commented 1 month ago

:wave: @openjournals/ese-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5793, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

rwood-97 commented 1 month ago

Hi @emdupre

Would it be possible to hold off publishing for ~1 week as we've decided to do the repo transfer and would ideally like to do this before publication of the JOSS paper incase we need to update any links. I do this asap will update you when its done.

emdupre commented 1 month ago

👋 Hi @rwood-97, EiC @kthyng has OK'ed a wait so this should be fine on our end.

I'll go ahead and set a reminder here to check back with you in one week in case we haven't heard anything by then !

emdupre commented 1 month ago

@editorialbot remind @rwood-97 in one week

editorialbot commented 1 month ago

@rwood-97 doesn't seem to be a reviewer or author for this submission.

emdupre commented 1 month ago

@editorialbot remind @kmcdono2 in one week

editorialbot commented 1 month ago

Reminder set for @kmcdono2 in one week

rwood-97 commented 1 month ago

Hi, we've just transferred the repo to https://github.com/maps-as-data/MapReader! I think we need to update one link in the paper (the contributors right at the end) and then should be good to go. Both myself and @kmcdono2 are off the rest of this week so will do this first thing next week :)

editorialbot commented 1 month ago

:wave: @kmcdono2, please update us on how things are progressing here (this is an automated reminder).

rwood-97 commented 1 month ago

Hi, could you update the DOI for the zenodo record to: 10.5281/zenodo.13643609.

We are happy for this to proceed now on our end, sorry for all the last minute changes!

emdupre commented 1 month ago

@editorialbot set 10.5281/zenodo.13643609 as archive

editorialbot commented 1 month ago

Done! archive is now 10.5281/zenodo.13643609

emdupre commented 1 month ago

@editorialbot generate pdf

editorialbot commented 1 month ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

emdupre commented 1 month ago

👋 @kthyng This is now ready !

emdupre commented 1 month ago

@editorialbot recommend-accept

editorialbot commented 1 month ago

Attempting dry run of processing paper acceptance...

editorialbot commented 1 month ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1145/3557919.3565812 is OK
- 10.5281/ZENODO.7147906 is OK
- 10.1093/jvcult/vcab009 is OK
- 10.1016/j.regsciurbeco.2021.103711 is OK
- 10.1145/3394486.3403381 is OK
- 10.48550/ARXIV.2101.12478 is OK
- 10.21105/joss.01800 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Dynamic phenotyping of whole oilseed rape (Brassic...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

editorialbot commented 1 month ago

:wave: @openjournals/ese-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5855, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

kmcdono2 commented 1 month ago

Sorry, I found a few typos in my final read! Fixing these now.

kmcdono2 commented 1 month ago

Fixes done!

kmcdono2 commented 1 month ago

@emdupre do you need to check again? (Sorry!)

kthyng commented 4 weeks ago

Ok I changed the repo link at the top of this review issue to https://github.com/maps-as-data/MapReader.

@openjournals/dev this submission is just about to be published and the authors changed the organization of the repo. Is there anywhere else the link needs to be updated?

kthyng commented 4 weeks ago

Hi! I'll take over now as Track Associate Editor in Chief to do some final submission editing checks. After these checks are complete, I will publish your submission!

[x] Are checklists all checked off?
[x] Check that version was updated and make sure the version from JOSS matches github and Zenodo.
[x] Check that software archive exists, has been input to JOSS, and title and author list match JOSS paper (or purposefully do not).
[x] Check paper.

kthyng commented 4 weeks ago

@kmcdono2 I'm seeing multiple versions associated with this JOSS paper:

github v1.3.3 (https://github.com/maps-as-data/MapReader/releases/tag/v1.3.3)
zenodo v1.3.10 (https://doi.org/10.5281/zenodo.13643609)
JOSS v1.3.9 (top of this issue)

Which is it meant to be?

kthyng commented 4 weeks ago

Also in the JOSS-associated Zenodo version archive we request that the title and author list match the JOSS paper (not sure if you already discussed this above because the page is really long). Can you update the Zenodo metadata so these match? (it's a request not a requirement)

rwood-97 commented 3 weeks ago

Hi @kthyng ,

We'd like to link to v1.3.10 which is the version after we moved to maps-as-data org. ~~I'll update the order of authors on this zenodo record now~~ Apparently I'd already done this

kthyng commented 3 weeks ago

@editorialbot set v1.3.10 as version

editorialbot commented 3 weeks ago

Done! version is now v1.3.10

kthyng commented 3 weeks ago

@rwood-97 Ok great about the author order in Zenodo — how about the title? Did you want to update that for this version to match your JOSS paper or leave it as is?

rwood-97 commented 3 weeks ago

Hi, just done this. Title for the zenodo record is now "MapReader: Open software for the visual analysis of maps" too

kmcdono2 commented 3 weeks ago

All good here now?

kthyng commented 3 weeks ago

@kmcdono2 @rwood-97 That finalizes my checks but I am not sure if there is anything else to be done to make sure your new github address has been updated everywhere. I am pinging the dev team elsewhere to follow up.

xuanxu commented 2 weeks ago

@kthyng I've updated the repository URL for this submission in the JOSS site, nothing else needs updating before acceptance.

kthyng commented 1 week ago

@xuanxu Thank you!

Sorry for my delay — I've been traveling. Everything is ready to go!

kthyng commented 1 week ago

@editorialbot accept

editorialbot commented 1 week ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 1 week ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Wood given-names: Rosie orcid: "https://orcid.org/0000-0003-1623-1949" - family-names: Hosseini given-names: Kasra orcid: "https://orcid.org/0000-0003-4396-6019" - family-names: Westerling given-names: Kalle orcid: "https://orcid.org/0000-0002-2014-332X" - family-names: Smith given-names: Andrew orcid: "https://orcid.org/0000-0002-4465-2284" - family-names: Beelen given-names: Kaspar orcid: "https://orcid.org/0000-0001-7331-1174" - family-names: Wilson given-names: Daniel C. S. orcid: "https://orcid.org/0000-0001-6886-775X" - family-names: McDonough given-names: Katherine orcid: "https://orcid.org/0000-0001-7506-1025" contact: - family-names: McDonough given-names: Katherine orcid: "https://orcid.org/0000-0001-7506-1025" doi: 10.5281/zenodo.13643609 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Wood given-names: Rosie orcid: "https://orcid.org/0000-0003-1623-1949" - family-names: Hosseini given-names: Kasra orcid: "https://orcid.org/0000-0003-4396-6019" - family-names: Westerling given-names: Kalle orcid: "https://orcid.org/0000-0002-2014-332X" - family-names: Smith given-names: Andrew orcid: "https://orcid.org/0000-0002-4465-2284" - family-names: Beelen given-names: Kaspar orcid: "https://orcid.org/0000-0001-7331-1174" - family-names: Wilson given-names: Daniel C. S. orcid: "https://orcid.org/0000-0001-6886-775X" - family-names: McDonough given-names: Katherine orcid: "https://orcid.org/0000-0001-7506-1025" date-published: 2024-09-26 doi: 10.21105/joss.06434 issn: 2475-9066 issue: 101 journal: Journal of Open Source Software publisher: name: Open Journals start: 6434 title: "MapReader: Open software for the visual analysis of maps" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06434" volume: 9 title: "MapReader: Open software for the visual analysis of maps" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 1 week ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 1 week ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5922
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06434
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

kthyng commented 1 week ago

Congratulations on your new publication @kmcdono2! Many thanks to editor @emdupre and to reviewers @geekysquirrel, @PipGrylls, and @jordibc for your time, hard work, and expertise!! JOSS wouldn't be able to function nor succeed without your efforts.

@kmcdono2 I see you are in our reviewer database (thank you!) though you don't have any keywords associated with yourself, so you will never come up in a search when we're trying to find reviewers. It would be great if you'd be willing to update that. Just a heads up! https://reviewers.joss.theoj.org/

editorialbot commented 1 week ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06434/status.svg)](https://doi.org/10.21105/joss.06434)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06434">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06434/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06434/status.svg
   :target: https://doi.org/10.21105/joss.06434

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

openjournals / joss-reviews