Open editorialbot opened 6 months ago
editorialbot
commented
6 months ago Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.
For a list of things I can do to help you, just type:
@editorialbot commandsFor example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
@editorialbot generate pdfReference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1364/AO.27.002502 is OK
- 10.1109/WHISPERS.2014.8077573 is OK
- 10.1093/mnras/111.4.377 is OK
MISSING DOIs
- None
INVALID DOIs
- https://doi.org/10.1016/S0098-3004(97)00130-1 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1175/1520-0477(1998)079<2101:SARATS>2.0.CO;2 is INVALID because of 'https://doi.org/' prefix
Software report:
github.com/AlDanial/cloc v 1.90 T=0.10 s (643.9 files/s, 445267.2 lines/s)
-------------------------------------------------------------------------------
Language files blank comment code
-------------------------------------------------------------------------------
Fortran 77 8 2738 8727 8640
Jupyter Notebook 24 0 11827 5269
Python 14 517 657 2423
Fortran 90 1 508 128 2043
Markdown 5 77 0 324
YAML 4 13 22 118
TeX 1 5 0 73
TOML 1 3 0 31
DOS Batch 1 8 1 26
reStructuredText 2 11 18 13
make 2 7 8 12
Bourne Shell 1 1 6 6
-------------------------------------------------------------------------------
SUM: 64 3888 21394 18978
-------------------------------------------------------------------------------Commit count by author:
134 Dion Ho Jia Xu
7 Dion Ho JX
6 Robert Pincus
4 Maths2209Paper file info:
📄 Wordcount for paper.md is 1036
✅ The paper includes a Statement of need section
editorialbot
commented
6 months ago License info:
✅ License found: MIT License (Valid open source OSI approved license)
editorialbot
commented
6 months ago :point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
phibeck
commented
6 months ago @dhjx1996 as reported above by editorialbot, there are two references with invalid DOIs. When you have a moment, please fix these, thanks
arjunsavel
commented
6 months ago 
dhjx1996
commented
6 months ago @dhjx1996 as reported above by editorialbot, there are two references with invalid DOIs. When you have a moment, please fix these, thanks
I have fixed these and pushed the changes.
phibeck
commented
6 months ago @editorialbot check references
editorialbot
commented
6 months ago Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1364/AO.27.002502 is OK
- 10.1109/WHISPERS.2014.8077573 is OK
- 10.1016/S0098-3004(97)00130-1 is OK
- 10.1175/1520-0477(1998)079<2101:SARATS>2.0.CO;2 is OK
- 10.1093/mnras/111.4.377 is OK
MISSING DOIs
- None
INVALID DOIs
- None
simonrp84
commented
6 months ago phibeck
commented
5 months ago @arjunsavel, @simonrp84 & @pscicluna, thanks again for reviewing! Just checking in on your review. Please let me know if you have any questions about the process. Feel free to create issues in project repository directly or write them down as comments here, but please do link the issues in this review so it's easy to follow for everyone. @pscicluna, please go ahead and create your checklist first using the command @editorialbot generate my checklist.
phibeck
commented
5 months ago @arjunsavel, @simonrp84 & @pscicluna let me know if there is anything stopping you from starting your reviews. We aim for a publication time of ~3 months, so it is ideal if reviewers can complete their review in 4-6 weeks.
arjunsavel
commented
4 months ago Thank you for your patience. I’ve finished my review of the PythonicDISORT package. It’s an excellent piece of work that has clear utility in both pedagogical and research contexts.
My comments are below. Provided they’re addressed, I recommend this project for acceptance.
Miscellaneous
Code edits
Paper edits
Documentation
phibeck
commented
4 months ago Thank you @arjunsavel for the update on your review! @dhjx1996, feel free to get started working on the comments and issues raised by the reviewer.
@simonrp84 & @pscicluna please let me know if you have any questions or if you need more time for your reviews, thanks.
dhjx1996
commented
4 months ago @arjunsavel Thank you very much for the review. I greatly appreciate the feedback and praise. Here are my updates with respect to your feedback:
Thank you for your patience. I’ve finished my review of the PythonicDISORT package. It’s an excellent piece of work that has clear utility in both pedagogical and research contexts.
My comments are below. Provided they’re addressed, I recommend this project for acceptance.
Miscellaneous
This seems like quite a large GitHub repo. I believe 695 MB?
- Could some of the size be cut down by trimming notebook histories? And evaluate the notebooks on the fly?
The repository's large size is due to the .npz files for the pytest reference solutions. I have reduced the $\tau$ test points to exactly those used in the DISORT tests (disotest.f90) and the repository is now 140 MB. Let me know if this size reduction is sufficient.
- The benefit of downloading the optional dependencies is not immediately apparent.
Made changes to README.md.
- No community guidelines. Maybe make a contributing.md?
Added.
- Really impressive set of notebooks!
- Thoughts on including polarization?
It is not a priority especially since the feature is not in DISORT, but as a rule I am happy to add features to PythonicDISORT.
Code edits
- Could you please add function documentation in _one_Fourier_mode? For each argument?
- Same with _loop_and_assemble_results. Even though these aren’t ever accessed directly, documenting these makes for easier contributor / developer experience.
I have improved the documentation in every module.
- pydisort is a bit of a long function and could likely be modularized. Is it implemented this way to be more one-to-one with the original fortran? Either way, this isn’t something that gets in the way of acceptance — I’m mostly just curious.
This is caused by the length of the NT correction functions. I can modularize the NT corrections but I am currently disinclined to that change since it would be a major deviation from DISORT wherein NT corrections are under-the-hood and always performed if possible.
- Some code could maybe be vectorized — e.g. in src/PythonicDISORT/_diagonalize.py. Again, not required for acceptance.
Yes, and I have and will continue to optimize the code. As of v0.7.0, however, I believe every expensive operation (e.g. diagonalization) is vectorized and no longer in Python for-loops.
- Could you add a more descriptive docstring to _assemble_solution_functions?
Added.
Paper edits
- Can we get definitions of the terms in the equations?
Added.
- Are omega and D functions of tau?
No. I added clarifications.
- You mention computational reasons…are those temporary? Is speed optimization a future goal, e.g., with numba, or Jax, or python? Or even joblib for parallelization? If you end up using Jax, you could replace your autograd usage with jax.
Speed optimization has been and remains a goal, but it is impossible for the Python-based PythonicDISORT to match the FORTRAN-based DISORT in speed. I have attempted parallelization with joblib but the overhead actually results in a net slow down for all practical use cases. I am disinclined to use numba or Jax because they diminish the main advantage of PythonicDISORT which is its ease of use and installation. In fact, I have a guideline in CONTRIBUTING.md stating that "PythonicDISORT should remain system agnostic and installable through a simple pip install command. If your contributions have dependencies, they should be similarly accessible and easy to install."
- Is “comprehensive documentation” meant to be hyperlinked?
- Widely used —> widely used,
- Please cite numpy, scipy, Jupyter notebook
- Please hyperlink GitHub and pypi for your specific thing
These changes made been made.
- Any citations for the applications?
Unfortunately I am not aware of any published applications at the moment (PythonicDISORT is quite new). At least two of the projects which are using PythonicDISORT are close to publication, however, and if they are published before this then I will add the citations.
- What about other pythonic radiative transfer codes?
They are Python wrappers around DISORT. I have added two citations into the paper.
- Nice clearly written statement of need!
Documentation
- Please also include the installation instructions here.
Added.
dhjx1996
commented
4 months ago @editorialbot check references
editorialbot
commented
4 months ago Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1038/s41592-019-0686-2 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1364/AO.27.002502 is OK
- 10.1109/WHISPERS.2014.8077573 is OK
- 10.1016/S0098-3004(97)00130-1 is OK
- 10.1175/1520-0477(1998)079<2101:SARATS>2.0.CO;2 is OK
- 10.1093/mnras/111.4.377 is OK
MISSING DOIs
- No DOI given, and none found for title: Jupyter Notebooks – a publishing format for reprod...
- No DOI given, and none found for title: Radiative Transfer
- No DOI given, and none found for title: pyRT_DISORT: A pre-processing front-end to help ma...
- No DOI given, and none found for title: pyDISORT
- No DOI given, and none found for title: LLLab disort website
INVALID DOIs
- None
@editorialbot generate pdf
editorialbot
commented
4 months ago :point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
dhjx1996
commented
4 months ago @phibeck @simonrp84 @arjunsavel @pscicluna The latest version of PythonicDISORT is now v0.7.0. This has been released on GitHub and on PyPI.
dhjx1996
commented
4 months ago Reference check summary (note 'MISSING' DOIs are suggestions that need verification): OK DOIs - 10.1038/s41592-019-0686-2 is OK - 10.1038/s41586-020-2649-2 is OK - 10.1364/AO.27.002502 is OK - 10.1109/WHISPERS.2014.8077573 is OK - 10.1016/S0098-3004(97)00130-1 is OK - 10.1175/1520-0477(1998)079<2101:SARATS>2.0.CO;2 is OK - 10.1093/mnras/111.4.377 is OK MISSING DOIs - No DOI given, and none found for title: Jupyter Notebooks – a publishing format for reprod... - No DOI given, and none found for title: Radiative Transfer - No DOI given, and none found for title: pyRT_DISORT: A pre-processing front-end to help ma... - No DOI given, and none found for title: pyDISORT - No DOI given, and none found for title: LLLab disort website INVALID DOIs - None
@phibeck Regarding the missing DOIs, these are all references to packages. The one exception is the book "Radiative Transfer" by Chandrasekhar (1960) for which I could not find a DOI.
simonrp84
commented
4 months ago Apologies for the delay in reviewing - I have been more busy than expected recently. I will submit my review later this week.
simonrp84
commented
4 months ago This is a very interesting library, thanks for creating it! Unfortunately I cannot test all of the code due to a missing module, for which I've created a github issue. This module is included in the github repo, but the docs do not describe how to install it.
I agree with @arjunsavel's comments on the manuscript and library, so please address all of those. In addition, I have some other points to raise - which are listed below.
Paper comments:
The software paper is well-written. However, I miss a brief introduction (one or two sentences) as to why an RT code is needed.
Throughout the paper there are various terms that are not introduced. For example, theta (line 9). Even though it's usually clear what these terms are from the context I think the terms should be explicitly introduced. From personal experience, different DISORT users have different interpretations of geometry terms, so being clear would be very helpful here.
Same for I_0 and mu_0, which are also undefined.
Line 33: ODE is not introduced.
Line 46: "projects which" should be "projects that"
General paper comment, I see some places where "we" is used (f.ex line 47: "We will continue...") this seems odd for a single-author paper. Either there should be more authors, or "we" is inappropriate. Can you please clarify this in the text and / or repository.
Code/repo comments:
It looks like the code in the ./disort4.0.99_f2py/ directory is based on code from elsewhere...does that affect the license?
The git repo is huge (~140Mb) compared to the size of the source code (~2.5Mb). I presume this is a remnant to the tidying that the other reviewer recommended. Can you do clean up the history to reduce this file size?
For the docs, could you also add a statement saying that the notebook should be used as an example? This is mentioned in the readme but not, as far as I can see, in the docs themselves.
The notebook in the docs folder is very comprehensive and nicely introduces the various concepts and uses of the library, great work!
I do miss a simple example, though. The notebook is somewhat overwhelming for a newbie. Would it be possible to add a notebook demonstrating some simple use of DISORT? Maybe simulating the signal for an airborne or spaceborne sensor, the effect of Rayleigh scattering, or something like that? I note in this context the reviewer checklist item: "Do the authors include examples of how to use the software (ideally to solve real-world analysis problems)."
I've ticked the appropriate boxes in the reviewer checklist, and will await an author response before going further. Sorry again for my long delay in performing this review.
dhjx1996
commented
4 months ago @simonrp84 Thank you very much for the review! I will address the most urgent matters and follow-up on the rest later this week.
This is a very interesting library, thanks for creating it! Unfortunately I cannot test all of the code due to a missing module, for which I've created a github issue. This module is included in the github repo, but the docs do not describe how to install it.
- It looks like the code in the
./disort4.0.99_f2py/directory is based on code from elsewhere...does that affect the license?
disort4.0.99 is the original FORTRAN-based DISORT that PythonicDISORT reimplements in Python. disort4.0.99_f2py is disort4.0.99 but with a Python-wrapper added by me. The missing module is this Python-wrapped DISORT. The test notebooks require it as they run both DISORT and PythonicDISORT to compare their results. I included disort4.0.99_f2py in my repository for this reason, but installation of disort4.0.99_f2py is system-dependent and users will have to independently install FORTRAN compilers. Note that running pytest in the pydisotest directory bypasses the need for DISORT since I have saved its results in .npz files, but the test notebooks are how I generate those .npz files.
I see two possibilities going forward:
1) Make very clear to users that they should not expect the disort (Python-wrapped DISORT) module to work. I can also document how I installed it, but I am concerned about causing more confusion as my installation experience is unlikely to be universal.
2) Remove disort4.0.99_f2py and remove all references to disort. This would prevent confusion with that module and prevent licensing issues (does its inclusion cause licensing issues @phibeck ?) but would cause the reference solutions for the tests (solutions from DISORT) to be harder to reproduce.
I am currently inclined towards 2) as it would also reduce the size of the repository, but feedback on this would be appreciated.
- The git repo is huge (~140Mb) compared to the size of the source code (~2.5Mb). I presume this is a remnant to the tidying that the other reviewer recommended. Can you do clean up the history to reduce this file size?
Minor remark: I have already cleaned the history using git-filter-repo but I will look into how to further reduce the size of the repository.
dhjx1996
commented
4 months ago As a follow-up to my previous comment, I will revamp the current test notebooks into examples for users and remove disort4.0.99_f2py and all references to the disort module to avoid licensing issues. I may make some changes to how the tests are conducted but there will still be automated tests at the very least. I will update on this and on the other points raised by @simonrp84 as soon as possible.
phibeck
commented
4 months ago Hi @dhjx1996 I think this is a good idea to avoid licensing issues, although the details of such potential issues would probably depend on the license of DISORT. It seems sensible to me to remove the module and just provide the reference solutions as benchmarks. Of course that requires that the author(s) of PythonicDISORT keep this data up-to-date.
Thanks @simonrp84 for getting your review started! @pscicluna please let me know if you have any question about the review process or if you need more time as ideally we'd like to finish the review within 4-6 weeks.
phibeck
commented
3 months ago Hi @dhjx1996 just checking in on the progress on code changes you intended to make in response to the reviewer's comments/suggestions.
@arjunsavel could you let me know whether your comments and suggestions have been addressed adequately? Thanks.
@pscicluna I would appreciate if you could let me know if there's anything holding you up or if you need more time for the review, thank you.
dhjx1996
commented
3 months ago Hi @dhjx1996 just checking in on the progress on code changes you intended to make in response to the reviewer's comments/suggestions.
@arjunsavel could you let me know whether your comments and suggestions have been addressed adequately? Thanks.
@pscicluna I would appreciate if you could let me know if there's anything holding you up or if you need more time for the review, thank you.
Sorry, I will complete the changes by next Monday.
arjunsavel
commented
3 months ago @dhjx1996 thank you for responding to my suggestions! My last request is just a few more docstrings (_assemble_intensity_and_fluxes.u, _assemble_intensity_and_fluxes.u0, _assemble_intensity_and_fluxes.flux_up, etc.). I know these are internal functions that likely won't be used by users, but it will facilitate easier development later down the road if other people touch the code.
Aside from this, all the changes are to my satisfaction.
phibeck
commented
3 months ago Thank you both for the update, @dhjx1996 and @arjunsavel. I'll check back in next week.
dhjx1996
commented
3 months ago @dhjx1996 thank you for responding to my suggestions! My last request is just a few more docstrings (_assemble_intensity_and_fluxes.u, _assemble_intensity_and_fluxes.u0, _assemble_intensity_and_fluxes.flux_up, etc.). I know these are internal functions that likely won't be used by users, but it will facilitate easier development later down the road if other people touch the code.
Aside from this, all the changes are to my satisfaction.
Added the docstrings using the same descriptions as in the docstring of pydisort.
dhjx1996
commented
3 months ago Sorry for the delays, I have made changes to address feedback from @simonrp84 and @arjunsavel
This is a very interesting library, thanks for creating it! Unfortunately I cannot test all of the code due to a missing module, for which I've created a github issue. This module is included in the github repo, but the docs do not describe how to install it.
All the Jupyter Notebooks in pydisotest should work now regardless of whether a F2Py-wrapped Stamnes' DISORT is installed.
I agree with @arjunsavel's comments on the manuscript and library, so please address all of those. In addition, I have some other points to raise - which are listed below.
Paper comments:
- The software paper is well-written. However, I miss a brief introduction (one or two sentences) as to why an RT code is needed.
I added three citations to show the use of RT code in the retrieval of optical properties from measurements (as an example).
- Throughout the paper there are various terms that are not introduced. For example, theta (line 9). Even though it's usually clear what these terms are from the context I think the terms should be explicitly introduced. From personal experience, different DISORT users have different interpretations of geometry terms, so being clear would be very helpful here.
- Same for I_0 and mu_0, which are also undefined.
- Line 33: ODE is not introduced.
- Line 46: "projects which" should be "projects that"
- General paper comment, I see some places where "we" is used (f.ex line 47: "We will continue...") this seems odd for a single-author paper. Either there should be more authors, or "we" is inappropriate. Can you please clarify this in the text and / or repository.
All these changes have been made.
Code/repo comments:
- It looks like the code in the
./disort4.0.99_f2py/directory is based on code from elsewhere...does that affect the license?
disort4.0.99_f2py has been completely removed from the repository, including from the repository's history.
- The git repo is huge (~140Mb) compared to the size of the source code (~2.5Mb). I presume this is a remnant to the tidying that the other reviewer recommended. Can you do clean up the history to reduce this file size?
I have re-written the history of the entire repository, unfortunately this removes all date and contributor data from GitHub (the sole contributor is my PhD advisor Robert Pincus). The benefit, however, is that the repository size is now 6mb. I hope this is satisfactory.
- For the docs, could you also add a statement saying that the notebook should be used as an example? This is mentioned in the readme but not, as far as I can see, in the docs themselves.
- The notebook in the docs folder is very comprehensive and nicely introduces the various concepts and uses of the library, great work!
- I do miss a simple example, though. The notebook is somewhat overwhelming for a newbie. Would it be possible to add a notebook demonstrating some simple use of DISORT? Maybe simulating the signal for an airborne or spaceborne sensor, the effect of Rayleigh scattering, or something like that? I note in this context the reviewer checklist item: "Do the authors include examples of how to use the software (ideally to solve real-world analysis problems)."
The Jupyter Notebooks in the pydisotest directory should now better play the role of examples of use and these notebooks are now mentioned in the documentation.
I've ticked the appropriate boxes in the reviewer checklist, and will await an author response before going further. Sorry again for my long delay in performing this review.
dhjx1996
commented
3 months ago @editorialbot generate pdf
dhjx1996
commented
3 months ago @editorialbot check references
editorialbot
commented
3 months ago Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1029/2020GL088941 is OK
- 10.1029/1999JD900040 is OK
- 10.1109/TGRS.2008.2000631 is OK
- 10.1038/s41592-019-0686-2 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1364/AO.27.002502 is OK
- 10.1109/WHISPERS.2014.8077573 is OK
- 10.1016/S0098-3004(97)00130-1 is OK
- 10.1175/1520-0477(1998)079<2101:SARATS>2.0.CO;2 is OK
- 10.1093/mnras/111.4.377 is OK
MISSING DOIs
- No DOI given, and none found for title: Jupyter Notebooks – a publishing format for reprod...
- No DOI given, and none found for title: Radiative Transfer
- No DOI given, and none found for title: pyRT_DISORT: A pre-processing front-end to help ma...
- No DOI given, and none found for title: pyDISORT
- No DOI given, and none found for title: LLLab disort website
INVALID DOIs
- None
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
arjunsavel
commented
3 months ago Looks great — thank you for addressing my comments!
phibeck
commented
2 months ago Hi @dhjx1996 thanks for the update.
@simonrp84 can you let me know whether the changes are satisfactory?
@arjunsavel thanks for your feedback. Do I understand correctly that this completes your review? If so, could you please go through your checklist and tick off the last remaining items? Thank you.
dhjx1996
commented
2 months ago Made minor paper changes.
dhjx1996
commented
2 months ago @editorialbot generate pdf
editorialbot
commented
2 months ago :point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
simonrp84
commented
2 months ago Apologies, I have only just seen the updates on this. I'm on sick leave just now but will look ASAP.
phibeck
commented
2 months ago Hi @simonrp84 I hope you are feeling better again. Let me know if you need more time to complete your review, thanks.
phibeck
commented
1 month ago Hi @simonrp84 could we please get an update on when you will be able to review the changes?
phibeck
commented
1 month ago Hi @simonrp84 please let us know whether you will be able to complete your review within the next 2-4 weeks. I will reach out via email too just in case the github notifications have gotten lost.
dhjx1996
commented
1 month ago Hi all, I have a good amount of time this period to make rapid changes if any are required. I would like to get this review done soon. Thank you!
phibeck
commented
3 weeks ago Hi @dhjx1996 just a quick update, I haven't heard back from @simonrp84, and contacted @pscicluna via email to check whether they would be still be available to review since we need a second completed review. Thank you for your patience.
phibeck
commented
3 days ago @editorialbot remind @pscicluna in two weeks
Submitting author: !--author-handle-->@dhjx1996<!--end-author-handle-- (Jia Xu Dion Ho) Repository: https://github.com/LDEO-CREW/Pythonic-DISORT Branch with paper.md (empty if default branch): Version: v0.4.2 Editor: !--editor-->@phibeck<!--end-editor-- Reviewers: @arjunsavel, @simonrp84, @pscicluna Archive: Pending
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@arjunsavel & @simonrp84 & @pscicluna, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @phibeck know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @arjunsavel
📝 Checklist for @simonrp84