openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
720 stars 38 forks source link

[PRE REVIEW]: ncompare: A Python package for comparing netCDF structures #6479

Closed editorialbot closed 7 months ago

editorialbot commented 7 months ago

Submitting author: !--author-handle-->@dkauf42<!--end-author-handle-- (Daniel E Kaufman) Repository: https://github.com/nasa/ncompare Branch with paper.md (empty if default branch): joss-paper Version: 1.8.0 Editor: !--editor-->@arfon<!--end-editor-- Reviewers: @cmtso, @cmarmo Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/c12f4805d34b49fe4f814b2639fdfc96"><img src="https://joss.theoj.org/papers/c12f4805d34b49fe4f814b2639fdfc96/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/c12f4805d34b49fe4f814b2639fdfc96/status.svg)](https://joss.theoj.org/papers/c12f4805d34b49fe4f814b2639fdfc96)

Author instructions

Thanks for submitting your paper to JOSS @dkauf42. Currently, there isn't a JOSS editor assigned to your paper.

@dkauf42 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 7 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 7 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5281/zenodo.7112925 is OK
- 10.1063/1.4823180 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.5334/jors.148 is OK
- 10.1109/38.56302 is OK

MISSING DOIs

- No DOI given, and none found for title: Python 3 Reference Manual
- No DOI given, and none found for title: Hierarchical Data Format, version 5
- No DOI given, and none found for title: Python: A dynamic, open source programming languag...
- No DOI given, and none found for title: TEMPO geolocated Earth radiances (BETA)

INVALID DOIs

- https://doi.org/10.1016/j.envsoft.2008.03.004 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.jqsrt.2016.05.008 is INVALID because of 'https://doi.org/' prefix
editorialbot commented 7 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.03 s (1494.6 files/s, 159768.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          14            273            266           1063
Markdown                         9            186              0            714
YAML                            10             52             56            328
Jupyter Notebook                 2              0            700            192
TeX                              1              1              0            129
CSV                              1              0              0            103
TOML                             1              9              3             75
CSS                              1              0              0             19
-------------------------------------------------------------------------------
SUM:                            39            521           1025           2623
-------------------------------------------------------------------------------

Commit count by author:

   282  danielfromearth
   152  ncompare bot
    59  dependabot[bot]
    33  Daniel Kaufman
editorialbot commented 7 months ago

Paper file info:

πŸ“„ Wordcount for paper.md is 939

βœ… The paper includes a Statement of need section

editorialbot commented 7 months ago

License info:

πŸ”΄ Failed to discover a valid open source license

editorialbot commented 7 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

arfon commented 7 months ago

@dkauf42 – thanks for your submission to JOSS. I see there is a NOSA license under the licenses folder. Could you also please make sure there is a plain-text version of the license at the root of the repository named LICENSE?

arfon commented 7 months ago

Cross-linking with pyOpenSci submission here: https://github.com/pyOpenSci/software-submission/issues/146

RMeli commented 7 months ago

@arfon I can edit this one if needed.

arfon commented 7 months ago

@RMeli – there's actually no work to do here as the paper has already been accepted at pyOpenSci. But thanks anyway!

arfon commented 7 months ago

@editorialbot assign @cmarmo as reviewer

editorialbot commented 7 months ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

arfon commented 7 months ago

@editorialbot add @cmtso as reviewer

editorialbot commented 7 months ago

Can't add reviewers: There is no editor assigned yet

arfon commented 7 months ago

@editorialbot assign me as editor

editorialbot commented 7 months ago

Assigned! @arfon is now the editor

arfon commented 7 months ago

@editorialbot add @cmtso as reviewer

editorialbot commented 7 months ago

@cmtso added to the reviewers list!

arfon commented 7 months ago

@editorialbot add @cmarmo as reviewer

editorialbot commented 7 months ago

@cmarmo added to the reviewers list!

arfon commented 7 months ago

@editorialbot start review

(@cmtso, @cmarmo – there's no work for you to do here as you did the review over in https://github.com/pyOpenSci/software-submission/issues/146 πŸ˜„ )

editorialbot commented 7 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6490.