openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[PRE REVIEW]: Neurosift: DANDI exploration and NWB visualization in the browser #6512

Closed editorialbot closed 7 months ago

editorialbot commented 7 months ago

Submitting author: !--author-handle-->@magland<!--end-author-handle-- (Jeremy Magland) Repository: https://github.com/flatironinstitute/neurosift Branch with paper.md (empty if default branch): paper Version: 0.2.5 Editor: !--editor-->@mstimberg<!--end-editor-- Reviewers: @alexrockhill, @jodeleeuw, @sanjayankur31 Managing EiC: Kevin M. Moerman

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/0b7a6a284076c02bfe5660344d5bb58f"><img src="https://joss.theoj.org/papers/0b7a6a284076c02bfe5660344d5bb58f/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/0b7a6a284076c02bfe5660344d5bb58f/status.svg)](https://joss.theoj.org/papers/0b7a6a284076c02bfe5660344d5bb58f)

Author instructions

Thanks for submitting your paper to JOSS @magland. Currently, there isn't a JOSS editor assigned to your paper.

@magland if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 7 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 7 months ago

Paper file info:

πŸ“„ Wordcount for paper.md is 986

βœ… The paper includes a Statement of need section

editorialbot commented 7 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- No DOI given, and none found for title: The neurodata without borders ecosystem for neurop...
- No DOI given, and none found for title: Neurodata without borders: creating a common data ...
- No DOI given, and none found for title: nwbwidgets: Explore the hierarchical structure of ...
- No DOI given, and none found for title: h5wasm: A WebAssembly HDF5 reader/writer library
- No DOI given, and none found for title: zarr-developers/zarr-python: v2.17.1

INVALID DOIs

- None
editorialbot commented 7 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Kevin-Mattheus-Moerman commented 7 months ago

@editorialbot set main as branch

editorialbot commented 7 months ago

Done! branch is now main

Kevin-Mattheus-Moerman commented 7 months ago

@editorialbot check repository

editorialbot commented 7 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.11 s (2446.2 files/s, 225498.2 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
TypeScript                      243           2316           1877          19687
Markdown                          7            144              0            275
CSS                               8             52              7            271
Python                            4             43             16            182
JSON                              5              0              0            157
HTML                              1              2              0             59
JavaScript                        1              7              8             58
Jupyter Notebook                  1              0             98             49
YAML                              2              1              0             34
Bourne Shell                      2             14             11             27
Bourne Again Shell                1             12             10             25
SVG                               1              0              0              1
--------------------------------------------------------------------------------
SUM:                            276           2591           2027          20825
--------------------------------------------------------------------------------

Commit count by author:

   245  Jeremy Magland
     7  Ben Dichter
editorialbot commented 7 months ago

License info:

βœ… License found: Apache License 2.0 (Valid open source OSI approved license)

Kevin-Mattheus-Moerman commented 7 months ago

@editorialbot set paper as branch

editorialbot commented 7 months ago

Done! branch is now paper

Kevin-Mattheus-Moerman commented 7 months ago

@magland thanks for this submission to JOSS. I am the AEiC on this track. From the above software report it looks like the core functionality of this submission is captured by the TypeScript code. For some submissions we've seen that a significant portion of such TypeScript or JavaScript code has been automatically generated, e.g. by a tool facilitating GUI/web interface creation. Can you please clarify what portion e.g. of the 19687 lines of code is your original and personal contribution, and what portion is perhaps auto-generated or taken from existing libraries? Thanks.

magland commented 7 months ago

Hi @Kevin-Mattheus-Moerman! The vast majority of the code was written by myself or my co-developer Jeff Soules without the assistance of AI. In the past 4 months or so I have been using GitHub Copilot, but this is only for code completion (not writing large sections). In terms of percentages, I would say 90% was written by me and Jeff before copilot assistance and around 10%, more recently, with copilot as an assistant. Essentially no code has been taken from other libraries except for some that was ported over from a related project of mine called sortingview.

magland commented 7 months ago

magland if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

After a searching the reviewers list I came upon the following names as potential reviewers.

Kevin-Mattheus-Moerman commented 7 months ago

@magland thanks for providing the additional clarifying information.

Kevin-Mattheus-Moerman commented 7 months ago

@editorialbot invite @mstimberg as editor

editorialbot commented 7 months ago

Invitation to edit this submission sent!

mstimberg commented 7 months ago

@editorialbot assign me as editor

I'd be happy to edit this submission !

editorialbot commented 7 months ago

Assigned! @mstimberg is now the editor

mstimberg commented 7 months ago

:wave: @magland Thank you for submitting to JOSS ! I will facilitate the review process as the editor, don't hesitate to ping me (@mstimberg) in case of any questions. The first step will be to find reviewers, if you have any suggestions, please mention them here (without tagging them with an @). Thanks!

magland commented 7 months ago

Hi @mstimberg, it's nice to meet you. I searched through the online list and came up with these three names as possible reviewers.

mstimberg commented 7 months ago

Hi @magland. Thank you for your suggestions. I have contacted several potential reviewers over mail, and I am waiting for their reply. Please note that I will be out-of-office until April 7th, so I might be slow to reply during that time. Most likely, the review process will not start before I am back. Many thanks for your patience!

magland commented 7 months ago

@mstimberg sounds good. Thanks for letting me know.

mstimberg commented 7 months ago

@editorialbot add @alexrockhill as reviewer

Thanks again for helping out (and the fast reply :blush:)

editorialbot commented 7 months ago

@alexrockhill added to the reviewers list!

mstimberg commented 7 months ago

@editorialbot add @jodeleeuw as reviewer

Many thanks again for helping out!

editorialbot commented 7 months ago

@jodeleeuw added to the reviewers list!

mstimberg commented 7 months ago

@editorialbot add @sanjayankur31 as reviewer

Great having you on board!

editorialbot commented 7 months ago

@sanjayankur31 added to the reviewers list!

mstimberg commented 7 months ago

@editorialbot start review

editorialbot commented 7 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6590.