search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
720 stars 38 forks source link

[REVIEW]: Pybehave: a hardware-agnostic, Python-based framework for developing behavioral neuroscience experiments #6515

Closed editorialbot closed 4 months ago

editorialbot commented 7 months ago

Submitting author: !--author-handle-->@theonlydvr<!--end-author-handle-- (Evan Dastin-van Rijn) Repository: https://github.com/tne-lab/py-behav-box-v2 Branch with paper.md (empty if default branch): Version: v1.0.19 Editor: !--editor-->@sappelhoff<!--end-editor-- Reviewers: @tuliofalmeida, @alustig3 Archive: 10.5281/zenodo.11244351

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/e115eb80185bcfa240ca9689ee59c2cd"><img src="https://joss.theoj.org/papers/e115eb80185bcfa240ca9689ee59c2cd/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/e115eb80185bcfa240ca9689ee59c2cd/status.svg)](https://joss.theoj.org/papers/e115eb80185bcfa240ca9689ee59c2cd)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@tuliofalmeida & @alustig3, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @sappelhoff know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @alustig3

📝 Checklist for @tuliofalmeida

editorialbot commented 4 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5456
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06515
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

theonlydvr commented 4 months ago

Awesome! Everything looks good except it seems like my last name "Dastin-van Rijn" autogenerated to only have "Rijn" as the last name in the citation metadata. I've corrected this in the CITATION.cff in the original repository but I assume this has no effect on the actual merged paper. Apologies for the space in the last name...

sappelhoff commented 4 months ago

Thanks for letting us know @theonlydvr -- That's probably a task for an AEIC to sort out, as my influence on these things is limited. Is that correct @Kevin-Mattheus-Moerman?

Kevin-Mattheus-Moerman commented 4 months ago

@sappelhoff @theonlydvr yes we can take it from here. I'll ping @openjournals/dev to see if they can offer some guidance on this one.

xuanxu commented 4 months ago

The parts of the name can be described with more precision in the paper's metadata: https://joss.readthedocs.io/en/latest/paper.html#names

Updating the paper.md file and then reaccepting should update the published strings.

theonlydvr commented 4 months ago

Thank you! I think I've fixed it with the latest commit (I just replaced the name with an explicit given and surname).

Kevin-Mattheus-Moerman commented 4 months ago

@editorialbot reaccept

editorialbot commented 4 months ago 
Rebuilding paper!
editorialbot commented 4 months ago

🌈 Paper updated!

New PDF and metadata files :point_right: https://github.com/openjournals/joss-papers/pull/5462

Kevin-Mattheus-Moerman commented 4 months ago

@theonlydvr Are you happy with the update?

theonlydvr commented 4 months ago

Looks great! Thank you!

Kevin-Mattheus-Moerman commented 4 months ago

@theonlydvr congratulations on this JOSS publication!

@sappelhoff thanks for editing!

And a special thank you to the reviewers: @tuliofalmeida, @alustig3 !!

editorialbot commented 4 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06515/status.svg)](https://doi.org/10.21105/joss.06515)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06515">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06515/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06515/status.svg
   :target: https://doi.org/10.21105/joss.06515

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: