[PRE REVIEW]: SubsetTools: A Python package to subset data to build and run ParFlow hydrologic models

[editorialbot]

Submitting author: !--author-handle-->@gartavanis<!--end-author-handle-- (Georgios Artavanis) Repository: https://github.com/hydroframe/subsettools Branch with paper.md (empty if default branch): joss-paper Version: 1.0.3 Editor: !--editor-->@cheginit<!--end-editor-- Reviewers: @JannisHoch, @dvalters Managing EiC: Kristen Thyng

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/295484053df46efd1ab01743c62385af"><img src="https://joss.theoj.org/papers/295484053df46efd1ab01743c62385af/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/295484053df46efd1ab01743c62385af/status.svg)](https://joss.theoj.org/papers/295484053df46efd1ab01743c62385af)

Author instructions

Thanks for submitting your paper to JOSS @gartavanis. Currently, there isn't a JOSS editor assigned to your paper.

@gartavanis if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

[kthyng]

@editorialbot check repository

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.90  T=0.05 s (1072.0 files/s, 237157.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
YAML                            10              3              7           4965
Python                          14            333            490           1298
Jupyter Notebook                 8              0           2843            482
Markdown                        13            146              0            357
TeX                              1             11              0            140
reStructuredText                 2             30             14             76
TOML                             1              4              0             29
DOS Batch                        1              8              1             27
make                             1              4              5             10
-------------------------------------------------------------------------------
SUM:                            51            539           3360           7384
-------------------------------------------------------------------------------

Commit count by author:

   228  George Artavanis
   113  gartavanis
    50  aktriplett
     2  arbennett

[editorialbot]

Paper file info:

📄 Wordcount for paper.md is 1364

✅ The paper includes a Statement of need section

[editorialbot]

License info:

✅ License found: MIT License (Valid open source OSI approved license)

[kthyng]

@editorialbot generate pdf

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[kthyng]

@editorialbot check references

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.13182/NSE96-A24230 is OK
- 10.1016/j.advwatres.2005.08.006 is OK
- 10.1029/2007wr006004 is OK
- 10.1016/j.advwatres.2012.10.001 is OK
- 10.1126/science.aaf7891 is OK
- 10.5194/gmd-8-923-2015 is OK
- 10.5194/gmd-14-7223-2021 is OK
- 10.1111/gwat.13357 is OK
- 10.1016/j.jhydrol.2023.130294 is OK
- 10.5194/essd-13-3263-2021 is OK

MISSING DOIs

- None

INVALID DOIs

- https://doi.org/10.1016/S0309-1708(00)00075-0 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1175/JHM422.1 is INVALID because of 'https://doi.org/' prefix

[kthyng]

Hi @gartavanis and thanks for your submission! I am looking for some specific items to make sure your submission fits our requirements at a high level before moving on to finding an editor or putting this on our waitlist if no relevant editors are available. I'll comment as I have a chance to go through them:

• [x] Substantial scholarly effort
• [x] Documentation
• [x] Tests of some sort
• [x] Installation instructions
• [x] Clear research application
• [x] Check paper

[gartavanis]

Hello,

Thank you for your message. We would like to suggest the following reviewers for the SubsetTools paper:

Name

Affiliation

Robert Reinecke

JGU Mainz

Jannis Hoch

Utrecht University

Kelly Kochanski

University of Colorado

Declan Valters

British Geological Survey

Joshua Larsen

USGS

Thank you, Georgios Artavanis

---

From: The Open Journals editorial robot @.> Sent: Thursday, March 21, 2024 12:45 PM To: openjournals/joss-reviews @.> Cc: George Artavanis @.>; Mention @.> Subject: [openjournals/joss-reviews] [PRE REVIEW]: SubsetTools: A Python package to subset data to build and run ParFlow hydrologic models (Issue #6519)

Submitting author: @gartavanishttps://github.com/gartavanis (Georgios Artavanishttp://orcid.org/0009-0007-6015-7746) Repository: https://github.com/hydroframe/subsettools Branch with paper.md (empty if default branch): joss-paper Version: 1.0.3 Editor: Pending Reviewers: Pending Managing EiC: Kristen Thyng

Status

[status]https://joss.theoj.org/papers/295484053df46efd1ab01743c62385af

Status badge code:

HTML: Markdown:

Author instructions

Thanks for submitting your paper to JOSS @gartavanishttps://github.com/gartavanis. Currently, there isn't a JOSS editor assigned to your paper.

@gartavanishttps://github.com/gartavanis if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of peoplehttps://reviewers.joss.theoj.org/lookup that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbothttps://github.com/editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbothttps://github.com/editorialbot can do for you type:

@editorialbot commands

— Reply to this email directly, view it on GitHubhttps://github.com/openjournals/joss-reviews/issues/6519, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AH2J6CKVEGXB4XC7BRC5XHTYZM2EHAVCNFSM6AAAAABFCC5Z4SVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYDCMBSG4YDSOI. You are receiving this because you were mentioned.Message ID: @.***>

[kthyng]

@gartavanis Comments/questions:

• I see a "docs" dir — how do I see those docs, compiled somehow?
• I'm also looking for installation instructions which would presumably be there or in the readme (but I don't see in the readme)

[gartavanis]

Hi Kristen,

the subsettools documentation is hosted on ReadTheDocs at

https://hydroframesubsettools.readthedocs.io/en/latest/

The documentation includes installation instructions under "Getting started".

Thanks, George

---

From: Kristen Thyng @.> Sent: Thursday, March 28, 2024 3:16 PM To: openjournals/joss-reviews @.> Cc: George Artavanis @.>; Mention @.> Subject: Re: [openjournals/joss-reviews] [PRE REVIEW]: SubsetTools: A Python package to subset data to build and run ParFlow hydrologic models (Issue #6519)

@gartavanishttps://github.com/gartavanis Comments/questions:

• I see a "docs" dir — how do I see those docs, compiled somehow?
• I'm also looking for installation instructions which would presumably be there or in the readme (but I don't see in the readme)

— Reply to this email directly, view it on GitHubhttps://github.com/openjournals/joss-reviews/issues/6519#issuecomment-2026227780, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AH2J6CMMMIQTPRXNAU46V7DY2SJDDAVCNFSM6AAAAABFCC5Z4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRWGIZDONZYGA. You are receiving this because you were mentioned.Message ID: @.***>

[kthyng]

@gartavanis Ah, great! I can't find that link anywhere on the subsettools readme – am I missing it?

[gartavanis]

Hi Kristen,

the first link in the README leads to the SubsetTools page within the HydroFrame project. That page contains a link to the documentation.

I can add the documentation link on the README as well.

Best, George

---

From: Kristen Thyng @.> Sent: Monday, April 1, 2024 12:30 PM To: openjournals/joss-reviews @.> Cc: George Artavanis @.>; Mention @.> Subject: Re: [openjournals/joss-reviews] [PRE REVIEW]: SubsetTools: A Python package to subset data to build and run ParFlow hydrologic models (Issue #6519)

@gartavanishttps://github.com/gartavanis Ah, great! I can't find that link anywhere on the subsettools readme – am I missing it?

— Reply to this email directly, view it on GitHubhttps://github.com/openjournals/joss-reviews/issues/6519#issuecomment-2030415101, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AH2J6CJUNZ7YWR67EZDQPSTY3GYVDAVCNFSM6AAAAABFCC5Z4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZQGQYTKMJQGE. You are receiving this because you were mentioned.Message ID: @.***>

[kthyng]

@gartavanis Ok great yeah a good place is the little "About" section at the top right area on your github repo page. You should see a little gear to click on where you can add a docs link if you want it there.

[kthyng]

@gartavanis Ok I made it through my list. We have a backlog of submissions so I will add this to our waitlist. Thanks for your patience.

[gartavanis]

Thanks!

George

---

From: Kristen Thyng @.> Sent: Monday, April 1, 2024 1:36 PM To: openjournals/joss-reviews @.> Cc: George Artavanis @.>; Mention @.> Subject: Re: [openjournals/joss-reviews] [PRE REVIEW]: SubsetTools: A Python package to subset data to build and run ParFlow hydrologic models (Issue #6519)

@gartavanishttps://github.com/gartavanis Ok I made it through my list. We have a backlog of submissions so I will add this to our waitlist. Thanks for your patience.

— Reply to this email directly, view it on GitHubhttps://github.com/openjournals/joss-reviews/issues/6519#issuecomment-2030513004, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AH2J6COA4QONOS3DWOMDXYDY3HAONAVCNFSM6AAAAABFCC5Z4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZQGUYTGMBQGQ. You are receiving this because you were mentioned.Message ID: @.***>

[kthyng]

@cheginit Can you edit this submission?

[kthyng]

@editorialbot invite @cheginit as editor

[editorialbot]

Invitation to edit this submission sent!

[cheginit]

@kthyng Yes, I can.

[kthyng]

@editorialbot assign @cheginit as editor

[editorialbot]

Assigned! @cheginit is now the editor

[cheginit]

Hi @gartavanis! I will handle your submission.

You only provided the names of the potential reviewers, can you please give me their GitHub handles as well, but without using @ so they don't get pinged prematurely?

[cheginit]

@gartavanis A friendly reminder for providing GitHub handles of potential reviewers (without @).

[gartavanis]

Here are the names : github handles for our potential reviewers:

Robert Reinecke : rreinecke Jannis Hoch : JannisHoch Kelly Kochanski : kellykochanski Declan Valters : dvalters Joshua Larsen : jlarsen-usgs

---

From: Taher Chegini @.> Sent: Monday, April 29, 2024 8:17 AM To: openjournals/joss-reviews @.> Cc: George Artavanis @.>; Mention @.> Subject: Re: [openjournals/joss-reviews] [PRE REVIEW]: SubsetTools: A Python package to subset data to build and run ParFlow hydrologic models (Issue #6519)

@gartavanishttps://github.com/gartavanis A friendly reminder for providing GitHub handles of potential reviewers (without @).

— Reply to this email directly, view it on GitHubhttps://github.com/openjournals/joss-reviews/issues/6519#issuecomment-2082576442, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AH2J6COJK3FES24OZ5ZGWJDY7Y25JAVCNFSM6AAAAABFCC5Z4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBSGU3TMNBUGI. You are receiving this because you were mentioned.Message ID: @.***>

[cheginit]

@gartavanis Thank you!

[cheginit]

Hi @rreinecke, @JannisHoch, and @kellykochanski! Would you like to review this submission to the Journal for Open Source Software? Our reviews are checklist-driven and openly conducted on GitHub over a timeline of 4–6 weeks. Because the process is much more iterative and interactive than a traditional paper review, we would ask you to start within the next 2 weeks. Here are reviewer guidelines for reference: joss.readthedocs.io/en/latest/reviewer_guidelines.html

Thanks for your consideration.

[JannisHoch]

Happy to review

[cheginit]

@JannisHoch Thanks for your prompt response and agreeing to review this submission! Once I find another reviewer, I will create a new issue and ping you to formally start the reivew.

[cheginit]

@editorialbot add @JannisHoch as reviewer

[editorialbot]

@JannisHoch added to the reviewers list!

[kellykochanski]

Short on time unfortunately! I don't think I can commit to giving a review up to JOSS's standard this month.

On Thu, May 2, 2024 at 5:23 AM Taher Chegini @.***> wrote:

Hi @rreinecke https://github.com/rreinecke, @JannisHoch https://github.com/JannisHoch, and @kellykochanski https://github.com/kellykochanski! Would you like to review this submission to the Journal for Open Source Software? Our reviews are checklist-driven and openly conducted on GitHub over a timeline of 4–6 weeks. Because the process is much more iterative and interactive than a traditional paper review, we would ask you to start within the next 2 weeks. Here are reviewer guidelines for reference: joss.readthedocs.io/en/latest/reviewer_guidelines.html

Thanks for your consideration.

— Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/6519#issuecomment-2090257229, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEAG2VTRSWFW3BTPXXZ6PBTZAIO47AVCNFSM6AAAAABFCC5Z4SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJQGI2TOMRSHE . You are receiving this because you were mentioned.Message ID: @.***>

[cheginit]

@kellykochanski Thanks for your prompt response and letting me know about your availability.

[cheginit]

Hi @dvalters! Would you like to review this submission to the Journal for Open Source Software? Our reviews are checklist-driven and openly conducted on GitHub over a timeline of 4–6 weeks. Because the process is much more iterative and interactive than a traditional paper review, we would ask you to start within the next 2 weeks. Here are reviewer guidelines for reference: joss.readthedocs.io/en/latest/reviewer_guidelines.html

Thanks for your consideration.

[dvalters]

Hi @cheginit, I would be happy to review the submission

[cheginit]

@dvalters, thanks for your prompt response and agreeing to review the submission. Shortly, I will create a new issue for this submission with instructions for starting the review.

[cheginit]

@editorialbot add @dvalters as reviewer

[editorialbot]

@dvalters added to the reviewers list!

[cheginit]

@editorialbot start review

[editorialbot]

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6752.