[PRE REVIEW]: ASGarD: Adaptive Sparse Grid Discretization

[editorialbot]

Submitting author: !--author-handle-->@quantumsteve<!--end-author-handle-- (Steven Hahn) Repository: https://github.com/project-asgard/asgard Branch with paper.md (empty if default branch): paper Version: v0.4.0 Editor: !--editor-->@jedbrown<!--end-editor-- Reviewers: @joglekara, @gnorman7 Managing EiC: Daniel S. Katz

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/99f223c2f35dfcc9afb0da7ea5d1aeb8"><img src="https://joss.theoj.org/papers/99f223c2f35dfcc9afb0da7ea5d1aeb8/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/99f223c2f35dfcc9afb0da7ea5d1aeb8/status.svg)](https://joss.theoj.org/papers/99f223c2f35dfcc9afb0da7ea5d1aeb8)

Author instructions

Thanks for submitting your paper to JOSS @quantumsteve. Currently, there isn't a JOSS editor assigned to your paper.

@quantumsteve if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

[editorialbot]

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.90  T=0.29 s (580.8 files/s, 215918.5 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C++                             68           4362           2094          27754
C/C++ Header                    75           3457           4071          18683
CMake                            8            162            249           1112
Markdown                         8             93              0            356
MATLAB                           4             58             21            211
YAML                             3              6             12            182
Bourne Shell                     1              4             38            113
TeX                              1              7              0             88
Python                           1             15              1             27
CSS                              1              4              3             20
-------------------------------------------------------------------------------
SUM:                           170           8168           6489          48546
-------------------------------------------------------------------------------

Commit count by author:

   497  Benjamin T. McDaniel
   439  Tyler McDaniel
   170  Graham Lopez
   165  Steven Hahn
   114  Cole Kendrick
    93  David Green
    46  Miroslav Stoyanov
    30  Coleman Kendrick
    30  elwasif
    20  none
    19  adam-mcdaniel
    16  Harry Hughes
    11  Stefan Schnake
     7  Hugo Brunie
     7  Mark Cianciosa
     7  Tim Younkin
     7  Timothy Younkin
     7  Tyler
     6  Eirik Endeve
     5  McDaniel, Benjamin T
     4  stefan-schnake
     3  David L Green
     3  Green, David L
     3  T McDaniel
     1  Brian Friesen
     1  Justin Burzachiello
     1  Lopez
     1  hl8

[editorialbot]

Paper file info:

📄 Wordcount for paper.md is 923

✅ The paper includes a Statement of need section

[editorialbot]

:warning: An error happened when generating the pdf. Problem with ORCID (0000-0000-0000-0000) for Hao Lau. Invalid ORCID.

[editorialbot]

License info:

✅ License found: MIT License (Valid open source OSI approved license)

[editorialbot]

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.jcp.2017.10.009 is OK
- 10.1063/1.4776712 is OK
- 10.1063/1.3167820 is OK

MISSING DOIs

- No DOI given, and none found for title: High-dimensional partial differential equations in...
- 10.1088/1361-6544/ac337f may be a valid DOI for title: Algorithms for Solving High Dimensional PDEs: From...
- No DOI given, and none found for title: Sparse-grid Discontinuous Galerkin Methods for the...

INVALID DOIs

- https://doi.org/10.1016/j.jco.2010.04.001 is INVALID because of 'https://doi.org/' prefix
- https://doi.org/10.1016/j.cpc.2020.107412 is INVALID because of 'https://doi.org/' prefix

[danielskatz]

👋 @quantumsteve - note that your paper does not compile. Please follow the example paper and note that you can click on the error above to find out more about it. (In this case, if a person doesn't have an ORCID, just remove that line from the paper header.) Please feel free to make changes to your .md file, then use the command @editorialbot generate pdf to make a new PDF. editorialbot commands need to be the first entry in a new comment.

[quantumsteve]

@editorialbot generate pdf

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[danielskatz]

@quantumsteve - your footnote 1 is a bit odd, as it has nothing to do with the text where it appears. This would be more appropriate as part of the acknowledgements, in my opinion.

[danielskatz]

👋 @jedbrown - would you be able to edit this submission?

[danielskatz]

@editorialbot invite @jedbrown as editor

[editorialbot]

Invitation to edit this submission sent!

[quantumsteve]

@editorialbot generate pdf

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[danielskatz]

👋 @jedbrown - just a ping in case you didn't see this invitation to edit ...

[jedbrown]

@editorialbot assign @jedbrown as editor

[editorialbot]

Assigned! @jedbrown is now the editor

[danielskatz]

👋 @jedbrown - are you able to start looking for reviewers for this one?

[jedbrown]

Sorry about my extended delay and thanks for your patience. This looks very interesting. Some quick items:

1. In the repo, you have paper.md and paper/paper.md. I think the former should be deleted to avoid confusion.
2. There is a [^1] (markdown footnote anchor) appearing in the first sentence. I think it was meant to be deleted in the commit that deleted the footnote content.
3. I'm about to invite a few reviewers, but you're also welcome to suggest. If you do so, please don't tag them here yet.

[jedbrown]

:wave: @dannys4 @joglekara @MikeHeiber :wave: Hi, would any of you be available to review this submission for JOSS?

[dannys4]

Unfortunately, I'm unable under the conflict of interest policy. Best of luck!

[quantumsteve]

@editorialbot generate pdf

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[quantumsteve]

@editorialbot generate pdf

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[joglekara]

👋 @dannys4 @joglekara @MikeHeiber 👋 Hi, would any of you be available to review this submission for JOSS?

yes happy to review if you still need

[jedbrown]

@editorialbot add @joglekara as reviewer

[editorialbot]

@joglekara added to the reviewers list!

[jedbrown]

@editorialbot add @gnorman7 as reviewer

[editorialbot]

@gnorman7 added to the reviewers list!

[jedbrown]

@editorialbot start review

[editorialbot]

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6766.