[REVIEW]: findSVI: an R package to calculate the Social Vulnerability Index at multiple geographical levels

editorialbot commented 6 months ago

Submitting author: !--author-handle-->@heli-xu@osorensen<!--end-editor-- Reviewers: @epiben, @zby0327, @nilabhrardas Archive: 10.5281/zenodo.12611878

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f488cf0b6f9f71740f6fde956059355b"><img src="https://joss.theoj.org/papers/f488cf0b6f9f71740f6fde956059355b/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f488cf0b6f9f71740f6fde956059355b/status.svg)](https://joss.theoj.org/papers/f488cf0b6f9f71740f6fde956059355b)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@epiben, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @osorensen know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @epiben

📝 Checklist for @zby0327

📝 Checklist for @nilabhrardas

osorensen commented 3 months ago

Thanks @heli-xu. I'll read through the paper now and let you know if I have any further suggested changes.

osorensen commented 3 months ago

@editorialbot generate pdf

editorialbot commented 3 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

osorensen commented 3 months ago

@heli-xu, I've now read through the manuscript, and have now further comments.

At this point could you:

Make a tagged release of your software, and list the version tag of the archived version here.
Archive the reviewed software in Zenodo or a similar service (e.g., figshare, an institutional repository)
Check the archival deposit (e.g., in Zenodo) has the correct metadata. This includes the title (should match the paper title) and author list (make sure the list is correct and people who only made a small fix are not on it). You may also add the authors' ORCID.
Please list the DOI of the archived version here.

I can then move forward with recommending acceptance of the submission.

ran-codes commented 3 months ago

@osorensen will 10.32614/CRAN.package.findSVI work?

(this is a DOI that was automatically generated via CRAN - the primary R package distirbutor)

osorensen commented 3 months ago

@ran-codes, the DOI has to be for a repository containing exactly the accepted version. I assume the CRAN DOI will refer to whatever is the most recent version of the package, and hence this is not sufficient. The easiest way is typically to make a Zenodo archive. You can see an example of a recent publication here.

heli-xu commented 3 months ago

@osorensen Thanks for clarifying!

The version tag: v0.1.3
DOI: 10.5281/zenodo.12611878

osorensen commented 3 months ago

@editorialbot set v0.1.3 as version

editorialbot commented 3 months ago

Done! version is now v0.1.3

osorensen commented 3 months ago

@editorialbot set 10.5281/zenodo.12611878 as archive

editorialbot commented 3 months ago

Done! archive is now 10.5281/zenodo.12611878

osorensen commented 3 months ago

@editorialbot recommend-accept

editorialbot commented 3 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 3 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.2202/1547-7355.1792 is OK
- 10.32614/CRAN.package.tidycensus is OK
- 10.1111/disa.12198 is OK
- 10.1038/s41591-021-01379-6 is OK
- 10.1016/j.jamcollsurg.2020.11.024 is OK
- 10.1016/j.surg.2021.06.001 is OK
- 10.1038/s41467-023-38084-6 is OK
- 10.1016/j.ijdrr.2020.101517 is OK
- 10.1016/j.jacadv.2023.100577 is OK
- 10.1016/j.cpcardiol.2022.101182 is OK
- 10.1161/CIRCULATIONAHA.121.054516 is OK
- 10.1016/j.hjdsi.2021.100611 is OK
- 10.15585/mmwr.mm7012e1 is OK
- 10.1016/j.amepre.2020.06.006 is OK
- 10.1007/s11606-020-05882-3 is OK
- 10.1111/puar.13264 is OK
- 10.7326/M20-3936 is OK
- 10.1136/bmjopen-2020-048086 is OK
- 10.1016/j.lana.2022.100220 is OK
- 10.1093/aje/kwac076 is OK
- 10.1016/j.socscimed.2022.115307 is OK
- 10.32614/CRAN.package.dplyr is OK
- 10.32614/CRAN.package.purrr is OK
- 10.32614/CRAN.package.stringr is OK
- 10.32614/CRAN.package.tidyr is OK
- 10.32614/CRAN.package.tidyselect is OK
- 10.32614/CRAN.package.rlang is OK
- 10.32614/CRAN.package.cli is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 3 months ago

:wave: @openjournals/sbcs-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5563, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

samhforbes commented 2 months ago

@editorialbot check references

editorialbot commented 2 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.2202/1547-7355.1792 is OK
- 10.32614/CRAN.package.tidycensus is OK
- 10.1111/disa.12198 is OK
- 10.1038/s41591-021-01379-6 is OK
- 10.1016/j.jamcollsurg.2020.11.024 is OK
- 10.1016/j.surg.2021.06.001 is OK
- 10.1038/s41467-023-38084-6 is OK
- 10.1016/j.ijdrr.2020.101517 is OK
- 10.1016/j.jacadv.2023.100577 is OK
- 10.1016/j.cpcardiol.2022.101182 is OK
- 10.1161/CIRCULATIONAHA.121.054516 is OK
- 10.1016/j.hjdsi.2021.100611 is OK
- 10.15585/mmwr.mm7012e1 is OK
- 10.1016/j.amepre.2020.06.006 is OK
- 10.1007/s11606-020-05882-3 is OK
- 10.1111/puar.13264 is OK
- 10.7326/M20-3936 is OK
- 10.1136/bmjopen-2020-048086 is OK
- 10.1016/j.lana.2022.100220 is OK
- 10.1093/aje/kwac076 is OK
- 10.1016/j.socscimed.2022.115307 is OK
- 10.32614/CRAN.package.dplyr is OK
- 10.32614/CRAN.package.purrr is OK
- 10.32614/CRAN.package.stringr is OK
- 10.32614/CRAN.package.tidyr is OK
- 10.32614/CRAN.package.tidyselect is OK
- 10.32614/CRAN.package.rlang is OK
- 10.32614/CRAN.package.cli is OK

MISSING DOIs

- None

INVALID DOIs

- None

samhforbes commented 2 months ago

@editorialbot generate pdf

editorialbot commented 2 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

samhforbes commented 2 months ago

@editorialbot accept

editorialbot commented 2 months ago

I'm sorry @samhforbes, I'm afraid I can't do that. That's something only eics are allowed to do.

samhforbes commented 2 months ago

Ooh tricky. I'll have to ping @arfon for a fix.

samhforbes commented 2 months ago

@editorialbot accept

editorialbot commented 2 months ago

I'm sorry @samhforbes, I'm afraid I can't do that. That's something only eics are allowed to do.

samhforbes commented 2 months ago

@editorialbot accept

editorialbot commented 2 months ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 2 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Xu given-names: Heli orcid: "https://orcid.org/0000-0002-9792-2727" - family-names: Li given-names: Ran orcid: "https://orcid.org/0000-0002-4699-4755" - family-names: Bilal given-names: Usama orcid: "https://orcid.org/0000-0002-9868-7773" contact: - family-names: Xu given-names: Heli orcid: "https://orcid.org/0000-0002-9792-2727" doi: 10.5281/zenodo.12611878 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Xu given-names: Heli orcid: "https://orcid.org/0000-0002-9792-2727" - family-names: Li given-names: Ran orcid: "https://orcid.org/0000-0002-4699-4755" - family-names: Bilal given-names: Usama orcid: "https://orcid.org/0000-0002-9868-7773" date-published: 2024-07-05 doi: 10.21105/joss.06525 issn: 2475-9066 issue: 99 journal: Journal of Open Source Software publisher: name: Open Journals start: 6525 title: "findSVI: an R package to calculate the Social Vulnerability Index at multiple geographical levels" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06525" volume: 9 title: "findSVI: an R package to calculate the Social Vulnerability Index at multiple geographical levels" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 2 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 2 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5576
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06525
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

samhforbes commented 2 months ago

Brilliant, well done @heli-xu. Thanks to @epiben, @zby0327 and @nilabhrardas for your reviews - it is always appreciated. And thank you @osorensen for editing!

editorialbot commented 2 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06525/status.svg)](https://doi.org/10.21105/joss.06525)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06525">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06525/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06525/status.svg
   :target: https://doi.org/10.21105/joss.06525

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

heli-xu commented 2 months ago

Thank you all for your help!

openjournals / joss-reviews