openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
722 stars 38 forks source link

[PRE REVIEW]: movement_primitives: Imitation Learning of Cartesian Motion with Movement Primitives #6530

Closed editorialbot closed 6 months ago

editorialbot commented 8 months ago

Submitting author: !--author-handle-->@AlexanderFabisch<!--end-author-handle-- (Alexander Fabisch) Repository: https://github.com/dfki-ric/movement_primitives/ Branch with paper.md (empty if default branch): joss Version: 0.7.0 Editor: !--editor-->@ymzayek<!--end-editor-- Reviewers: @ishaanamahajan, @gautam-sharma1 Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/4d348048fb0c9a972bbdd90965b23a79"><img src="https://joss.theoj.org/papers/4d348048fb0c9a972bbdd90965b23a79/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/4d348048fb0c9a972bbdd90965b23a79/status.svg)](https://joss.theoj.org/papers/4d348048fb0c9a972bbdd90965b23a79)

Author instructions

Thanks for submitting your paper to JOSS @AlexanderFabisch. Currently, there isn't a JOSS editor assigned to your paper.

@AlexanderFabisch if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 8 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 8 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.12 s (967.9 files/s, 143025.9 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          97           2563           3218           7056
XML                              9              3             18           2482
Markdown                         3            147              0            542
Cython                           1            179            286            422
TeX                              1             22              0            229
reStructuredText                 2             59             77             31
YAML                             1              4              2             28
DOS Batch                        1              8              1             26
make                             1              4              7              9
Dockerfile                       1              2              3              5
TOML                             1              0              0              3
-------------------------------------------------------------------------------
SUM:                           118           2991           3612          10833
-------------------------------------------------------------------------------

Commit count by author:

   662  Alexander Fabisch
    17  jklemm
     3  Marc Otto
     2  wood
     1  Baptiste Busch
     1  Enrico Eberhard
     1  mulo01
editorialbot commented 8 months ago

Paper file info:

📄 Wordcount for paper.md is 2195

✅ The paper includes a Statement of need section

editorialbot commented 8 months ago

License info:

🟡 License found: Other (Check here for OSI approval)

editorialbot commented 8 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/ROBOT.2002.1014739 is OK
- 10.1109/ROBOT.2009.5152385 is OK
- 10.1162/NECO_a_00393 is OK
- 10.1177/0278364912472380 is OK
- 10.1109/IROS.2013.6697172 is OK
- 10.1109/ICRA.2014.6907291 is OK
- 10.1007/s10514-016-9556-2 is OK
- 10.1007/s10514-017-9648-7 is OK
- 10.21105/joss.01159 is OK
- 10.1177/02783649231201196 is OK
- 10.21105/joss.01225 is OK
- 10.1177/1729881420913741 is OK
- 10.21105/joss.03054 is OK
- 10.26092/elib/1547 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1109/ICRA46639.2022.9811843 is OK
- 10.1109/MCSE.2010.118 is OK

MISSING DOIs

- No DOI given, and none found for title: Active Contextual Policy Search
- No DOI given, and none found for title: Probabilistic Movement Primitives
- No DOI given, and none found for title: Open3D: A Modern Library for 3D Data Processing
- No DOI given, and none found for title: PyBullet, a Python module for physics simulation f...

INVALID DOIs

- https://doi.org/10.1016/j.robot.2021.103779 is INVALID because of 'https://doi.org/' prefix
editorialbot commented 8 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

arfon commented 7 months ago

@AlexanderFabisch - thanks for your submission to JOSS. We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

crvernon commented 7 months ago

:wave: @ymzayek - would you be willing to edit this submission?

crvernon commented 7 months ago

@editorialbot invite @ymzayek as editor

editorialbot commented 7 months ago

Invitation to edit this submission sent!

ymzayek commented 7 months ago

@crvernon Yes I can take this one

crvernon commented 7 months ago

Great, thanks @ymzayek!

crvernon commented 7 months ago

@editorialbot assign @ymzayek as editor

editorialbot commented 7 months ago

Assigned! @ymzayek is now the editor

ymzayek commented 6 months ago

@editorialbot generate pdf

editorialbot commented 6 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

ymzayek commented 6 months ago

Hi @AlexanderFabisch, thank you for submitting your work to JOSS. I am the handling editor. Do you have any suggestion for reviewers? You can use the potential reviewers list provided at the top of this issue. I think people interested in robotics and Python would be a good fit. If you have suggestions, please provide a list of potential reviewers here but do not use the @ character to avoid receiving unwanted notifications. Thank you in advance.

ymzayek commented 6 months ago

@AlexanderFabisch it seems there are also some missing and invalid DOIs per this comment above. Would you be able to update these?

AlexanderFabisch commented 6 months ago

Hi @ymzayek,

thanks for handling this submission.

Do you have any suggestion for reviewers?

I looked for expertise in Python, robotics, and machine learning. None of the listed reviewers seems to be an expert in this specific field (which is rather small). So the following reviewers seem to be good candidates (without any preferences):

@AlexanderFabisch it seems there are also some missing and invalid DOIs per https://github.com/openjournals/joss-reviews/issues/6530#issuecomment-2015637695. Would you be able to update these?

I checked all of the references and they really seem to have no DOIs:

  • No DOI given, and none found for title: Active Contextual Policy Search

JMLR generally does not seem to have DOIs

  • No DOI given, and none found for title: Probabilistic Movement Primitives

Same for NeurIPS

  • No DOI given, and none found for title: Open3D: A Modern Library for 3D Data Processing

This was put on arxiv before they started to assign DOIs automatically

  • No DOI given, and none found for title: PyBullet, a Python module for physics simulation f...

This is not a real publication, but a software

The invalid DOI should already be fixed with the latest commit on the branch that contains the paper: https://github.com/dfki-ric/movement_primitives/pull/41/commits/89771fb3ce7667a6defe90deb4c7bff3dd41dd34 (PR).

ymzayek commented 6 months ago

@editorialbot check references

editorialbot commented 6 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/ROBOT.2002.1014739 is OK
- 10.1109/ROBOT.2009.5152385 is OK
- 10.1162/NECO_a_00393 is OK
- 10.1177/0278364912472380 is OK
- 10.1109/IROS.2013.6697172 is OK
- 10.1109/ICRA.2014.6907291 is OK
- 10.1007/s10514-016-9556-2 is OK
- 10.1007/s10514-017-9648-7 is OK
- 10.21105/joss.01159 is OK
- 10.1177/02783649231201196 is OK
- 10.21105/joss.01225 is OK
- 10.1177/1729881420913741 is OK
- 10.21105/joss.03054 is OK
- 10.1016/j.robot.2021.103779 is OK
- 10.26092/elib/1547 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1109/ICRA46639.2022.9811843 is OK
- 10.1109/MCSE.2010.118 is OK

MISSING DOIs

- No DOI given, and none found for title: Active Contextual Policy Search
- No DOI given, and none found for title: Probabilistic Movement Primitives
- No DOI given, and none found for title: Open3D: A Modern Library for 3D Data Processing
- No DOI given, and none found for title: PyBullet, a Python module for physics simulation f...

INVALID DOIs

- None
ymzayek commented 6 months ago

Hello @mhubii, @gautam-sharma1 and @ishaanamahajan,

Would you be willing to assist in reviewing this submission for JOSS (Journal of Open Source Software)?

JOSS publishes articles about open source research software. The submission I'd like you to review is titled:

movement_primitives: Imitation Learning of Cartesian Motion with Movement Primitives

You can find more information at the top of this Github issue (https://github.com/openjournals/joss-reviews/issues/6530).

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. If you have any questions please let me know.

This is the pre-review issue. After setting at least 2 reviewers we will start the review process in a separate thread. In that thread, there will be 23 check items for each single reviewer.

Thank you in advance!

ishaanamahajan commented 6 months ago

Hello @mhubii, @gautam-sharma1 and @ishaanamahajan,

Would you be willing to assist in reviewing this submission for JOSS (Journal of Open Source Software)?

JOSS publishes articles about open source research software. The submission I'd like you to review is titled:

movement_primitives: Imitation Learning of Cartesian Motion with Movement Primitives

You can find more information at the top of this Github issue (#6530).

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. If you have any questions please let me know.

This is the pre-review issue. After setting at least 2 reviewers we will start the review process in a separate thread. In that thread, there will be 23 check items for each single reviewer.

Thank you in advance!

Yes, I am happy to assist. Please let me know how I should move forward.

ggsharma commented 6 months ago

Hello Yasmin,

Yes, I would be willing to review this article.

Thanks, Gautam Sharma


Software Engineer Natick, MA

*+1 480-937-7152 | @. @.> | www.sharmagautam.com http://www.sharmagautam.com*

On Mon, Apr 29, 2024 at 3:30 AM Yasmin @.***> wrote:

Hello @mhubii https://github.com/mhubii, @gautam-sharma1 https://github.com/gautam-sharma1 and @ishaanamahajan https://github.com/ishaanamahajan,

Would you be willing to assist in reviewing this submission for JOSS (Journal of Open Source Software)?

JOSS publishes articles about open source research software. The submission I'd like you to review is titled:

6530 https://github.com/openjournals/joss-reviews/issues/6530

You can find more information at the top of this Github issue (#6530 https://github.com/openjournals/joss-reviews/issues/6530).

The review process at JOSS is unique: it takes place in a GitHub issue, is open, and author-reviewer-editor conversations are encouraged. If you have any questions please let me know.

This is the pre-review issue. After setting at least 2 reviewers we will start the review process in a separate thread. In that thread, there will be 23 check items for each single reviewer.

Thank you in advance!

— Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/6530#issuecomment-2082055483, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANFJZTYCGOTNGEEFKBJ2ARDY7XZJLAVCNFSM6AAAAABFDYILU6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBSGA2TKNBYGM . You are receiving this because you were mentioned.Message ID: @.***>

ymzayek commented 6 months ago

@editorialbot add @ishaanamahajan as reviewer

editorialbot commented 6 months ago

@ishaanamahajan added to the reviewers list!

ymzayek commented 6 months ago

@editorialbot add @gautam-sharma1 as reviewer

editorialbot commented 6 months ago

@gautam-sharma1 added to the reviewers list!

ymzayek commented 6 months ago

Thanks @gautam-sharma1 and @ishaanamahajan for agreeing to review this paper.

The review will start in a separate thread.

@AlexanderFabisch you can follow the review in the review issue that will be opened.

ymzayek commented 6 months ago

@editorialbot start review

editorialbot commented 6 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6695.