openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
708 stars 37 forks source link

[PRE REVIEW]: lightcurver: A Python pipeline for precise photometry of multiple-epoch wide-field images #6534

Closed editorialbot closed 3 months ago

editorialbot commented 5 months ago

Submitting author: !--author-handle-->@duxfrederic<!--end-author-handle-- (Frédéric Dux) Repository: https://github.com/duxfrederic/lightcurver Branch with paper.md (empty if default branch): paper Version: v1.0.3 Editor: !--editor-->@ivastar<!--end-editor-- Reviewers: @Onoddil, @robertfwilson Managing EiC: Dan Foreman-Mackey

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/4c19a3f804d62aafd0ca23f297fce6c9"><img src="https://joss.theoj.org/papers/4c19a3f804d62aafd0ca23f297fce6c9/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/4c19a3f804d62aafd0ca23f297fce6c9/status.svg)](https://joss.theoj.org/papers/4c19a3f804d62aafd0ca23f297fce6c9)

Author instructions

Thanks for submitting your paper to JOSS @duxfrederic. Currently, there isn't a JOSS editor assigned to your paper.

@duxfrederic if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 5 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 5 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.01 s (700.5 files/s, 74598.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
TeX                              1             23              0            253
CSV                              2              0              0            158
Markdown                         1             20              0             94
Python                           1             16              0             49
YAML                             1              1              4             21
-------------------------------------------------------------------------------
SUM:                             6             60              4            575
-------------------------------------------------------------------------------

Commit count by author:

   119  Frédéric Dux
editorialbot commented 5 months ago

Paper file info:

📄 Wordcount for paper.md is 1101

✅ The paper includes a Statement of need section

editorialbot commented 5 months ago

License info:

🔴 Failed to discover a valid open source license

dfm commented 5 months ago

@editorialbot set main as branch

editorialbot commented 5 months ago

Done! branch is now main

dfm commented 5 months ago

@editorialbot check repository

editorialbot commented 5 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.21105/joss.05340 is OK
- 10.48550/arXiv.2402.08725 is OK
- 10.1051/0004-6361/201629272 is OK
- 10.3847/25c2cfeb.d8909f28 is OK
- 10.1051/0004-6361/201322068 is OK
- 10.1088/0004-6256/139/5/1782 is OK
- 10.5281/ZENODO.1482018 is OK
- 10.1086/323894 is OK
- 10.21105/joss.00058 is OK
- 10.1051/aas:1996164 is OK
- 10.3847/1538-3881/aafc33 is OK
- 10.3847/1538-4357/ac7c74 is OK
- 10.1086/305187 is OK
- 10.1093/mnras/sty911 is OK
- 10.5281/ZENODO.5597138 is OK

MISSING DOIs

- No DOI given, and none found for title: legacypipe: Image reduction pipeline for the DESI ...
- No DOI given, and none found for title: COSMOULINE
- No DOI given, and none found for title: HDF: The hierarchical data format
- No DOI given, and none found for title: PyEphem: Astronomical Ephemeris for Python

INVALID DOIs

- None
editorialbot commented 5 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.07 s (877.7 files/s, 99736.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          42            731           1295           2747
Markdown                         5            121              0            483
SVG                              2              1             23            415
YAML                             7            134            274            295
TOML                             1              4              0             52
TeX                              1              0              1             15
-------------------------------------------------------------------------------
SUM:                            58            991           1593           4007
-------------------------------------------------------------------------------

Commit count by author:

   156  Frédéric Dux
editorialbot commented 5 months ago

Paper file info:

⚠️ Failed to find a paper file in https://github.com/duxfrederic/lightcurver (branch: main)

editorialbot commented 5 months ago

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

editorialbot commented 5 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

dfm commented 5 months ago

@editorialbot set paper as branch

editorialbot commented 5 months ago

Done! branch is now paper

dfm commented 5 months ago

@duxfrederic — Thanks for your submission! All the suitable JOSS editors are currently working at capacity so I'm going to "waitlist" this review until an editor with the relevant expertise is available to take it on. Thanks for your patience!

duxfrederic commented 5 months ago

Hi @dfm,

thanks a lot for looking into this so promptly. No worries, I understand you're dealing with a lot of submissions at the moment!

edit: Ah, I see that the queue of waitlisted papers in track 1 is steadily shrinking. So I looked into the list of potential reviewers, filtered by: area of expertise in python and astronomy, with the "photometry" keyword. I see two people who might be interested in reviewing this code base: tddesjardins and Onoddil.

edit2: looking at the "any original result should be reproducible by the reviewers" checklist item, I might remove the illustration plot from the paper as the data necessary for this are voluminous (around 50 GB) and will be private 3 more months. It would also take around 10-20 CPU hours to reduce them, not convenient (1h with a GPU). I can also provide the data reduced to a certain point by the pipeline, leaving only the last steps that the reviewers might want to run.

ivastar commented 4 months ago

@editorialbot assign @ivastar as editor

editorialbot commented 4 months ago

Assigned! @ivastar is now the editor

ivastar commented 4 months ago

@duxfrederic I am taking over as editor. I see you have already made some suggestions for reviewers. Please let me know if you have others. I'll send out e-mails to potential reviewers this week. The process of finding reviewers takes a couple of weeks usually. I'll keep you updated here. Let me know if you have questions.

ivastar commented 4 months ago

@editorialbot assign @onoddil as reviewer

editorialbot commented 4 months ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

ivastar commented 4 months ago

@editorialbot add @Onoddil as reviewer

editorialbot commented 4 months ago

@Onoddil added to the reviewers list!

ivastar commented 3 months ago

@editorialbot add @robertfwilson as reviewer

editorialbot commented 3 months ago

@robertfwilson added to the reviewers list!

ivastar commented 3 months ago

@editorialbot start review

editorialbot commented 3 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6775.