openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
701 stars 36 forks source link

[PRE REVIEW]: COBRAPRO: A MATLAB toolbox for Physics-based Battery Modeling and Co-simulation Parameter Optimization #6540

Closed editorialbot closed 3 months ago

editorialbot commented 5 months ago

Submitting author: !--author-handle-->@COBRAPROsimulator<!--end-author-handle-- (Sara Ha) Repository: https://github.com/COBRAPROsimulator/COBRAPRO Branch with paper.md (empty if default branch): Version: v1.0.0 Editor: !--editor-->@mbarzegary<!--end-editor-- Reviewers: @yuefan98, @BradyPlanden, @brosaplanella Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/54273964eb00e1e54308c19d54518891"><img src="https://joss.theoj.org/papers/54273964eb00e1e54308c19d54518891/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/54273964eb00e1e54308c19d54518891/status.svg)](https://joss.theoj.org/papers/54273964eb00e1e54308c19d54518891)

Author instructions

Thanks for submitting your paper to JOSS @COBRAPROsimulator. Currently, there isn't a JOSS editor assigned to your paper.

@COBRAPROsimulator if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 5 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 5 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.05 s (1136.1 files/s, 139515.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
MATLAB                          52            771           2787           2832
TeX                              1             20              0            217
Markdown                         2             36              0            191
YAML                             1              1              4             18
-------------------------------------------------------------------------------
SUM:                            56            828           2791           3258
-------------------------------------------------------------------------------

Commit count by author:

    83  COBRAPROsimulator
     1  CO-simulation BatteRy modeling for Accelerated PaRameter Optimization (COBRAPRO)
editorialbot commented 5 months ago

Paper file info:

πŸ“„ Wordcount for paper.md is 1097

βœ… The paper includes a Statement of need section

editorialbot commented 5 months ago

License info:

βœ… License found: MIT License (Valid open source OSI approved license)

editorialbot commented 5 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1149/1.2221597 is OK
- 10.1149/2.0301603jes is OK
- 10.1016/j.energy.2022.125966 is OK
- 10.1149/1945-7111/ab7bd7 is OK
- 10.1149/2.0551509jes is OK
- 10.1149/2.0321816jes is OK
- 10.1149/1945-7111/ab9050 is OK
- 10.5334/jors.309 is OK
- 10.1149/2.0291607jes is OK
- 10.1149/2.0171711jes is OK
- 10.1016/j.jpowsour.2016.12.083 is OK
- 10.4271/2023-01-5047 is OK
- 10.1149/1945-7111/ac201c is OK
- 10.1149/1945-7111/ac22c8 is OK
- 10.1016/j.compchemeng.2011.01.003 is OK
- 10.1016/j.compchemeng.2015.07.002 is OK
- 10.1149/1945-7111/ad1293 is OK

MISSING DOIs

- No DOI given, and none found for title: COMSOL Multiphysics&copy; v. 6.2
- No DOI given, and none found for title: Battery Design Module User’s Guide, COMSOL Multiph...
- No DOI given, and none found for title: fastDFN

INVALID DOIs

- None
editorialbot commented 5 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kyleniemeyer commented 5 months ago

Hello @COBRAPROsimulator, thanks for your interest in JOSS. Unfortunately, we do not have an editor in this area available to edit this submission at the moment, so I have to place this on our waitlist until someone frees up.

In the meantime, any reviewer suggestions would be welcome.

COBRAPROsimulator commented 5 months ago

@editorialbot commands

editorialbot commented 5 months ago

Hello @COBRAPROsimulator, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for branch
@editorialbot set joss-paper as branch

# Run checks and provide information on the repository and the paper file
@editorialbot check repository

# Check the references of the paper for missing DOIs
@editorialbot check references

# Generates the pdf paper
@editorialbot generate pdf

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Get a link to the complete list of reviewers
@editorialbot list reviewers
COBRAPROsimulator commented 4 months ago

@editorialbot generate pdf

editorialbot commented 4 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

COBRAPROsimulator commented 4 months ago

@editorialbot generate pdf

editorialbot commented 4 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

COBRAPROsimulator commented 4 months ago

Thank you @kyleniemeyer! Here is a list of potential reviewers who already agreed to review for JOSS:

Here is a list of potential reviewers who are not on the JOSS reviewer list:

COBRAPROsimulator commented 4 months ago

@kyleniemeyer, could you clarify if you mean that there is no JOSS editor suitable for COBRAPRO? Or do you mean that there is an appropriate JOSS editor for our code, but that they are not available at this moment (we noticed Rachel Kurchin could be a good match for our paper)?

If the latter, would you be able to give us an estimated time of when our paper would be assigned an editor?

Thank you, Sara

COBRAPROsimulator commented 4 months ago

@editorialbot generate pdf

editorialbot commented 4 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

COBRAPROsimulator commented 4 months ago

@editorialbot generate pdf

editorialbot commented 4 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

COBRAPROsimulator commented 4 months ago

@editorialbot generate preprint

editorialbot commented 4 months ago

:page_facing_up: Preprint file created: Find it here in the Artifacts list :page_facing_up:

kyleniemeyer commented 4 months ago

@COBRAPROsimulator I mean that we do not currently have one available - we limit the workload of our editors and how many simultaneous submissions they are handling. I can't quite predict how long it will take, because we have a queue of submissions.

kyleniemeyer commented 4 months ago

@editorialbot invite @mbarzegary as editor

editorialbot commented 4 months ago

Invitation to edit this submission sent!

mbarzegary commented 4 months ago

@editorialbot assign me as editor

editorialbot commented 4 months ago

Assigned! @mbarzegary is now the editor

mbarzegary commented 4 months ago

@editorialbot generate pdf

editorialbot commented 4 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

mbarzegary commented 4 months ago

Hi @BradyPlanden, @yuefan98, @DEARLIBS, @yaomz16, @EricaEgg πŸ‘‹ Considering your expertise, would any of you be willing to review this submission for JOSS? As you may know, we carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

Paper: https://raw.githubusercontent.com/openjournals/joss-papers/joss.06540/joss.06540/10.21105.joss.06540.pdf Software: https://github.com/COBRAPROsimulator/COBRAPRO

yuefan98 commented 4 months ago

Hi Mojtaba,

I would be happy to help with this. Is there a specific deadline for this review.

Best, Yuefan Ji

On Fri, Apr 26, 2024 at 9:16β€―AM Mojtaba Barzegari @.***> wrote:

Hi @BradyPlanden https://urldefense.com/v3/__https://github.com/BradyPlanden__;!!K-Hz7m0Vt54!gSLIWm0L-iXK9ojzwD7QGfsBHcS27mBcZJhLfCessOm_av95yTuiwxdwSJpwvIPj5NoVZok-pOtfJypIGIH1hgE$, @yuefan98 https://urldefense.com/v3/__https://github.com/yuefan98__;!!K-Hz7m0Vt54!gSLIWm0L-iXK9ojzwD7QGfsBHcS27mBcZJhLfCessOm_av95yTuiwxdwSJpwvIPj5NoVZok-pOtfJypIh5NTIec$, @DEARLIBS https://urldefense.com/v3/__https://github.com/DEARLIBS__;!!K-Hz7m0Vt54!gSLIWm0L-iXK9ojzwD7QGfsBHcS27mBcZJhLfCessOm_av95yTuiwxdwSJpwvIPj5NoVZok-pOtfJypItUSZlhI$, @yaomz16 https://urldefense.com/v3/__https://github.com/yaomz16__;!!K-Hz7m0Vt54!gSLIWm0L-iXK9ojzwD7QGfsBHcS27mBcZJhLfCessOm_av95yTuiwxdwSJpwvIPj5NoVZok-pOtfJypInY-1dSU$, @EricaEgg https://urldefense.com/v3/__https://github.com/EricaEgg__;!!K-Hz7m0Vt54!gSLIWm0L-iXK9ojzwD7QGfsBHcS27mBcZJhLfCessOm_av95yTuiwxdwSJpwvIPj5NoVZok-pOtfJypIg2nBJuQ$ πŸ‘‹ Considering your expertise, would any of you be willing to review this submission for JOSS? As you may know, we carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html https://urldefense.com/v3/__https://joss.readthedocs.io/en/latest/review_criteria.html__;!!K-Hz7m0Vt54!gSLIWm0L-iXK9ojzwD7QGfsBHcS27mBcZJhLfCessOm_av95yTuiwxdwSJpwvIPj5NoVZok-pOtfJypIW4T0LBc$

Paper: https://raw.githubusercontent.com/openjournals/joss-papers/joss.06540/joss.06540/10.21105.joss.06540.pdf https://urldefense.com/v3/__https://raw.githubusercontent.com/openjournals/joss-papers/joss.06540/joss.06540/10.21105.joss.06540.pdf__;!!K-Hz7m0Vt54!gSLIWm0L-iXK9ojzwD7QGfsBHcS27mBcZJhLfCessOm_av95yTuiwxdwSJpwvIPj5NoVZok-pOtfJypItq2Xry4$ Software: https://github.com/COBRAPROsimulator/COBRAPRO https://urldefense.com/v3/__https://github.com/COBRAPROsimulator/COBRAPRO__;!!K-Hz7m0Vt54!gSLIWm0L-iXK9ojzwD7QGfsBHcS27mBcZJhLfCessOm_av95yTuiwxdwSJpwvIPj5NoVZok-pOtfJypIVoxsMKs$

β€” Reply to this email directly, view it on GitHub https://urldefense.com/v3/__https://github.com/openjournals/joss-reviews/issues/6540*issuecomment-2079596061__;Iw!!K-Hz7m0Vt54!gSLIWm0L-iXK9ojzwD7QGfsBHcS27mBcZJhLfCessOm_av95yTuiwxdwSJpwvIPj5NoVZok-pOtfJypI7an4JUw$, or unsubscribe https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AXFQY7L5S72YXCBATTHQC33Y7JVV7AVCNFSM6AAAAABFIGAEKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZZGU4TMMBWGE__;!!K-Hz7m0Vt54!gSLIWm0L-iXK9ojzwD7QGfsBHcS27mBcZJhLfCessOm_av95yTuiwxdwSJpwvIPj5NoVZok-pOtfJypIC3sfn4M$ . You are receiving this because you were mentioned.Message ID: @.***>

yaomz16 commented 4 months ago

Hi Mojtaba,

Sorry I cannot review this paper for now, as I am extremely busy these days.

Thanks,

Archie (yaomz16)

On Fri, Apr 26, 2024 at 11:16β€―AM Mojtaba Barzegari @.***> wrote:

Hi @BradyPlanden https://github.com/BradyPlanden, @yuefan98 https://github.com/yuefan98, @DEARLIBS https://github.com/DEARLIBS, @yaomz16 https://github.com/yaomz16, @EricaEgg https://github.com/EricaEgg πŸ‘‹ Considering your expertise, would any of you be willing to review this submission for JOSS? As you may know, we carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

Paper: https://raw.githubusercontent.com/openjournals/joss-papers/joss.06540/joss.06540/10.21105.joss.06540.pdf Software: https://github.com/COBRAPROsimulator/COBRAPRO

β€” Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/6540#issuecomment-2079596061, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH2KLTA5BXLCR4DWTAINW3TY7JVV7AVCNFSM6AAAAABFIGAEKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZZGU4TMMBWGE . You are receiving this because you were mentioned.Message ID: @.***>

mbarzegary commented 4 months ago

@yuefan98 we aim for reviews to be completed within about 2-4 weeks after the start of the revision process.

mbarzegary commented 4 months ago

Hi @TomTranter πŸ‘‹ Do you have time for reviewing another battery modeling work for JOSS?

Paper: https://raw.githubusercontent.com/openjournals/joss-papers/joss.06540/joss.06540/10.21105.joss.06540.pdf Software: https://github.com/COBRAPROsimulator/COBRAPRO

TomTranter commented 4 months ago

Hi @mbarzegary unfortunately not

BradyPlanden commented 4 months ago

@mbarzegary Happy to review this.

mbarzegary commented 4 months ago

@editorialbot add @yuefan98 as reviewer

editorialbot commented 4 months ago

@yuefan98 added to the reviewers list!

mbarzegary commented 4 months ago

@editorialbot add @BradyPlanden as reviewer

editorialbot commented 4 months ago

@BradyPlanden added to the reviewers list!

mbarzegary commented 4 months ago

Hi @ma-sadeghi πŸ‘‹ Do you have time for reviewing another battery modeling work for JOSS?

Paper: https://raw.githubusercontent.com/openjournals/joss-papers/joss.06540/joss.06540/10.21105.joss.06540.pdf Software: https://github.com/COBRAPROsimulator/COBRAPRO

mbarzegary commented 3 months ago

Hi @jepegit πŸ‘‹ Since you have recently published your software, would you be willing to review a battery modeling work for JOSS?

Paper: https://raw.githubusercontent.com/openjournals/joss-papers/joss.06540/joss.06540/10.21105.joss.06540.pdf Software: https://github.com/COBRAPROsimulator/COBRAPRO

mbarzegary commented 3 months ago

Hi @jtock, @joshuaeh, @mdmurbach, @olejandro, @mfleschutz πŸ‘‹ Considering your expertise, would any of you be willing to review this submission for JOSS? As you may know, we carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

Paper: https://raw.githubusercontent.com/openjournals/joss-papers/joss.06540/joss.06540/10.21105.joss.06540.pdf Software: https://github.com/COBRAPROsimulator/COBRAPRO

mfleschutz commented 3 months ago

Hi @mbarzegary,

Thank you for considering me for this review. Unfortunately, I am unable to commit to reviewing this submission for JOSS at this time.

Best regards

joshuaeh commented 3 months ago

Hi @mbarzegary,

I appreciate the vote of confidence, I wouldn't be able to give meaningful insights in the area unfortunately.

JH

TomTranter commented 3 months ago

I suggest @brosaplanella

TomTranter commented 3 months ago

Also @DrSOKane

mbarzegary commented 3 months ago

Thanks @TomTranter

mbarzegary commented 3 months ago

Hi @brosaplanella and @DrSOKane πŸ‘‹ Considering your expertise, would any of you be willing to review this battery modeling work for JOSS? As you may know, we carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

Paper: https://raw.githubusercontent.com/openjournals/joss-papers/joss.06540/joss.06540/10.21105.joss.06540.pdf Software: https://github.com/COBRAPROsimulator/COBRAPRO

brosaplanella commented 3 months ago

Hi! I am at full capacity ATM. The earliest I can guarantee a review is the 5th of July. If that works, please assign me to it.

mbarzegary commented 3 months ago

@brosaplanella thanks. As you know, we usually aim to finish the first review round in 4 weeks, but I think it's worth to prolong it a bit to have your review as well. I assign you as the reviewer and you can do it early July.