openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
720 stars 38 forks source link

[PRE REVIEW]: pySymmPol: Symmetric Polynomials #6544

Closed editorialbot closed 5 months ago

editorialbot commented 7 months ago

Submitting author: !--author-handle-->@thraraujo<!--end-author-handle-- (Thiago Rocha Araujo) Repository: https://github.com/thraraujo/pysymmpol Branch with paper.md (empty if default branch): paper Version: v0.1.1 Editor: !--editor-->@phibeck<!--end-editor-- Reviewers: @eliotwrobson, @AnnikaStein Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/f395fc3a9e1d482af1e0fc0d1eb17d2e"><img src="https://joss.theoj.org/papers/f395fc3a9e1d482af1e0fc0d1eb17d2e/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/f395fc3a9e1d482af1e0fc0d1eb17d2e/status.svg)](https://joss.theoj.org/papers/f395fc3a9e1d482af1e0fc0d1eb17d2e)

Author instructions

Thanks for submitting your paper to JOSS @thraraujo. Currently, there isn't a JOSS editor assigned to your paper.

@thraraujo if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 7 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 7 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.09 s (1475.7 files/s, 270994.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
HTML                            50           1607            150          10380
SVG                              3              0              0           2689
CSS                              6            223             57           1014
JavaScript                      12            131            221            880
Python                          22            411            422            800
Markdown                         5             84              0            422
TeX                              2             73             10            364
Jupyter Notebook                10              0           3371            277
reStructuredText                17            124            214            172
YAML                             2              7             12             51
DOS Batch                        1              8              1             26
TOML                             1              4              0             16
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                           132           2676           4465          17100
-------------------------------------------------------------------------------

Commit count by author:

    33  thraraujo
     5  Thiago Araujo
editorialbot commented 7 months ago

Paper file info:

📄 Wordcount for paper.tex is 1452

🔴 Failed to discover a Statement of need section in paper

editorialbot commented 7 months ago

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

editorialbot commented 7 months ago

:warning: An error happened when generating the pdf.

kyleniemeyer commented 7 months ago

@editorialbot check repository from branch main

editorialbot commented 7 months ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

kyleniemeyer commented 7 months ago

@openjournals/dev any idea why the paper build failed? The error seems to be

/opt/hostedtoolcache/Ruby/3.3.0/x64/lib/ruby/3.3.0/psych.rb:670:in `initialize': No such file or directory @ rb_sysopen - tmp/39b8d3331d64c1944c50eb44318968f3/paper/arxiv/paper.yml (Errno::ENOENT)
xuanxu commented 7 months ago

I think the bot is trying to compile the paper using the paper.tex file as source, instead of using the paper.md, probably because the order they are listed when scanning the repository. Renaming the paper.tex file should make it work.

thraraujo commented 7 months ago

Thanks, I have renamed the tex file.

kyleniemeyer commented 7 months ago

@editorialbot generate pdf

editorialbot commented 7 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kyleniemeyer commented 6 months ago

@thraraujo unfortunately, we do not have an editor in this area available to handle your submission, so I have to put this on our waitlist until someone frees up.

thraraujo commented 6 months ago

@kyleniemeyer, thanks... let's wait.

phibeck commented 6 months ago

Hi @kyleniemeyer I can take this one

phibeck commented 6 months ago

@editorialbot assign @phibeck as editor

editorialbot commented 6 months ago

Assigned! @phibeck is now the editor

phibeck commented 6 months ago

@editorialbot check references

editorialbot commented 6 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-1-4612-0979-9 is OK
- 10.1017/CBO9780511628832 is OK

MISSING DOIs

- No DOI given, and none found for title: Generating All Partitions: A Comparison Of Two Enc...
- No DOI given, and none found for title: Symmetric Functions and Hall Polynomials
- No DOI given, and none found for title: Introduction to Classical Integrable Systems
- No DOI given, and none found for title: Chern-Simons theory, matrix models, and topologica...
- No DOI given, and none found for title: Free fermions in classical and quantum integrable ...

INVALID DOIs

- None
phibeck commented 6 months ago

Hi @thraraujo, thanks for your submission. I'll be looking for reviewers next. A few things you can do to speed up the review process:

thraraujo commented 6 months ago

Hi @phibeck, thanks for pushing it forward.

thraraujo commented 6 months ago

@editorialbot generate pdf

editorialbot commented 6 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

phibeck commented 6 months ago

@editorialbot check references

editorialbot commented 6 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/arXiv.0909.2331 is OK
- 10.1093/oso/9780198534891.001.0001 is OK
- 10.1007/978-1-4612-0979-9 is OK
- 10.1017/CBO9780511535024 is OK
- 10.1017/CBO9780511628832 is OK
- 10.1093/acprof:oso/9780198568490.001.0001 is OK
- 10.48550/arXiv.1110.6703 is OK

MISSING DOIs

- None

INVALID DOIs

- None
phibeck commented 6 months ago

:wave: @@szabo137, @HugoStrand & @eliotwrobson, would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

eliotwrobson commented 6 months ago

Happy to! I've wanted to teach myself a little bit about schur polynomials for a while and this would be a great excuse 😁

phibeck commented 6 months ago

That's great, thank you!

phibeck commented 6 months ago

@editorialbot add @eliotwrobson as reviewer

editorialbot commented 6 months ago

@eliotwrobson added to the reviewers list!

phibeck commented 5 months ago

:wave: @AnnikaStein, @Jpata & @jjerphan, would any of you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html

jjerphan commented 5 months ago

Hi @phibeck,

Thank you for proposing.

I would like to, but I have enough commitments at the moment; hence I think it is preferable that I let someone else review.

thraraujo commented 5 months ago

Hi @phibeck , hope you're doing well

here are 5 other names: sbacchio , benjaminbolling, zafeirakopoulos, upsj, DamynChipman

jpata commented 5 months ago

unfortunately it is out of my area of expertise, so I have to decline reviewing.

AnnikaStein commented 5 months ago

Hi @phibeck happy to help with reviewing, I believe my interests fit well with the topic.

phibeck commented 5 months ago

Thank you @AnnikaStein for agreeing to review, and thanks for letting me know you, @jjerphan and @jpata. Thank you @thraraujo for additional suggestions, I think we'll start the review process at this point.

phibeck commented 5 months ago

@editorialbot add @AnnikaStein as reviewer

editorialbot commented 5 months ago

@AnnikaStein added to the reviewers list!

phibeck commented 5 months ago

@editorialbot start review

editorialbot commented 5 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6724.