openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
707 stars 37 forks source link

[REVIEW]: BoARIO: A Python package implementing the ARIO indirect economic cost model #6547

Closed editorialbot closed 3 months ago

editorialbot commented 5 months ago

Submitting author: !--author-handle-->@spjuhel<!--end-author-handle-- (Samuel Juhel) Repository: https://github.com/spjuhel/BoARIO Branch with paper.md (empty if default branch): main Version: v0.5.10 Editor: !--editor-->@crvernon<!--end-editor-- Reviewers: @mwt, @potterzot Archive: 10.5281/zenodo.11580697

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/71386aa01a292ecff8bafe273b077701"><img src="https://joss.theoj.org/papers/71386aa01a292ecff8bafe273b077701/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/71386aa01a292ecff8bafe273b077701/status.svg)](https://joss.theoj.org/papers/71386aa01a292ecff8bafe273b077701)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@mwt & @potterzot, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @crvernon know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @mwt

📝 Checklist for @potterzot

crvernon commented 3 months ago

@editorialbot set 10.5281/zenodo.11580697 as archive

editorialbot commented 3 months ago

Done! archive is now 10.5281/zenodo.11580697

crvernon commented 3 months ago

🔍 checking out the following:

crvernon commented 3 months ago

@editorialbot recommend-accept

editorialbot commented 3 months ago
Attempting dry run of processing paper acceptance...
editorialbot commented 3 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1111/jiec.12715 is OK
- 10.1021/es300171x is OK
- 10.2139/ssrn.4101276 is OK
- 10.1093/reep/rez004 is OK
- 10.5334/jors.251 is OK
- 10.1029/2020ef001616 is OK
- 10.5281/zenodo.8383171 is OK
- 10.1038/s41562-020-0896-8 is OK
- 10.1007/s10584-010-9979-2 is OK
- 10.1016/j.jedc.2011.10.001 is OK
- 10.1007/s10584-010-9978-3 is OK
- 10.1111/j.1539-6924.2008.01046.x is OK
- 10.1111/risa.12090 is OK
- 10.1007/s12665-011-1078-9 is OK
- 10.1007/s11069-013-0788-6 is OK
- 10.1111/risa.12300 is OK
- 10.1029/2018ef000839 is OK
- 10.1038/s41893-020-00646-7 is OK
- 10.1080/19475705.2018.1489312 is OK
- 10.31223/x5qd6b is OK
- 10.1038/s41558-018-0173-2 is OK
- 10.1088/1748-9326/ab3306 is OK
- 10.1093/bioinformatics/bts480 is OK
- 10.2139/ssrn.3285818 is OK
- 10.1080/09535314.2016.1232701 is OK
- 10.1038/s41893-020-00649-4 is OK
- 10.1016/j.jedc.2017.08.001 is OK
- 10.1038/s41893-020-0523-8 is OK
- 10.1007/s10584-018-2293-0 is OK

MISSING DOIs

- No DOI given, and none found for title: OECD Inter-Country Input-Output Database
- No DOI given, and none found for title: NumPy

INVALID DOIs

- None
editorialbot commented 3 months ago

:wave: @openjournals/sbcs-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5488, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

crvernon commented 3 months ago

@editorialbot accept

editorialbot commented 3 months ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 3 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Juhel given-names: Samuel orcid: "https://orcid.org/0000-0001-8801-3890" doi: 10.5281/zenodo.11580697 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Juhel given-names: Samuel orcid: "https://orcid.org/0000-0001-8801-3890" date-published: 2024-06-11 doi: 10.21105/joss.06547 issn: 2475-9066 issue: 98 journal: Journal of Open Source Software publisher: name: Open Journals start: 6547 title: "BoARIO: A Python package implementing the ARIO indirect economic cost model" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06547" volume: 9 title: "BoARIO: A Python package implementing the ARIO indirect economic cost model" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 3 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 3 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5489
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06547
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

crvernon commented 3 months ago

🥳 Congratulations on your new publication @spjuhel! Many thanks to @mwt and @potterzot for your time, hard work, and expertise!! JOSS wouldn't be able to function nor succeed without your efforts.

Please consider becoming a reviewer for JOSS if you are not already: https://reviewers.joss.theoj.org/join

editorialbot commented 3 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06547/status.svg)](https://doi.org/10.21105/joss.06547)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06547">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06547/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06547/status.svg
   :target: https://doi.org/10.21105/joss.06547

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: