openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
707 stars 37 forks source link

[PRE REVIEW]: Doppler dynamics in X-ray stellar binary systems #6551

Closed editorialbot closed 5 months ago

editorialbot commented 5 months ago

Submitting author: !--author-handle-->@xragua<!--end-author-handle-- (Graciela Sanjurjo Ferrín) Repository: https://github.com/xragua/Doppler-Dynamics-in-X-RAY-stellar-binary-systems Branch with paper.md (empty if default branch): Version: v1.0.0 Editor: Pending Reviewers: Pending Managing EiC: Dan Foreman-Mackey

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/b2b5dec029afbe60fb52bfac34707e42"><img src="https://joss.theoj.org/papers/b2b5dec029afbe60fb52bfac34707e42/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/b2b5dec029afbe60fb52bfac34707e42/status.svg)](https://joss.theoj.org/papers/b2b5dec029afbe60fb52bfac34707e42)

Author instructions

Thanks for submitting your paper to JOSS @xragua. Currently, there isn't a JOSS editor assigned to your paper.

@xragua if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 5 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 5 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.02 s (411.9 files/s, 157758.8 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                           2            487            352            875
Jupyter Notebook                 2              0            700            271
Markdown                         2             74              0            206
TeX                              1             11              0             65
YAML                             1              1              4             18
-------------------------------------------------------------------------------
SUM:                             8            573           1056           1435
-------------------------------------------------------------------------------

Commit count by author:

    57  xragua
    15  LAEX
editorialbot commented 5 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1162/EVCO_r_00180 is OK
- 10.1093/mnras/staa3953 is OK
- 10.1117/12.2232432 is OK
- 10.1038/s41592-019-0686-2 is OK

MISSING DOIs

- No DOI given, and none found for title: PySwarms: A Python-Based Swarm Optimization Librar...

INVALID DOIs

- None
editorialbot commented 5 months ago

Paper file info:

📄 Wordcount for paper.md is 1092

✅ The paper includes a Statement of need section

editorialbot commented 5 months ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 5 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

dfm commented 5 months ago

@editorialbot query scope

@xragua — Thanks for your submission! Given the small size and short history of this code base, I have submitted this pre-review for editorial review with respect to the substantial scholarly effort criterion. This usually takes a week or two and I'll report back here as soon as I hear back from the rest of the editorial board.

editorialbot commented 5 months ago

Submission flagged for editorial review.

xragua commented 5 months ago

@dfm @editorialbot Dear @dfm, thank you so much for giving us the opportunity to publish, I hope for a positive editorial review.

I just wanted to mention that even when our GitHub is very recent, I have been working in Doppler in X-Ray binary systems for a while, in fact, we used an earlier version of one of the functions on this package in a MNRAS publication back in 2021.

On the other hand, I have reduced the number of functions of my package to make its content more consistent, but if you think it might help, I can recover a couple of them or create new ones that I have in mind, and thus, add some size to the package.

Thank you so much in advance and have a good weekend, we will be waiting the editorial response,

Graciela

dfm commented 5 months ago

@xragua — Thank you for this added context and for your patience. The editorial team has decided that this submission is not suitable for JOSS at this point. It doesn't satisfy the substantial scholarly effort criterion, and it isn't sufficiently well packaged, tested, and documented to be up to JOSS standards. We would welcome re-submission when the code matures and reaches a more reusable state. Thanks again for your submission and understanding!

dfm commented 5 months ago

@editorialbot reject

editorialbot commented 5 months ago

Paper rejected.

xragua commented 5 months ago

@dfm Thank you for the feedback, We will improve the areas suggested and hopefully, try back eventually, Cheers.