[REVIEW]: InvertibleNetworks.jl: A Julia package for scalable normalizing flows

editorialbot commented 7 months ago

Submitting author: !--author-handle-->@rafaelorozco@drvinceknight<!--end-editor-- Reviewers: @aurorarossi, @Nando-Hegemann Archive: 10.5281/zenodo.12810006

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/b1e8bc48e52694bcc9e4fb87634fc39f"><img src="https://joss.theoj.org/papers/b1e8bc48e52694bcc9e4fb87634fc39f/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/b1e8bc48e52694bcc9e4fb87634fc39f/status.svg)](https://joss.theoj.org/papers/b1e8bc48e52694bcc9e4fb87634fc39f)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@aurorarossi & @Nando-Hegemann, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @drvinceknight know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @aurorarossi

📝 Checklist for @Nando-Hegemann

rafaelorozco commented 3 months ago

@danielskatz Okay I confirm that I added the proper acknowledgements.

danielskatz commented 3 months ago

@editorialbot recommend-accept

editorialbot commented 3 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 3 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1190/image2022-3750561.1 is OK
- 10.52591/lxai202312101 is OK
- 10.23952/jano.4.2022.2.05 is OK
- 10.1137/141000671 is OK
- 10.48550/arXiv.1912.12137 is OK
- 10.48550/arXiv.2204.11850 is OK
- 10.1109/tnnls.2020.3042395 is OK
- 10.48550/arXiv.1907.07587 is OK
- 10.5281/zenodo.10100624 is OK
- 10.5281/zenodo.4296287 is OK
- 10.48550/arXiv.1912.01703 is OK
- 10.1007/bf01456927 is OK
- 10.48550/arXiv.1410.8516 is OK
- 10.48550/arXiv.1605.08803 is OK
- 10.1007/s40687-022-00343-1 is OK
- 10.1609/aaai.v35i9.16997 is OK
- 10.21105/joss.05361 is OK
- 10.1190/segam2021-3583705.1 is OK
- 10.1190/segam2020-3428150.1 is OK
- 10.48550/arXiv.2101.03709 is OK
- 10.48550/arXiv.2203.15881 is OK
- 10.48550/arXiv.2305.08733 is OK
- 10.1190/tle42070474.1 is OK
- 10.1190/geo2022-0472.1 is OK
- 10.1186/s40323-023-00252-0 is OK
- 10.48550/arXiv.2311.00290 is OK
- 10.48550/arXiv.2303.03478 is OK
- 10.1117/12.2651691 is OK
- 10.1109/tci.2023.3248949 is OK

MISSING DOIs

- No DOI given, and none found for title: NormalizingFlows.jl
- No DOI given, and none found for title: Bijectors. jl: Flexible transformations for probab...
- No DOI given, and none found for title: Framework for Easily Invertible Architectures (FrE...
- No DOI given, and none found for title: Glow: Generative flow with invertible 1x1 convolut...
- No DOI given, and none found for title: Photoacoustic imaging with conditional priors from...

INVALID DOIs

- None

editorialbot commented 3 months ago

:wave: @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5702, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

danielskatz commented 3 months ago

@editorialbot accept

editorialbot commented 3 months ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 3 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Orozco given-names: Rafael - family-names: Witte given-names: Philipp - family-names: Louboutin given-names: Mathias - family-names: Siahkoohi given-names: Ali - family-names: Rizzuti given-names: Gabrio - family-names: Peters given-names: Bas - family-names: Herrmann given-names: Felix J. doi: 10.5281/zenodo.12810006 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Orozco given-names: Rafael - family-names: Witte given-names: Philipp - family-names: Louboutin given-names: Mathias - family-names: Siahkoohi given-names: Ali - family-names: Rizzuti given-names: Gabrio - family-names: Peters given-names: Bas - family-names: Herrmann given-names: Felix J. date-published: 2024-07-30 doi: 10.21105/joss.06554 issn: 2475-9066 issue: 99 journal: Journal of Open Source Software publisher: name: Open Journals start: 6554 title: "InvertibleNetworks.jl: A Julia package for scalable normalizing flows" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06554" volume: 9 title: "InvertibleNetworks.jl: A Julia package for scalable normalizing flows" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 3 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 3 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5703
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06554
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

danielskatz commented 3 months ago

Congratulations to @rafaelorozco (Rafael Orozco) and co-authors on your publication!!

And thanks to @aurorarossi and @Nando-Hegemann for reviewing, and to @drvinceknight for editing! JOSS depends on volunteers and couldn't succeed without you

editorialbot commented 3 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06554/status.svg)](https://doi.org/10.21105/joss.06554)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06554">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06554/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06554/status.svg
   :target: https://doi.org/10.21105/joss.06554

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

openjournals / joss-reviews