[REVIEW]: Delta-Rice: A HDF5 Compression Plugin optimized for Digitized Detector Data

editorialbot commented 6 months ago

Submitting author: !--author-handle-->@david-mathews-1994@emdupre<!--end-editor-- Reviewers: @macrocosme, @DanNixon, @dineshchitlangia Archive: 10.5281/zenodo.11490673

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/deb15ad629d7261988ec28b0e79d849a"><img src="https://joss.theoj.org/papers/deb15ad629d7261988ec28b0e79d849a/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/deb15ad629d7261988ec28b0e79d849a/status.svg)](https://joss.theoj.org/papers/deb15ad629d7261988ec28b0e79d849a)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@macrocosme & @DanNixon & @dineshchitlangia, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @emdupre know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @DanNixon

📝 Checklist for @dineshchitlangia

📝 Checklist for @macrocosme

david-mathews-1994 commented 4 months ago

@emdupre Thanks for the update for the captions, that's been merged now! Also the affiliations now include additional address information.

emdupre commented 4 months ago

@editorialbot generate pdf

editorialbot commented 4 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

emdupre commented 4 months ago

@editorialbot set 10.5281/zenodo.11490673 as archive

editorialbot commented 4 months ago

Done! archive is now 10.5281/zenodo.11490673

emdupre commented 4 months ago

@editorialbot set v1.0.0 as version

editorialbot commented 4 months ago

Done! version is now v1.0.0

emdupre commented 4 months ago

Thank you for those updates !

The remaining steps that I see :

There is a remaining checklist item for formatting the capitalization in the references
There is a remaining post-review author step to make sure that the title and author list (including ORCIDs) in the archive match those in the JOSS paper. Currently, the title, author listing, and license are all non-overlapping with the code repository. These can be updated by editting the metadata for the Zenodo archive, as discussed here : https://help.zenodo.org/docs/deposit/manage-records/#edit This should not require creating a new version, but please let me know if you hit any difficulties !

david-mathews-1994 commented 4 months ago

@emdupre The capitalization in the references has now been fixed. I also went through and updated the Zenodo archive to match the author list and verified the ORCIDs are all matching now as well

emdupre commented 4 months ago

@editorialbot generate pdf

editorialbot commented 4 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

emdupre commented 4 months ago

Thank you, @david-mathews-1994 ! The archive and software paper now look correct to me.

I'm now happy to recommend Delta-Rice to the EiC team for publication in JOSS ✨🚀

Thank you, too, to @macrocosme, @DanNixon, and @dineshchitlangia for your reviews ! JOSS works because of your work 💐

emdupre commented 4 months ago

@editorialbot recommend-accept

editorialbot commented 4 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 4 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.nima.2020.163961 is OK
- 10.1109/TIT.1966.1053907 is OK
- 10.1109/TCOM.1971.1090789 is OK
- 10.1016/j.ascom.2015.07.002 is OK
- 10.11578/dc.20180330.1 is OK
- 10.13023/etd.2022.446 is OK
- 10.1051/epjconf/201921904002 is OK
- 10.1109/99.660313 is OK
- 10.1088/1748-0221/14/11/P11017 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 4 months ago

:wave: @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5527, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

danielskatz commented 4 months ago

@david-mathews-1994 - As track editor, I'll now proofread this and let you know if anything else is needed from you

danielskatz commented 4 months ago

@david-mathews-1994 - the few needed changes I found are in https://github.com/david-mathews-1994/deltarice/pull/9

Please merge this, or let me know what you disagree with, and then we can finish the acceptance and publication of this work.

david-mathews-1994 commented 4 months ago

@danielskatz Those changes should be merged and taken care of now, thank you!

danielskatz commented 4 months ago

@editorialbot recommend-accept

editorialbot commented 4 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 4 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1016/j.nima.2020.163961 is OK
- 10.1109/TIT.1966.1053907 is OK
- 10.1109/TCOM.1971.1090789 is OK
- 10.1016/j.ascom.2015.07.002 is OK
- 10.11578/dc.20180330.1 is OK
- 10.13023/etd.2022.446 is OK
- 10.1051/epjconf/201921904002 is OK
- 10.1109/99.660313 is OK
- 10.1088/1748-0221/14/11/P11017 is OK

MISSING DOIs

- None

INVALID DOIs

- None

editorialbot commented 4 months ago

:wave: @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5528, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

danielskatz commented 4 months ago

@editorialbot accept

editorialbot commented 4 months ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 4 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Mathews given-names: D. G. orcid: "https://orcid.org/0000-0002-4897-4379" - family-names: Crawford given-names: C. B. orcid: "https://orcid.org/0000-0002-1932-4334" - family-names: Baeßler given-names: S. orcid: "https://orcid.org/0000-0001-7732-9873" - family-names: Birge given-names: N. orcid: "https://orcid.org/0000-0003-1894-5494" - family-names: Broussard given-names: L. J. orcid: "https://orcid.org/0000-0001-9182-2808" - family-names: Gonzalez given-names: F. orcid: "https://orcid.org/0000-0002-5954-4155" - family-names: Hayen given-names: L. orcid: "https://orcid.org/0000-0002-9471-0964" - family-names: Jezghani given-names: A. orcid: "https://orcid.org/0000-0002-4302-4227" - family-names: Li given-names: H. orcid: "https://orcid.org/0000-0003-3726-9663" - family-names: Mammei given-names: R. orcid: "https://orcid.org/0009-0005-3481-4832" - family-names: Mendelsohn given-names: A. orcid: "https://orcid.org/0000-0002-4847-2133" - family-names: Randall given-names: G. orcid: "https://orcid.org/0000-0002-9713-8465" - family-names: Riley given-names: G. V. orcid: "https://orcid.org/0000-0001-7323-8448" - family-names: Schaper given-names: D. C. orcid: "https://orcid.org/0000-0002-6219-650X" contact: - family-names: Mathews given-names: D. G. orcid: "https://orcid.org/0000-0002-4897-4379" doi: 10.5281/zenodo.11490673 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Mathews given-names: D. G. orcid: "https://orcid.org/0000-0002-4897-4379" - family-names: Crawford given-names: C. B. orcid: "https://orcid.org/0000-0002-1932-4334" - family-names: Baeßler given-names: S. orcid: "https://orcid.org/0000-0001-7732-9873" - family-names: Birge given-names: N. orcid: "https://orcid.org/0000-0003-1894-5494" - family-names: Broussard given-names: L. J. orcid: "https://orcid.org/0000-0001-9182-2808" - family-names: Gonzalez given-names: F. orcid: "https://orcid.org/0000-0002-5954-4155" - family-names: Hayen given-names: L. orcid: "https://orcid.org/0000-0002-9471-0964" - family-names: Jezghani given-names: A. orcid: "https://orcid.org/0000-0002-4302-4227" - family-names: Li given-names: H. orcid: "https://orcid.org/0000-0003-3726-9663" - family-names: Mammei given-names: R. orcid: "https://orcid.org/0009-0005-3481-4832" - family-names: Mendelsohn given-names: A. orcid: "https://orcid.org/0000-0002-4847-2133" - family-names: Randall given-names: G. orcid: "https://orcid.org/0000-0002-9713-8465" - family-names: Riley given-names: G. V. orcid: "https://orcid.org/0000-0001-7323-8448" - family-names: Schaper given-names: D. C. orcid: "https://orcid.org/0000-0002-6219-650X" date-published: 2024-06-21 doi: 10.21105/joss.06598 issn: 2475-9066 issue: 98 journal: Journal of Open Source Software publisher: name: Open Journals start: 6598 title: "Delta-Rice: A HDF5 Compression Plugin optimized for Digitized Detector Data" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06598" volume: 9 title: "Delta-Rice: A HDF5 Compression Plugin optimized for Digitized Detector Data" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 4 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 4 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5529
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06598
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

danielskatz commented 4 months ago

Congratulations to @david-mathews-1994 (David Mathews) and co-authors on your publication!!

And thanks to @macrocosme, @DanNixon, and @dineshchitlangia for reviewing, and to @emdupre for editing! JOSS depends on volunteers and we couldn't do this without you

editorialbot commented 4 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06598/status.svg)](https://doi.org/10.21105/joss.06598)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06598">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06598/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06598/status.svg
   :target: https://doi.org/10.21105/joss.06598

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

openjournals / joss-reviews