search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[REVIEW]: OptiCommPy: Open-source Simulation of Fiber Optic Communications with Python #6600

Closed editorialbot closed 5 months ago

editorialbot commented 7 months ago

Submitting author: !--author-handle-->@edsonportosilva<!--end-author-handle-- (Edson Porto da Silva) Repository: https://github.com/edsonportosilva/OptiCommPy/ Branch with paper.md (empty if default branch): add-paper Version: v0.9.0-alpha Editor: !--editor-->@lucydot<!--end-editor-- Reviewers: @klb2, @ebezzam, @taladjidi Archive: 10.5281/zenodo.11450597

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/813fc963fb14f4ef99a49151743182cf"><img src="https://joss.theoj.org/papers/813fc963fb14f4ef99a49151743182cf/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/813fc963fb14f4ef99a49151743182cf/status.svg)](https://joss.theoj.org/papers/813fc963fb14f4ef99a49151743182cf)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@klb2 & @ebezzam & @taladjidi, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @lucydot know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @klb2

📝 Checklist for @taladjidi

📝 Checklist for @ebezzam

lucydot commented 5 months ago

@editorialbot recommend-accept

editorialbot commented 5 months ago 
Attempting dry run of processing paper acceptance...
editorialbot commented 5 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/50.622902 is OK
- 10.1109/JSTQE.2010.2044751 is OK
- 10.1109/JLT.2009.2039464 is OK
- 10.1109/JLT.2020.2996188 is OK
- 10.1109/JLT.2017.2786351 is OK
- 10.1109/JLT.2017.2662082 is OK

MISSING DOIs

- No DOI given, and none found for title: Fiber-Optic Communication Systems
- No DOI given, and none found for title: Digital Communications
- No DOI given, and none found for title: Robochameleon: A matlab coding framework and compo...
- No DOI given, and none found for title: OptiSystem
- No DOI given, and none found for title: VPItransmissionMaker™ Optical Systems 
- No DOI given, and none found for title: Synopsys OptSim for Optical Communication
- No DOI given, and none found for title: Optilux, the optical simulatr toolbox.
- No DOI given, and none found for title: CuPy: A NumPy-Compatible Library for NVIDIA GPU Ca...
- No DOI given, and none found for title: CUDA, release: 10.2.89

INVALID DOIs

- None
editorialbot commented 5 months ago

:warning: Error preparing paper acceptance. The generated XML metadata file is invalid. 

Element isbn: [facet 'minLength'] The value has a length of '9'; this underruns the allowed minimum length of '10'.
Element isbn: [facet 'minLength'] The value has a length of '9'; this underruns the allowed minimum length of '10'.
Element isbn: [facet 'minLength'] The value has a length of '9'; this underruns the allowed minimum length of '10'.
editorialbot commented 5 months ago

I'm sorry @edsonportosilva, I'm afraid I can't do that. That's something only editors are allowed to do.

edsonportosilva commented 5 months ago

Hello @lucydot, I guess something was wrong with the ISBN information in the .bib file added to the paper. I have removed this information from the file since it is not displayed in the paper. Now, perhaps the process will run without errors.

lucydot commented 5 months ago

Thanks @edsonportosilva, I'll try again now.

lucydot commented 5 months ago

@editorialbot recommend-accept

editorialbot commented 5 months ago 
Attempting dry run of processing paper acceptance...
editorialbot commented 5 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/50.622902 is OK
- 10.1109/JSTQE.2010.2044751 is OK
- 10.1109/JLT.2009.2039464 is OK
- 10.1109/JLT.2020.2996188 is OK
- 10.1109/JLT.2017.2786351 is OK
- 10.1109/JLT.2017.2662082 is OK

MISSING DOIs

- No DOI given, and none found for title: Fiber-Optic Communication Systems
- No DOI given, and none found for title: Digital Communications
- No DOI given, and none found for title: Robochameleon: A matlab coding framework and compo...
- No DOI given, and none found for title: OptiSystem
- No DOI given, and none found for title: VPItransmissionMaker™ Optical Systems 
- No DOI given, and none found for title: Synopsys OptSim for Optical Communication
- No DOI given, and none found for title: Optilux, the optical simulatr toolbox.
- No DOI given, and none found for title: CuPy: A NumPy-Compatible Library for NVIDIA GPU Ca...
- No DOI given, and none found for title: CUDA, release: 10.2.89

INVALID DOIs

- None
editorialbot commented 5 months ago

:wave: @openjournals/pe-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5479, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

kyleniemeyer commented 5 months ago

@editorialbot accept

editorialbot commented 5 months ago 
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 5 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Silva given-names: Edson Porto name-particle: da orcid: "https://orcid.org/0000-0003-4230-9121" - family-names: Herbster given-names: Adolfo Fernandes orcid: "https://orcid.org/0000-0001-6194-1160" doi: 10.5281/zenodo.11450597 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Silva given-names: Edson Porto name-particle: da orcid: "https://orcid.org/0000-0003-4230-9121" - family-names: Herbster given-names: Adolfo Fernandes orcid: "https://orcid.org/0000-0001-6194-1160" date-published: 2024-06-11 doi: 10.21105/joss.06600 issn: 2475-9066 issue: 98 journal: Journal of Open Source Software publisher: name: Open Journals start: 6600 title: "OptiCommPy: Open-source Simulation of Fiber Optic Communications with Python" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06600" volume: 9 title: "OptiCommPy: Open-source Simulation of Fiber Optic Communications with Python" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 5 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 5 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5483
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06600
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

kyleniemeyer commented 5 months ago

Congratulations @edsonportosilva on your article's publication in JOSS! rePlease consider signing up as a reviewer if you haven't already.

Many thanks to @klb2, @ebezzam, and @taladjidi for reviewing this, and @lucydot for editing.

editorialbot commented 5 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06600/status.svg)](https://doi.org/10.21105/joss.06600)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06600">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06600/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06600/status.svg
   :target: https://doi.org/10.21105/joss.06600

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: