search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
719 stars 38 forks source link

[REVIEW]: DynamicOED.jl: A Julia package for solving optimum1 experimental design problems #6605

Closed editorialbot closed 4 months ago

editorialbot commented 6 months ago

Submitting author: !--author-handle-->@AlCap23<!--end-author-handle-- (Julius Martensen) Repository: https://github.com/mathopt/DynamicOED.jl Branch with paper.md (empty if default branch): Version: v0.1.2 Editor: !--editor-->@diehlpk<!--end-editor-- Reviewers: @KBodolai, @joshuaeh Archive: 10.5281/zenodo.12084055

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/6f19f7ae5cffd207a843b2e3a3134a12"><img src="https://joss.theoj.org/papers/6f19f7ae5cffd207a843b2e3a3134a12/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/6f19f7ae5cffd207a843b2e3a3134a12/status.svg)](https://joss.theoj.org/papers/6f19f7ae5cffd207a843b2e3a3134a12)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@KBodolai & @imciner2 & @joshuaeh, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @diehlpk know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @joshuaeh

📝 Checklist for @KBodolai

diehlpk commented 4 months ago

@AlCap23 you are good now and I recommended the paper for acceptance.

editorialbot commented 4 months ago

:wave: @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5512, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

danielskatz commented 4 months ago

@AlCap23 - as the track editor, I've proofread the paper, and suggest the changes in https://github.com/mathopt/DynamicOED.jl/pull/33 Please merge this, or let me know what you disagree with, then we can continue to acceptance and publication.

AlCap23 commented 4 months ago

Thanks @danielskatz. I've approved the changes and merged.

And also thanks to @diehlpk for his guidance and management throughout the review process and @joshuaeh and @KBodolai for the reviews and suggestions!

danielskatz commented 4 months ago

@editorialbot recommend-accept

editorialbot commented 4 months ago 
Attempting dry run of processing paper acceptance...
editorialbot commented 4 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1137/141000671 is OK
- 10.5334/jors.151 is OK
- 10.5281/zenodo.7738525 is OK
- 10.11588/heidok.00002980 is OK
- 10.1007/978-3-319-93031-2_27 is OK
- 10.1016/S0168-9274(99)00020-3 is OK
- 10.48550/arXiv.2103.05244 is OK
- 10.1137/110835098 is OK
- 10.1007/s10107-004-0559-y is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 4 months ago

:wave: @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5513, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

danielskatz commented 4 months ago

@editorialbot accept

editorialbot commented 4 months ago 
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 4 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Martensen given-names: Carl Julius orcid: "https://orcid.org/0000-0003-4143-3040" - family-names: Plate given-names: Christoph orcid: "https://orcid.org/0000-0003-0354-8904" - family-names: Sager given-names: Sebastian orcid: "https://orcid.org/0000-0002-0283-9075" contact: - family-names: Martensen given-names: Carl Julius orcid: "https://orcid.org/0000-0003-4143-3040" doi: 10.5281/zenodo.12084055 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Martensen given-names: Carl Julius orcid: "https://orcid.org/0000-0003-4143-3040" - family-names: Plate given-names: Christoph orcid: "https://orcid.org/0000-0003-0354-8904" - family-names: Sager given-names: Sebastian orcid: "https://orcid.org/0000-0002-0283-9075" date-published: 2024-06-19 doi: 10.21105/joss.06605 issn: 2475-9066 issue: 98 journal: Journal of Open Source Software publisher: name: Open Journals start: 6605 title: "DynamicOED.jl: A Julia package for solving optimum experimental design problems" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06605" volume: 9 title: "DynamicOED.jl: A Julia package for solving optimum experimental design problems" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 4 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 4 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5514
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06605
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

danielskatz commented 4 months ago

Congratulations to @AlCap23 (Julius Martensen) and co-authors on your publication!!

And thanks to @KBodolai and @joshuaeh for reviewing, and to @diehlpk for editing! JOSS depends on volunteers and we couldn't do this with you

editorialbot commented 4 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06605/status.svg)](https://doi.org/10.21105/joss.06605)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06605">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06605/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06605/status.svg
   :target: https://doi.org/10.21105/joss.06605

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: