Closed editorialbot closed 1 month ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.21105/joss.01037 is OK
- 10.1038/s41467-018-04534-9 is OK
- 10.1103/RevModPhys.85.299 is OK
- 10.1088/1367-2630/acce5a is OK
- 10.1103/PhysRevA.108.063512 is OK
- 10.1038/s41586-020-2649-2 is OK
MISSING DOIs
- 10.1017/cbo9780511524240.005 may be a valid DOI for title: Bose-Einstein condensation and superfluidity
- No DOI given, and none found for title: Full optical control of quantum fluids of light in...
- No DOI given, and none found for title: CuPy: A NumPy-Compatible Library for NVIDIA GPU Ca...
- No DOI given, and none found for title: Numba: A llvm-based python jit compiler
INVALID DOIs
- None
@editorialbot check references
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.21105/joss.01037 is OK
- 10.1038/s41467-018-04534-9 is OK
- 10.1103/RevModPhys.85.299 is OK
- 10.1088/1367-2630/acce5a is OK
- 10.1103/PhysRevA.108.063512 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1145/2833157.2833162 is OK
MISSING DOIs
- 10.1017/cbo9780511524240.005 may be a valid DOI for title: Bose-Einstein condensation and superfluidity
- No DOI given, and none found for title: CuPy: A NumPy-Compatible Library for NVIDIA GPU Ca...
INVALID DOIs
- 10.5281/zenodo.12698001 is INVALID
@editorialbot check references
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.21105/joss.01037 is OK
- 10.1038/s41467-018-04534-9 is OK
- 10.1103/RevModPhys.85.299 is OK
- 10.5281/zenodo.12698001 is OK
- 10.1088/1367-2630/acce5a is OK
- 10.1103/PhysRevA.108.063512 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1145/2833157.2833162 is OK
MISSING DOIs
- 10.1017/cbo9780511524240.005 may be a valid DOI for title: Bose-Einstein condensation and superfluidity
- No DOI given, and none found for title: CuPy: A NumPy-Compatible Library for NVIDIA GPU Ca...
INVALID DOIs
- None
@taladjidi I had a look into the missing DOIs and I think they are not available. Can you please confirm that? Thank you.
Hi @RMeli , the DOI for the Pitaevskii Stringari works fine on my end, and there is no DOI for Cupy. I did use the official citation provided on their repo though.
@editorialbot check references
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.21105/joss.01037 is OK
- 10.1038/s41467-018-04534-9 is OK
- 10.1103/RevModPhys.85.299 is OK
- 10.5281/zenodo.12698001 is OK
- 10.1088/1367-2630/acce5a is OK
- 10.1103/PhysRevA.108.063512 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1145/2833157.2833162 is OK
MISSING DOIs
- 10.1017/cbo9780511524240.005 may be a valid DOI for title: Bose-Einstein condensation and superfluidity
- No DOI given, and none found for title: CuPy: A NumPy-Compatible Library for NVIDIA GPU Ca...
INVALID DOIs
- None
That's right, the suggested DOI 10.1017/cbo9780511524240.005
does seem to work. I missed this. Can you please add it to the paper.bib
?
@editorialbot check references
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1017/cbo9780511524240.005 is OK
- 10.21105/joss.01037 is OK
- 10.1038/s41467-018-04534-9 is OK
- 10.1103/RevModPhys.85.299 is OK
- 10.5281/zenodo.12698001 is OK
- 10.1088/1367-2630/acce5a is OK
- 10.1103/PhysRevA.108.063512 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1145/2833157.2833162 is OK
MISSING DOIs
- No DOI given, and none found for title: CuPy: A NumPy-Compatible Library for NVIDIA GPU Ca...
INVALID DOIs
- None
That's right, the suggested DOI
10.1017/cbo9780511524240.005
does seem to work. I missed this. Can you please add it to thepaper.bib
?
Fixed, sorry I didn't even check that it was in the .bib file at first ... Should be ok now !
@editorialbot check references
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1017/cbo9780511524240.005 is OK
- 10.21105/joss.01037 is OK
- 10.1038/s41467-018-04534-9 is OK
- 10.1103/RevModPhys.85.299 is OK
- 10.5281/zenodo.12698001 is OK
- 10.1088/1367-2630/acce5a is OK
- 10.1103/PhysRevA.108.063512 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1145/2833157.2833162 is OK
MISSING DOIs
- No DOI given, and none found for title: CuPy: A NumPy-Compatible Library for NVIDIA GPU Ca...
INVALID DOIs
- None
Thanks @taladjidi, LGTM. I'll have final look at everything.
@editorialbot set <DOI here> as archive
@editorialbot set <version here> as version
@editorialbot generate pdf
@editorialbot check references
and ask author(s) to update as needed@editorialbot recommend-accept
Hi @RMeli , I uploaded the archive of the last release 2.3.0 on Zenodo DOI : 10.5281/zenodo.12795395
.
I also changed the license to stronger GNUGPLv3 license. I hope this is OK.
Thanks @taladjidi, I'll now check all that.
I also changed the license to stronger GNUGPLv3 license. I hope this is OK.
Yes, this is an OSI-approved license, therefore it is OK.
@editorialbot generate pdf
@editorialbot set 2.3.0 as version
Done! version is now 2.3.0
@editorialbot set 10.5281/zenodo.12795395 as archive
Done! archive is now 10.5281/zenodo.12795395
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
@taladjidi can you please change the title of the Zenodo archive to match the title of the paper (i.e. remove the version, which is already accounted for by the DOI)? Also, your two co-authors appear as "Contact Persons" and not as authors on Zenodo. Can you please make sure they are in the correct field?
@editorialbot check references
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1017/cbo9780511524240.005 is OK
- 10.21105/joss.01037 is OK
- 10.1038/s41467-018-04534-9 is OK
- 10.1103/RevModPhys.85.299 is OK
- 10.5281/zenodo.12698001 is OK
- 10.1088/1367-2630/acce5a is OK
- 10.1103/PhysRevA.108.063512 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1145/2833157.2833162 is OK
MISSING DOIs
- No DOI given, and none found for title: CuPy: A NumPy-Compatible Library for NVIDIA GPU Ca...
INVALID DOIs
- None
@taladjidi can you please update the Zenodo metadata to include the full author affiliation (as in the paper)? Thank you.
@taladjidi can you please change the title of the Zenodo archive to match the title of the paper (i.e. remove the version, which is already accounted for by the DOI)? Also, your two co-authors appear as "Contact Persons" and not as authors on Zenodo. Can you please make sure they are in the correct field?
Done !
@taladjidi can you please update the Zenodo metadata to include the full author affiliation (as in the paper)? Thank you.
The lab appears as a ROR (research organization registry) entry already, isn't it correct ? When you click on the ROR logo you get the same affiliation as the paper.
The lab appears as a ROR (research organization registry) entry already, isn't it correct ?
Ah! Thanks for pointing this out. I was just hovering over the author name to see the affiliation. Using "Show affiliation" does indeed show the ROR logo. However, the last author has twice the same org (one of which is not a ROR entry). Would you be able to remove it? Then I think we are good to go. ;)
Right all done ! I missed it since it was automatically added ...
@editorialbot recommend-accept
Many thanks, @taladjidi. Based on the extensive comments from the reviewers, I'm happy to recommend this paper for acceptance! The EiC will now perform the final checks.
Thank you very much again @Abinashbunty and @obliviateandsurrender for the constructive review!
Attempting dry run of processing paper acceptance...
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):
OK DOIs
- 10.1017/cbo9780511524240.005 is OK
- 10.21105/joss.01037 is OK
- 10.1038/s41467-018-04534-9 is OK
- 10.1103/RevModPhys.85.299 is OK
- 10.5281/zenodo.12698001 is OK
- 10.1088/1367-2630/acce5a is OK
- 10.1103/PhysRevA.108.063512 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1145/2833157.2833162 is OK
MISSING DOIs
- No DOI given, and none found for title: CuPy: A NumPy-Compatible Library for NVIDIA GPU Ca...
INVALID DOIs
- None
@editorialbot recommend-accept
Many thanks, @taladjidi. Based on the extensive comments from the reviewers, I'm happy to recommend this paper for acceptance! The EiC will now perform the final checks.
Thank you very much again @Abinashbunty and @obliviateandsurrender for the constructive review!
Great thank you so much for the very nice review process 👍 I wish all reviews could be like this !
:wave: @openjournals/pe-eics, this paper is ready to be accepted and published.
Check final proof :point_right::page_facing_up: Download article
If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5657, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept
🔍 checking out the following:
@editorialbot generate pdf
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
:wave: @taladjidi - great job on this!
I just need you to address the following before I move to accept this one for publication:
In the paper:
Let me know when these changes have been addressed.
Hi @crvernon, thanks for the swift takeover ! I just addressed everything you mentioned. I edited all the "nonlinear" without the hyphen to be more consistent with the title. Thanks for the .bib tips I didn't know !
@editorialbot generate pdf
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
Thanks @taladjidi!
I still need you to:
and address:
Done, sorry for the figure order !
@editorialbot generate pdf
:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:
@editorialbot accept
Submitting author: !--author-handle-->@taladjidi<!--end-author-handle-- (Tangui Aladjidi) Repository: https://github.com/Quantum-Optics-LKB/NLSE Branch with paper.md (empty if default branch): Version: 2.3.0 Editor: !--editor-->@RMeli<!--end-editor-- Reviewers: @Abinashbunty, @obliviateandsurrender Archive: 10.5281/zenodo.12795395
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@Abinashbunty & @obliviateandsurrender, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @RMeli know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @Abinashbunty
📝 Checklist for @obliviateandsurrender