[PRE REVIEW]: Desalination and brine treatment systems integrated modelling framework: simulation and evaluation of water and resource recovery

editorialbot commented 5 months ago

Submitting author: !--author-handle-->@rodoulak<!--end-author-handle-- (Rodoula Ktori) Repository: https://github.com/rodoulak/Desalination-and-Brine-Treatment-Simulation- Branch with paper.md (empty if default branch): main Version: v1.0.0 Editor: Pending Reviewers: Pending Managing EiC: Kristen Thyng

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/9bf471d00bb16e57201f91cfdd35dd7c"><img src="https://joss.theoj.org/papers/9bf471d00bb16e57201f91cfdd35dd7c/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/9bf471d00bb16e57201f91cfdd35dd7c/status.svg)](https://joss.theoj.org/papers/9bf471d00bb16e57201f91cfdd35dd7c)

Author instructions

Thanks for submitting your paper to JOSS @rodoulak. Currently, there isn't a JOSS editor assigned to your paper.

@rodoulak if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

editorialbot commented 5 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

editorialbot commented 5 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.04 s (509.2 files/s, 147124.4 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          15            843           1169           2797
Markdown                         2             44              0            192
TeX                              1              2              0            154
-------------------------------------------------------------------------------
SUM:                            18            889           1169           3143
-------------------------------------------------------------------------------

Commit count by author:

    87  rodoulak
    14  Rodoula Ktori

editorialbot commented 5 months ago

Paper file info:

📄 Wordcount for paper.md is 841

✅ The paper includes a Statement of need section

editorialbot commented 5 months ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 5 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- No DOI given, and none found for title: Socio-economic & technical assessment of photovolt...
- 10.1016/j.renene.2011.03.040 may be a valid DOI for title: On the feasibility of community-scale photovoltaic...
- 10.1021/acssuschemeng.2c06636.s001 may be a valid DOI for title: Electrodialysis with bipolar membranes for the sus...
- 10.1016/j.desal.2020.114928 may be a valid DOI for title: A zero liquid discharge system integrating multi-e...
- 10.3390/membranes6010003 may be a valid DOI for title: Economic evaluation of a hybrid desalination syste...
- 10.1016/b978-0-444-50810-2.x5000-3 may be a valid DOI for title: Fundamentals of salt water desalination
- 10.1016/j.desal.2013.03.033 may be a valid DOI for title: Economic analysis of desalination technologies in ...
- 10.36227/techrxiv.170595103.36689587/v1 may be a valid DOI for title: Sustainability assessment framework for integrated...
- 10.1016/j.jclepro.2020.122472 may be a valid DOI for title: Techno-economic analysis of integrated processes f...
- 10.1016/j.desal.2022.116005 may be a valid DOI for title: Valorisation of SWRO brines in a remote island thr...
- 10.1016/j.desal.2018.11.018 may be a valid DOI for title: Cost and energy requirements of hybrid RO and ED b...
- 10.1016/j.jece.2021.105338 may be a valid DOI for title: Beneficiation of saline effluents from seawater de...
- No DOI given, and none found for title: Plant design and economics for chemical engineers
- 10.3390/separations9100295 may be a valid DOI for title: Techno-economic analysis of brine treatment by mul...
- 10.1080/19443994.2014.948660 may be a valid DOI for title: Design of an innovative vacuum evaporator system f...
- 10.1016/j.desal.2024.117562 may be a valid DOI for title: Pioneering minimum liquid discharge desalination: ...
- No DOI given, and none found for title: Deliverable 3.1 Report on the design procedure inc...
- No DOI given, and none found for title: WAVE Water Treatment Design Software

INVALID DOIs

- None

editorialbot commented 5 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kthyng commented 5 months ago

Hi @rodoulak and thanks for your submission! I am looking for some specific items to make sure your submission fits our requirements at a high level (not at the more detailed review level) before moving on to finding an editor or putting this on our waitlist if no relevant editors are available. I'll comment over time as I have a chance to go through them:

[ ] Substantial scholarly effort
[ ] Documentation
[ ] Tests of some sort
[ ] Installation instructions
[ ] Clear research application
[x] Check paper

In the meantime, please take a look at the comments above ⬆️ from the editorialbot to address any DOI, license, or paper issues if you're able (there may not be any), or suggest reviewers. For reviewers, please suggest 5 reviewers from the database listed above or your own (non-conflicted) extended network. Their github handles are most useful to receive but please don't use "@" to reference them since it will prematurely ping them.

rodoulak commented 5 months ago

Hi @kthyng,
Below is the list of reviewers:

Demetrios G. Eliades (eldemet)
Shubham Jain (shubhamjain15)
Lokendra Singh Rathore (LSRathore)
DARSakthi (DARSakthi)
mewilhel (mewilhel)
thermalogic (thermalogic)

In the meantime, I will add the DOIs in the bib file.

kthyng commented 5 months ago

Hi @rodoulak:

Is there any way for a user to verify that the code is working as intended?
Is there documentation beyond the readme?
Is it possible to install the package from PyPI or conda-forge?

rodoulak commented 5 months ago

Hi @kthyng ,

Yes, in every function, there is a mass balance calculation and the percentage error of that calculation, and the result is printed. Moreover, in the two examples, a Sankey diagram is printed out showing the mass balances of the treatment chain. Please let me know if you need more verification.
No, there is not. However, there is a detailed explanation of how to use the functions, and example 1 gives all the steps required to get started. I could add a tutorial if it is necessary
I think no, it is not in the form of a package

kthyng commented 5 months ago

Thanks for your responses, @rodoulak. I am going to ping the editorial board to see if they think this submission is in scope. This process will take a few weeks, thanks for your patience.

kthyng commented 5 months ago

@editorialbot query scope

editorialbot commented 5 months ago

Submission flagged for editorial review.

kthyng commented 5 months ago

Hi @rodoulak. This submission has been found to be out of scope in terms of packaging. For example, normally python-based JOSS submissions can be installed from PyPI (if possible), have decent hosted documentation if possible, and tests to verify that the code is running properly. Resubmission is possible in the future if you feel you have made these changes and would like to try again. Thank you for your efforts.

kthyng commented 5 months ago

@editorialbot reject

editorialbot commented 5 months ago

Paper rejected.

openjournals / joss-reviews

[PRE REVIEW]: Desalination and brine treatment systems integrated modelling framework: simulation and evaluation of water and resource recovery #6614

Status