[REVIEW]: IonDiff: command-line tool to identify ionic diffusion events and hopping correlations in molecular dynamics simulations

editorialbot commented 4 months ago

Submitting author: !--author-handle-->@IonRepo@rkurchin<!--end-editor-- Reviewers: @yw-fang, @LIVazquezS Archive: 10.5281/zenodo.12771455

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/09fae4627300e87154ce0679cac6f099"><img src="https://joss.theoj.org/papers/09fae4627300e87154ce0679cac6f099/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/09fae4627300e87154ce0679cac6f099/status.svg)](https://joss.theoj.org/papers/09fae4627300e87154ce0679cac6f099)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@yw-fang & @LIVazquezS, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @rkurchin know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @LIVazquezS

📝 Checklist for @yw-fang

Claudiator7 commented 1 month ago

@editorialbot accept

editorialbot commented 1 month ago

I'm sorry @Claudiator7, I'm afraid I can't do that. That's something only eics are allowed to do.

Kevin-Mattheus-Moerman commented 1 month ago

@IonRepo @Claudiator7 as AEiC for JOSS I will now help to process this submission for acceptance in JOSS. I have checked this review, your repository, the archive link, and the paper. Most seems in order, however the below are some points that require your attention:

On the paper:

[x] Both British English (e.g. analysing) and American English (e.g. the use of the z in optimized, minimize, maximized, and vectorization) are used. Please use one consistently and edit the paper accordingly.

IonRepo commented 1 month ago

Thank you for the careful reading of our paper. We have corrected that typo, which is now analyzing instead of analysing in both the README and the paper (attached).

Best regards, Cibrán.

On Sun, 21 Jul 2024, 11:17 Kevin Mattheus Moerman, @.***> wrote:

@IonRepo https://github.com/IonRepo @Claudiator7 https://github.com/Claudiator7 as AEiC for JOSS I will now help to process this submission for acceptance in JOSS. I have checked this review, your repository, the archive link, and the paper. Most seems in order, however the below are some points that require your attention:

On the paper:

Both British English (e.g. analysing) and American English (e.g. the use of the z in optimized, minimize, maximized, and vectorization) are used. Please use one consistently and edit the paper accordingly.

— Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/6616#issuecomment-2241540042, or unsubscribe https://github.com/notifications/unsubscribe-auth/A6TPLNLGIBEWUSAB6PQOE6LZNN4DPAVCNFSM6AAAAABGFVF3QGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBRGU2DAMBUGI . You are receiving this because you were mentioned.Message ID: @.***>

Claudiator7 commented 1 month ago

@Kevin-Mattheus-Moerman, is there anything else we should do on this regard? Thanks a lot for your help.

Best wishes, Claudio

rkurchin commented 1 month ago

pinging @openjournals/bcm-eics again here in case this one slipped through the cracks!

Kevin-Mattheus-Moerman commented 1 month ago

@editorialbot generate pdf

Kevin-Mattheus-Moerman commented 1 month ago

@IonRepo @Claudiator7 @rkurchin thanks for the reminders. I'll review the changes and will then process this for acceptance.

editorialbot commented 1 month ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Claudiator7 commented 1 month ago

@Kevin-Mattheus-Moerman @rkurchin @editorialbot The proofs of the article looks good to us. Thanks a lot!

Kevin-Mattheus-Moerman commented 1 month ago

@editorialbot accept

editorialbot commented 1 month ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 1 month ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: López given-names: Cibrán orcid: "https://orcid.org/0000-0003-3949-5058" - family-names: Rurali given-names: Riccardo orcid: "https://orcid.org/0000-0002-4086-4191" - family-names: Cazorla given-names: Claudio orcid: "https://orcid.org/0000-0002-6501-4513" contact: - family-names: Cazorla given-names: Claudio orcid: "https://orcid.org/0000-0002-6501-4513" doi: 10.5281/zenodo.12771455 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: López given-names: Cibrán orcid: "https://orcid.org/0000-0003-3949-5058" - family-names: Rurali given-names: Riccardo orcid: "https://orcid.org/0000-0002-4086-4191" - family-names: Cazorla given-names: Claudio orcid: "https://orcid.org/0000-0002-6501-4513" date-published: 2024-07-30 doi: 10.21105/joss.06616 issn: 2475-9066 issue: 99 journal: Journal of Open Source Software publisher: name: Open Journals start: 6616 title: "IonDiff: command-line tool to identify ionic diffusion events and hopping correlations in molecular dynamics simulations" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06616" volume: 9 title: "IonDiff: command-line tool to identify ionic diffusion events and hopping correlations in molecular dynamics simulations" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 1 month ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 1 month ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5705
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06616
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

Kevin-Mattheus-Moerman commented 1 month ago

@IonRepo et al., congratulations on this JOSS publicatioN!

Thank you @rkurchin for editing, and a special thanks to the reviewers: @yw-fang, @LIVazquezS !!!

editorialbot commented 1 month ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06616/status.svg)](https://doi.org/10.21105/joss.06616)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06616">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06616/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06616/status.svg
   :target: https://doi.org/10.21105/joss.06616

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

openjournals / joss-reviews