openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
720 stars 38 forks source link

[REVIEW]: DistriFS: A Platform and User Agnostic Approach to Dataset Distribution #6625

Closed editorialbot closed 3 months ago

editorialbot commented 6 months ago

Submitting author: !--author-handle-->@JIBSIL<!--end-author-handle-- (Julian Boesch) Repository: https://github.com/JIBSIL/DistriFS Branch with paper.md (empty if default branch): Version: v1.0.0 Editor: !--editor-->@mahfuz05062<!--end-editor-- Reviewers: @aparoha, @suriya-ganesh Archive: 10.6084/m9.figshare.26049448

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/af09fee13984aa8fc8dc2c5cf062756e"><img src="https://joss.theoj.org/papers/af09fee13984aa8fc8dc2c5cf062756e/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/af09fee13984aa8fc8dc2c5cf062756e/status.svg)](https://joss.theoj.org/papers/af09fee13984aa8fc8dc2c5cf062756e)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@aparoha & @suriya-ganesh, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @mahfuz05062 know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

πŸ“ Checklist for @aparoha

πŸ“ Checklist for @suriya-ganesh

editorialbot commented 3 months ago
Attempting dry run of processing paper acceptance...
editorialbot commented 3 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/HICSS.2008.436 is OK
- 10.1177/0165551513480107 is OK
- 10.1093/ijlit/ean010 is OK
- 10.1145/269005.266694 is OK
- 10.1145/3488716 is OK
- 10.1109/MSR.2017.59 is OK
- 10.1145/3544216.3544232 is OK

MISSING DOIs

- No DOI given, and none found for title: IPFS - Content addressed, versioned, P2P file syst...

INVALID DOIs

- None
editorialbot commented 3 months ago

:wave: @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5564, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

danielskatz commented 3 months ago

@JIBSIL - sorry, I have now noticed that the financial statement and the references run together, as the references header at the end of the .md is missing. I've added it in https://github.com/JIBSIL/DistriFS/pull/9 - please merge this.

JIBSIL commented 3 months ago

@danielskatz - Sorry about that- I've accepted the pull request. Thanks!

danielskatz commented 3 months ago

@editorialbot recommend-accept

editorialbot commented 3 months ago
Attempting dry run of processing paper acceptance...
editorialbot commented 3 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/HICSS.2008.436 is OK
- 10.1177/0165551513480107 is OK
- 10.1093/ijlit/ean010 is OK
- 10.1145/269005.266694 is OK
- 10.1145/3488716 is OK
- 10.1109/MSR.2017.59 is OK
- 10.1145/3544216.3544232 is OK

MISSING DOIs

- No DOI given, and none found for title: IPFS - Content addressed, versioned, P2P file syst...

INVALID DOIs

- None
editorialbot commented 3 months ago

:wave: @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5566, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

danielskatz commented 3 months ago

@editorialbot accept

editorialbot commented 3 months ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 3 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Boesch given-names: Julian orcid: "https://orcid.org/0009-0006-8945-0092" doi: 10.6084/m9.figshare.26049448 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Boesch given-names: Julian orcid: "https://orcid.org/0009-0006-8945-0092" date-published: 2024-07-02 doi: 10.21105/joss.06625 issn: 2475-9066 issue: 99 journal: Journal of Open Source Software publisher: name: Open Journals start: 6625 title: "DistriFS: A Platform and User Agnostic Approach to Dataset Distribution" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06625" volume: 9 title: "DistriFS: A Platform and User Agnostic Approach to Dataset Distribution" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 3 months ago

🐘🐘🐘 πŸ‘‰ Toot for this paper πŸ‘ˆ 🐘🐘🐘

editorialbot commented 3 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5567
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06625
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! πŸŽ‰πŸŒˆπŸ¦„πŸ’ƒπŸ‘»πŸ€˜

Any issues? Notify your editorial technical team...

JIBSIL commented 3 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

cff-version: "1.2.0"
authors:
- family-names: Boesch
  given-names: Julian
  orcid: "https://orcid.org/0009-0006-8945-0092"
doi: 10.6084/m9.figshare.26049448
message: If you use this software, please cite our article in the
  Journal of Open Source Software.
preferred-citation:
  authors:
  - family-names: Boesch
    given-names: Julian
    orcid: "https://orcid.org/0009-0006-8945-0092"
  date-published: 2024-07-02
  doi: 10.21105/joss.06625
  issn: 2475-9066
  issue: 99
  journal: Journal of Open Source Software
  publisher:
    name: Open Journals
  start: 6625
  title: "DistriFS: A Platform and User Agnostic Approach to Dataset
    Distribution"
  type: article
  url: "https://joss.theoj.org/papers/10.21105/joss.06625"
  volume: 9
title: "DistriFS: A Platform and User Agnostic Approach to Dataset
  Distribution"

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

Just completed this! The cite repository menu looks to be working.

danielskatz commented 3 months ago

Congratulations to @JIBSIL (Julian Boesch) on your publication!!

And thanks to @aparoha and @suriya-ganesh for reviewing, and to @mahfuz05062 for editing! JOSS depends on volunteers and it wouldn't be successful without you

Note: https://www.theoj.org/joss-papers/joss.06625/10.21105.joss.06625.pdf doesn't currently work for me, so I'll leave this issue open until it does. This could be a network caching issue, or a delay somewhere in the processing outside of JOSS.

danielskatz commented 3 months ago

The issue is likely the maintenance mentioned in https://status.crossref.org/incidents/382r13mfjvhb

JIBSIL commented 3 months ago

@danielskatz - strangely, Crossref just sent me an email to connect with my ORCID account (and successfully added the paper to there), but it appears that the link is still throwing a 404.

danielskatz commented 3 months ago

I'm sure it's just backed up and will get there - there's also the network caching issue where it may be there but it may not appear for us since we're getting the failed cached version

danielskatz commented 3 months ago

@editorialbot re-accept

The problem might resolve itself eventually, but this might fix the problem now.

editorialbot commented 3 months ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

danielskatz commented 3 months ago

@editorialbot reaccept

editorialbot commented 3 months ago
Rebuilding paper!
editorialbot commented 3 months ago

🌈 Paper updated!

New PDF and metadata files :point_right: https://github.com/openjournals/joss-papers/pull/5568

JIBSIL commented 3 months ago

Still appears to be having the 404 error (after clearing local cache too). Strange.

danielskatz commented 3 months ago

@editorialbot reaccept

editorialbot commented 3 months ago
Rebuilding paper!
editorialbot commented 3 months ago

🌈 Paper updated!

New PDF and metadata files :point_right: https://github.com/openjournals/joss-papers/pull/5571

danielskatz commented 3 months ago

@JIBSIL - sorry, I'm unable to debug this but have asked @arfon (our EiC) to help

JIBSIL commented 3 months ago

@danielskatz - It appears that the complications have been resolved. Thanks to you, mahfuz05062, aparoha and suriya-ganesh for your help throughout the process - it truly made publishing at JOSS an enjoyable experience, and I would love to publish here again!

editorialbot commented 3 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06625/status.svg)](https://doi.org/10.21105/joss.06625)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06625">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06625/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06625/status.svg
   :target: https://doi.org/10.21105/joss.06625

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following: