search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
720 stars 38 forks source link

[PRE REVIEW]: Singularity-EOS: Performance Portable Equations of State and Mixed Cell Closures #6658

Closed editorialbot closed 4 months ago

editorialbot commented 6 months ago

Submitting author: !--author-handle-->@Yurlungur<!--end-author-handle-- (Jonah Miller) Repository: https://github.com/lanl/singularity-eos Branch with paper.md (empty if default branch): Version: v1.8.0 Editor: !--editor-->@kyleniemeyer<!--end-editor-- Reviewers: @parikshitbajpai, @snikolov3 Managing EiC: Kyle Niemeyer

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/9d2ab99bcafa1421e2c9576899cd17bc"><img src="https://joss.theoj.org/papers/9d2ab99bcafa1421e2c9576899cd17bc/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/9d2ab99bcafa1421e2c9576899cd17bc/status.svg)](https://joss.theoj.org/papers/9d2ab99bcafa1421e2c9576899cd17bc)

Author instructions

Thanks for submitting your paper to JOSS @Yurlungur. Currently, there isn't a JOSS editor assigned to your paper.

@Yurlungur if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 6 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 6 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.12 s (1478.1 files/s, 347806.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
C/C++ Header                    48           1512           2011          14237
C++                             49           1009           1484           9824
reStructuredText                12           1402           1308           2448
CMake                           28            256            470           1265
Python                          11            272            292           1180
Markdown                         7            234              0            966
Fortran 90                       2             79             62            633
YAML                            10             53             34            522
make                             3             57             55            178
TeX                              1             13              0            164
diff                             4             39            155            118
JSON                             1              0              0            111
Bourne Shell                     2              9             29             38
HTML                             2              0              1             36
DOS Batch                        1              8              1             26
-------------------------------------------------------------------------------
SUM:                           181           4943           5902          31746
-------------------------------------------------------------------------------

Commit count by author:

   258  Jonah Maxwell Miller
   233  Jeffrey H Peterson
   196  Jonah Miller
   178  Richard Berger
   174  Christopher Mauney
   148  Daniel Holladay
    54  Karen Chung-Yen Tsai
    40  Alexander Holas
    38  Jeff Peterson
    37  Josh Dolence
    34  Ann Elisabet Wills - 298385
    29  Gopinath Subramanian
    28  Benjamin Joel Musick
    25  Christopher Michael Mauney
    23  Anna Pietarila Graham
    15  AlexHls
    10  Ben R. Ryan
    10  mauneyc-LANL
     8  jdolence
     7  Christoph Junghans
     7  Karen C. Tsai
     5  Daniel Alphin Holladay
     5  github-actions[bot]
     4  Brandon Barker
     4  mari2895
     3  Shane Patrick Fogerty
     3  c0sm0-kramer
     2  Mariam Gogilashvili
     2  Peter Brady
     2  Shane Patrick Fogerty - 322405
     1  Ben Ryan
     1  Chad Meyer
     1  Matt Stack
     1  chadmeyer
editorialbot commented 6 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.3847/1538-4365/ab007f is OK
- 10.3847/1538-4365/ab09fc is OK
- 10.3847/0004-637X/816/1/44 is OK
- 10.1109/TPDS.2021.3097283 is OK
- 10.1145/3388333.3388649 is OK
- 10.48550/arXiv.2206.08957 is OK
- 10.1145/2807591.2807623 is OK

MISSING DOIs

- No DOI given, and none found for title: Sesame: The Los Alamos National Laboratory Equatio...
- 10.1088/0264-9381/27/11/114103 may be a valid DOI for title: A new open-source code for spherically symmetric s...
- No DOI given, and none found for title: Stellar Collapse: Microphysics
- 10.2172/1765849 may be a valid DOI for title: EOSPAC User’s Manual: V.6.5
- No DOI given, and none found for title: Numerical Recipes with Source Code CD-ROM 3rd Edit...
- No DOI given, and none found for title: CUDA, release: 10.2.89
- No DOI given, and none found for title: Parallel programming in OpenMP

INVALID DOIs

- None
editorialbot commented 6 months ago

Paper file info:

📄 Wordcount for paper.md is 1797

✅ The paper includes a Statement of need section

editorialbot commented 6 months ago

License info:

✅ License found: BSD 3-Clause "New" or "Revised" License (Valid open source OSI approved license)

editorialbot commented 6 months ago

:warning: An error happened when generating the pdf. Author (Daniel A. Holladay) is missing affiliation.

kyleniemeyer commented 6 months ago

Hi @Yurlungur, it looks like the paper compilation error is coming from the dash before orcid field in Daniel Hollday's author block.

kyleniemeyer commented 6 months ago

@editorialbot assign me as editor

I'm going to edit this submission myself.

editorialbot commented 6 months ago

Assigned! @kyleniemeyer is now the editor

Yurlungur commented 6 months ago

Hi @Yurlungur, it looks like the paper compilation error is coming from the dash before orcid field in Daniel Hollday's author block.

Oops. Hopefully fixed now. Thanks @kyleniemeyer !

Yurlungur commented 6 months ago

@editorialbot generate pdf

editorialbot commented 6 months ago

:warning: An error happened when generating the pdf. Problem with affiliations for Chad Meyer, perhaps the affiliations index need quoting?.

Yurlungur commented 6 months ago

@editorialbot generate pdf

editorialbot commented 6 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

Yurlungur commented 6 months ago

OK NOW it's fixed. Sorry about that!

Yurlungur commented 5 months ago

Hi @kyleniemeyer what is the status currently of the submission? Should it move into review?

junghans commented 5 months ago

@editorialbot generate pdf

editorialbot commented 5 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

kyleniemeyer commented 5 months ago

@Yurlungur Sorry for the delay—busy term! I need to find and assign at least two reviewers, before this progresses into the review issue. If you have any recommendations, those would be welcome.

kyleniemeyer commented 5 months ago

Hello @parikshitbajpai @corykinney @fwitte would any of you be able to review this submission for JOSS? It describes a library, Singularity-EOS, for equations of state.

parikshitbajpai commented 5 months ago

Hello @parikshitbajpai @corykinney @fwitte would any of you be able to review this submission for JOSS? It describes a library, Singularity-EOS, for equations of state.

Hi @kyleniemeyer, I can review this but I'm quite busy until May 30 so I won't be able to do it before then. I'll be open to review if it can wait till then.

Yurlungur commented 5 months ago

@Yurlungur Sorry for the delay—busy term! I need to find and assign at least two reviewers, before this progresses into the review issue. If you have any recommendations, those would be welcome.

No problem. Thanks @kyleniemeyer ! Regarding reviewers... I'm not sure of their availability but some names that occur to me are zingale, stevenrbrandt, felker, eloisabentivegna.

Yurlungur commented 5 months ago

From skimming the list of reviewers on the JOSS website, I could also suggest dshawul, chongchonghe, lelaus, victorapm, esclapez, MakisH

fwitte commented 5 months ago

Hi and thanks for the invitation. Unfortunately I am not experienced with C++, and more on the side of applying EOS for modeling instead of writing them myself. Therefore I would like to pass on this.

Other ideas for reviewers could be people from the CoolProp ecosystem (ibell or jowr for example).

kyleniemeyer commented 5 months ago

@parikshitbajpai that timeline works, thanks!

kyleniemeyer commented 5 months ago

@editorialbot add @parikshitbajpai as reviewer

editorialbot commented 5 months ago

@parikshitbajpai added to the reviewers list!

kyleniemeyer commented 5 months ago

@esclapez would you be available to review this submission to JOSS? It describes a library, Singularity-EOS, for equations of state.

eloisabentivegna commented 5 months ago

Hi @Yurlungur and @kyleniemeyer: I am not available at the moment. You seem to have a long list of good candidates, though!

corykinney commented 5 months ago

@kyleniemeyer I have limited experience with C++, so due to the size of the codebase for this project, I don't think I would be the right person to review it, unfortunately.

junghans commented 4 months ago

For reviewers, how about athomps?

kyleniemeyer commented 4 months ago

Hello @athomps, are you available to review this submission for JOSS? It is about an equation of state library, Singularity-EOS. The repo is at https://github.com/lanl/singularity-eos and the draft paper is here: https://github.com/openjournals/joss-papers/blob/joss.06658/joss.06658/10.21105.joss.06658.pdf

If you aren't familiar with JOSS (the Journal of Open Source Software), the journal publishes articles about open source research software, where the reviews happen in the open on GitHub.

athomps commented 4 months ago

My colleague Svetoslav Nikolov @snikolov3 is interested and has kindly agreed to provide some feedback.

athomps commented 4 months ago

@snikolov3 Will you review this JOSS contribution? It is about an equation of state library, Singularity-EOS. The repo is at https://github.com/lanl/singularity-eos and the draft paper is here: https://github.com/openjournals/joss-papers/blob/joss.06658/joss.06658/10.21105.joss.06658.pdf

snikolov3 commented 4 months ago

@athomps Sure happy to do that. When do you need this by?

kyleniemeyer commented 4 months ago

@snikolov3 thanks! We ask reviewers to complete their reviews within two or three weeks if possible. However, JOSS's review process is a bit different, since it is checklist-based and we encourage interaction between reviewers and the authors via the review issue. So, you don't have to do it all at once.

A bit more about the reviewing for JOSS here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html#

kyleniemeyer commented 4 months ago

@editorialbot add @snikolov3 as reviewer

editorialbot commented 4 months ago

@snikolov3 added to the reviewers list!

kyleniemeyer commented 4 months ago

@editorialbot start review

editorialbot commented 4 months ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6805.