[PRE REVIEW]: GOBLIN Lite: A National Land Balance Model for Assessment of Climate Mitigation Pathways for Ireland

[editorialbot]

Submitting author: !--author-handle-->@colmduff<!--end-author-handle-- (Colm Duffy) Repository: https://github.com/GOBLIN-Proj/goblin_lite Branch with paper.md (empty if default branch): Version: v0.3.4 Editor: !--editor-->@mengqi-z<!--end-editor-- Reviewers: @david-yannick, @varsha2509 Managing EiC: Kristen Thyng

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/806128fd062df47b26092c999ae57470"><img src="https://joss.theoj.org/papers/806128fd062df47b26092c999ae57470/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/806128fd062df47b26092c999ae57470/status.svg)](https://joss.theoj.org/papers/806128fd062df47b26092c999ae57470)

Author instructions

Thanks for submitting your paper to JOSS @colmduff. Currently, there isn't a JOSS editor assigned to your paper.

@colmduff if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands

[editorialbot]

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

[editorialbot]

Checking the BibTeX entries failed with the following error:

Failed to parse BibTeX on value "b" (NAME) ["@", #<BibTeX::Entry >, {:url=>["https://gmd.copernicus.org/articles/15/2239/2022/"], :archiveprefix=>["gmd"], :author=>["{Duffy}, C. and {Prudhomme}, R. and {Duffy}, B. and {Gibbons}, J. and {O'Donoghue}, C. and {Ryan}, M. and {Styles}, D."], :journal=>["Geoscientific Model Development"], :month=>[:mar], :title=>["{GOBLIN version 1.0: a land balance model to identify national agriculture and land use pathways to climate neutrality via backcasting}"], :year=>"2022"}]

[editorialbot]

Software report:

github.com/AlDanial/cloc v 1.90  T=0.19 s (891.1 files/s, 348793.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
CSV                             33              0              0          27706
HTML                            50           2848            147          16494
Python                          26           1371           2236           3030
SVG                              1              0              0           2671
CSS                              6            754             63           2549
JavaScript                      12            131            221            880
JSON                             3              0              0            315
Markdown                         7            110              0            313
reStructuredText                24           1787           1988            133
YAML                             3             13              4             69
TeX                              1              0              0             67
Jupyter Notebook                 1              0            507             47
TOML                             1              2              0             27
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                           170           7028           5174          54336
-------------------------------------------------------------------------------

Commit count by author:

    48  Colm Duffy
    32  Colm

[editorialbot]

Paper file info:

📄 Wordcount for paper.md is 899

✅ The paper includes a Statement of need section

[editorialbot]

License info:

🟡 License found: GNU General Public License v3.0 (Check here for OSI approval)

[editorialbot]

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

[kthyng]

Hi @colmduff and thanks for your submission! I am looking for some specific items to make sure your submission fits our requirements at a high level (not at the more detailed review level) before moving on to finding an editor or putting this on our waitlist if no relevant editors are available. I'll comment over time as I have a chance to go through them:

• [x] Substantial scholarly effort
• [x] Documentation
• [x] Tests of some sort
• [ ] Installation instructions
• [x] Clear research application
• [x] Check paper
• [x] License

In the meantime, please take a look at the comments above ⬆️ from the editorialbot to address any DOI, license, or paper issues if you're able (there may not be any), or suggest reviewers. For reviewers, please suggest 5 reviewers from the database listed above or your own (non-conflicted) extended network. Their github handles are most useful to receive but please don't use "@" to reference them since it will prematurely ping them.

[kthyng]

Is there a reason users need to install from github instead of setting up a release with PyPI or conda-forge?

[colmduff]

Hi!

I haven't actually put it on either of those. Caveating my submission here with the fact that I am a bit of a "learn as you go" developer. I can put it on those platforms, but honestly, had not investigated at this point.

In terms of install instructions, which looks to be the only thing you need right now, I had just put pip install instructions. But, I can have a look through other repos that have published in JOSS and confirm my documents.

Apologies again if you have to tell me any seemingly basic things, its just a little inexperienced. So all criticism is most welcome.

Thanks a million

Colm

[kthyng]

That is ok! JOSS wants to be available to submitting authors like you describe yourself as with less experience, but we also are willing to point you to resources to up your game, as it were. In this case, I suggest you use this time (you're going to be on the waitlist anyway though you didn't know it yet) to get your repo onto PyPI since it's the easiest one, and conda-forge if possible. Here are some links to help:

• https://www.pyopensci.org/python-package-guide/
• https://www.pyopensci.org/python-package-guide/package-structure-code/publish-python-package-pypi-conda.html#

[kthyng]

We have a backlog of submissions so I will add this to our waitlist. In the meantime, please suggest 5 reviewers from the database listed above or your own (non-conflicted) extended network. Their github handles are most useful to receive but please don't use "@" to reference them since it will prematurely ping them. Thanks for your patience.

[colmduff]

OK, perfect.

I will get some reviewers for you from the db later today, update the docs with install instructions, and get working on PyPI.

Very much appreciate the guidance and the patience.

Thanks a million!

Colm

[colmduff]

Hi @kthyng,

Here are 6 reviewers that have somewhat similar experience in general field of climate change, agriculture, land use change.

dlebauer hvwaldow david-yannick shubhamjain15 kanishkan91 andres-patrignani varsha2509

[kthyng]

@hugoledoux Could you edit this submission?

[kthyng]

@editorialbot invite @hugoledoux as editor

[editorialbot]

Invitation to edit this submission sent!

[kthyng]

@editorialbot assign @mengqi-z as editor

[editorialbot]

Assigned! @mengqi-z is now the editor

[mengqi-z]

Checking the BibTeX entries failed with the following error:

Failed to parse BibTeX on value "b" (NAME) ["@", #<BibTeX::Entry >, {:url=>["https://gmd.copernicus.org/articles/15/2239/2022/"], :archiveprefix=>["gmd"], :author=>["{Duffy}, C. and {Prudhomme}, R. and {Duffy}, B. and {Gibbons}, J. and {O'Donoghue}, C. and {Ryan}, M. and {Styles}, D."], :journal=>["Geoscientific Model Development"], :month=>[:mar], :title=>["{GOBLIN version 1.0: a land balance model to identify national agriculture and land use pathways to climate neutrality via backcasting}"], :year=>"2022"}]

Hi @colmduff, I'll be your editor for this submission. While I am finding some reviewers, would you mind addressing the following errors in your .bib file?

[mengqi-z]

Hi @varsha2509 and @david-yannick, Would any of you be interested in taking on reviewing this JOSS submission?

[david-yannick]

@mengqi-z I would be happy to review

[mengqi-z]

@editorialbot add @david-yannick as reviewer

[editorialbot]

@david-yannick added to the reviewers list!

[varsha2509]

Responding via email - happy to review this as well.

On Tue, May 7, 2024, 6:15 PM The Open Journals editorial robot < @.***> wrote:

@david-yannick https://github.com/david-yannick added to the reviewers list!

— Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/6659#issuecomment-2099551404, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEDDXCLCRGUPQRJWAMKZY5TZBF4DPAVCNFSM6AAAAABGTCSJM2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJZGU2TCNBQGQ . You are receiving this because you were mentioned.Message ID: @.***>

[mengqi-z]

@editorialbot add @varsha2509 as reviewer

[editorialbot]

@varsha2509 added to the reviewers list!

[mengqi-z]

@editorialbot start review

[editorialbot]

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/6732.

[colmduff]

Checking the BibTeX entries failed with the following error:

Failed to parse BibTeX on value "b" (NAME) ["@", #<BibTeX::Entry >, {:url=>["https://gmd.copernicus.org/articles/15/2239/2022/"], :archiveprefix=>["gmd"], :author=>["{Duffy}, C. and {Prudhomme}, R. and {Duffy}, B. and {Gibbons}, J. and {O'Donoghue}, C. and {Ryan}, M. and {Styles}, D."], :journal=>["Geoscientific Model Development"], :month=>[:mar], :title=>["{GOBLIN version 1.0: a land balance model to identify national agriculture and land use pathways to climate neutrality via backcasting}"], :year=>"2022"}]

Hi @colmduff, I'll be your editor for this submission. While I am finding some reviewers, would you mind addressing the following errors in your .bib file?

Hi @mengqi-z

Just looking at that error. I have tried to address that, but I think its the "b" on the end of the year, which I need to distinguish between two similar citations. It seems to compile fine for me at the moment. But, in saying that, it also compiled for me before as well.

[mengqi-z]

Checking the BibTeX entries failed with the following error:

Failed to parse BibTeX on value "b" (NAME) ["@", #<BibTeX::Entry >, {:url=>["https://gmd.copernicus.org/articles/15/2239/2022/"], :archiveprefix=>["gmd"], :author=>["{Duffy}, C. and {Prudhomme}, R. and {Duffy}, B. and {Gibbons}, J. and {O'Donoghue}, C. and {Ryan}, M. and {Styles}, D."], :journal=>["Geoscientific Model Development"], :month=>[:mar], :title=>["{GOBLIN version 1.0: a land balance model to identify national agriculture and land use pathways to climate neutrality via backcasting}"], :year=>"2022"}]

Hi @colmduff, I'll be your editor for this submission. While I am finding some reviewers, would you mind addressing the following errors in your .bib file?

Hi @mengqi-z

Just looking at that error. I have tried to address that, but I think its the "b" on the end of the year, which I need to distinguish between two similar citations. It seems to compile fine for me at the moment. But, in saying that, it also compiled for me before as well.

Hi @colmduff,

I believe you can remove a and b and keep the year as 2022 for both papers because it should automatically distinguish between the papers when it gets compiled.