openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
722 stars 38 forks source link

[PRE REVIEW]: xspline: A Python Package for Flexible Spline Modeling #6663

Closed editorialbot closed 6 months ago

editorialbot commented 6 months ago

Submitting author: !--author-handle-->@zhengp0<!--end-author-handle-- (Peng Zheng) Repository: https://github.com/ihmeuw-msca/xspline Branch with paper.md (empty if default branch): main Version: v0.1.1 Editor: Pending Reviewers: Pending Managing EiC: Chris Vernon

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/4b18db5c9a2a065af2dcf51e901a9deb"><img src="https://joss.theoj.org/papers/4b18db5c9a2a065af2dcf51e901a9deb/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/4b18db5c9a2a065af2dcf51e901a9deb/status.svg)](https://joss.theoj.org/papers/4b18db5c9a2a065af2dcf51e901a9deb)

Author instructions

Thanks for submitting your paper to JOSS @zhengp0. Currently, there isn't a JOSS editor assigned to your paper.

@zhengp0 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 6 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 6 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.02 s (1641.1 files/s, 105823.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          14            265            389            627
TeX                              1             19              0            252
Markdown                         3             70              0            155
YAML                             2              5              0             66
reStructuredText                 9             50             89             39
DOS Batch                        1              8              1             26
TOML                             1              3              0             24
CSS                              1              3              1             16
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            33            427            487           1214
-------------------------------------------------------------------------------

Commit count by author:

    60  zhengp0
    23  Peng
    13  zhengp
     7  Peng Zheng
editorialbot commented 6 months ago

Paper file info:

📄 Wordcount for paper.md is 819

✅ The paper includes a Statement of need section

editorialbot commented 6 months ago

License info:

✅ License found: BSD 2-Clause "Simplified" License (Valid open source OSI approved license)

editorialbot commented 6 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/s10182-019-00359-z is OK
- 10.1109/ACCESS.2018.2886528 is OK
- 10.48550/arXiv.2205.06925 is OK
- 10.48550/arXiv.2209.10575 is OK
- 10.1109/tsp.2019.2946029 is OK
- 10.1016/S0140-6736(20)30752-2 is OK
- 10.1080/10618600.2013.773239 is OK
- 10.1109/TCYB.2020.2982445 is OK
- 10.1016/j.procs.2016.07.111 is OK
- 10.1007/s00162-020-00529-9 is OK
- 10.48550/arXiv.1911.05182 is OK
- 10.48550/arXiv.1309.0238 is OK
- 10.1111/j.1467-9469.2011.00740.x is OK

MISSING DOIs

- 10.1038/s41467-024-45074-9 may be a valid DOI for title: Health effects associated with chewing tobacco: a ...
- No DOI given, and none found for title: Effects of education on adult mortality: a global ...
- No DOI given, and none found for title: Health effects associated with exposure to secondh...
- No DOI given, and none found for title: Health effects associated with exposure to intimat...
- No DOI given, and none found for title: Health effects associated with smoking: a Burden o...
- 10.1038/s41591-022-01974-1 may be a valid DOI for title: Effects of elevated systolic blood pressure on isc...
- No DOI given, and none found for title: Health effects associated with vegetable consumpti...
- 10.1038/s41591-022-01968-z may be a valid DOI for title: Health effects associated with consumption of unpr...
- No DOI given, and none found for title: The Burden of Proof studies: assessing the evidenc...
- No DOI given, and none found for title: A practical guide to splines
- 10.1088/1742-6596/1669/1/012032 may be a valid DOI for title: Splipy: B-spline and NURBS modelling in python
- 10.1080/10618600.2020.1868303 may be a valid DOI for title: Trimmed constrained mixed effects models: formulat...

INVALID DOIs

- None
editorialbot commented 6 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

crvernon commented 6 months ago

@editorialbot query scope

@zhengp0 — Thanks for your submission! Given the small size of this code base, I have submitted this pre-review for editorial review with respect to the substantial scholarly effort. This usually takes a week or two and I'll report back here as soon as I hear back from the rest of the editorial board.

editorialbot commented 6 months ago

Submission flagged for editorial review.

crvernon commented 6 months ago

@editorialbot reject

👋 @zhengp0 — Thank you for submitting your software to JOSS. At this time, I unfortunately have to reject your submission.

The editors have decided that the small codebase size of your submission fails to meet the substantial scholarly effort requirements for publication in JOSS.

We wish you the best in your research!

editorialbot commented 6 months ago

Paper rejected.