search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
694 stars 36 forks source link

[PRE REVIEW]: pref_voting: The Preferential Voting Tools package for Python #6681

Open editorialbot opened 2 months ago

editorialbot commented 2 months ago

Submitting author: !--author-handle-->@epacuit<!--end-author-handle-- (Eric Pacuit) Repository: https://github.com/voting-tools/pref_voting Branch with paper.md (empty if default branch): Version: v1.0.0 Editor: !--editor-->@britta-wstnr<!--end-editor-- Reviewers: Pending Managing EiC: Olivia Guest

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/9e563a36771efcb2f68f679b25ae2ea6"><img src="https://joss.theoj.org/papers/9e563a36771efcb2f68f679b25ae2ea6/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/9e563a36771efcb2f68f679b25ae2ea6/status.svg)](https://joss.theoj.org/papers/9e563a36771efcb2f68f679b25ae2ea6)

Author instructions

Thanks for submitting your paper to JOSS @epacuit. Currently, there isn't a JOSS editor assigned to your paper.

@epacuit if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). You can search the list of people that have already agreed to review and may be suitable for this submission.

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
editorialbot commented 2 months ago

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf
editorialbot commented 2 months ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.16 s (791.8 files/s, 165123.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          81           5318           5039          12098
Markdown                        34           1278              0           1552
TeX                              1             47              0            267
YAML                             2              8             17             30
TOML                             1              3              0             27
DOS Batch                        1              8              1             26
reStructuredText                 2             36             56             24
make                             1              4              7              9
JSON                             1              0              0              3
-------------------------------------------------------------------------------
SUM:                           124           6702           5120          14036
-------------------------------------------------------------------------------

Commit count by author:

   194  Eric Pacuit
   148  Wesley H. Holliday
     6  Dominik Peters
editorialbot commented 2 months ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1007/978-3-319-91908-9_4 is OK
- 10.1016/s1574-0110(02)80008-x is OK
- 10.1007/978-1-4020-9688-4_14 is OK
- 10.1007/978-3-642-20441-8_3 is OK
- 10.1007/s00355-015-0909-0 is OK
- 10.1007/978-3-662-09925-4 is OK
- 10.21105/joss.04880 is OK
- 10.1007/978-3-642-41575-3_20 is OK
- 10.1007/978-3-662-03782-9 is OK
- 10.1017/cbo9780511614316 is OK
- 10.4324/9781315259963 is OK
- 10.1017/cbo9781107446984.003 is OK

MISSING DOIs

- 10.12987/9780300186987 may be a valid DOI for title: Social Choice and Individual Values
- No DOI given, and none found for title: Social welfare functionals and interpersonal compa...
- No DOI given, and none found for title: Guide to Numerical Experiments on Elections in Com...
- 10.7551/mitpress/9780262015134.003.0018 may be a valid DOI for title: Approval Voting
- No DOI given, and none found for title: Majority Judgement: Measuring, Ranking and Electin...
- No DOI given, and none found for title: Handbook of Computational Social Choice
- 10.1093/oso/9780190934163.003.0003 may be a valid DOI for title: Voting Procedures
- No DOI given, and none found for title: The Theory of Social Choice
- No DOI given, and none found for title: Computer-aided Methods for Social Choice Theory
- No DOI given, and none found for title: Rolling the dice: Recent results in probabilistic ...
- 10.2307/1911681 may be a valid DOI for title: Manipulation of Schemes that Mix Voting with Chanc...
- No DOI given, and none found for title: Learning to Manipulate under Limited Information
- No DOI given, and none found for title: Making Multicandidate Elections More Democratic
- No DOI given, and none found for title: A Unified Theory of Voting: Directional and Proxim...
- 10.1007/978-94-009-3985-1 may be a valid DOI for title: Comparing Voting Systems
- No DOI given, and none found for title: Voting Methods
- No DOI given, and none found for title: Collective Choice and Social Welfare: An Expanded ...
- No DOI given, and none found for title: Votelib: Evaluation of voting systems in Python
- No DOI given, and none found for title: Pref.Tools: Tools that are useful for analyzing pr...
- No DOI given, and none found for title: abif
- No DOI given, and none found for title: VoteKit

INVALID DOIs

- None
editorialbot commented 2 months ago

Paper file info:

📄 Wordcount for paper.md is 1077

✅ The paper includes a Statement of need section

editorialbot commented 2 months ago

License info:

✅ License found: MIT License (Valid open source OSI approved license)

editorialbot commented 2 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

crvernon commented 1 month ago

:wave: @epacuit - the editor best suited to take this on is currently occupied with other reviews right now. We are going to waitlist this submission and we will get this assigned ASAP! Thank you for your patience!

epacuit commented 1 month ago

Sounds good. Thanks for the update!

crvernon commented 2 weeks ago

@editorialbot invite @britta-wstnr as editor

:wave: @britta-wstnr - I know we have another close to wrapping up. Do you mind taking this one on as editor?

crvernon commented 2 weeks ago

@editorialbot invite @britta-wstnr as editor

editorialbot commented 2 weeks ago

Invitation to edit this submission sent!

arfon commented 2 weeks ago

@editorialbot generate pdf

☝ to generate the most similar paper recommendation list which has been broken for some time.

editorialbot commented 2 weeks ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 2 weeks ago

Five most similar historical JOSS papers:

Prest: Open-Source Software for Computational Revealed Preference Analysis Submitting author: @georgiosgerasimou Handling editor: @arfon (Active) Reviewers: @HaoZeke Similarity score: 0.8316

PyEI: A Python package for ecological inference Submitting author: @karink520 Handling editor: @drvinceknight (Active) Reviewers: @matt-graham, @pmyteh Similarity score: 0.8175

electiondata: a Python package for consolidating, checking, analyzing, visualizing and exporting election results Submitting author: @sfsinger19103 Handling editor: @ajstewartlang (Active) Reviewers: @vaneseltine, @andrewheiss Similarity score: 0.8124

samplics: a Python Package for selecting, weighting and analyzing data from complex sampling designs. Submitting author: @MamadouSDiallo Handling editor: @arfon (Active) Reviewers: @rchew, @soodoku Similarity score: 0.7968

coalitions: Coalition probabilities in multi-party democracies Submitting author: @adibender Handling editor: @leeper (Retired) Reviewers: @fsolt Similarity score: 0.7916

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

britta-wstnr commented 1 week ago

Hi @crvernon 👋 Apologies again for my late reply, I was out sick. I could take this over (I have space freeing up) - but I would like to note that this is quite far out my expertise in terms of content (voting theory) ...

crvernon commented 1 week ago

@editorialbot add @britta-wstnr as editor

Thanks so much @britta-wstnr! I know it was a bit out of subject for you so I really appreciate you taking this one on!

editorialbot commented 1 week ago

Assigned! @britta-wstnr is now the editor

britta-wstnr commented 1 week ago

Hi @epacuit 👋 I will be handling your submission. - I will start inviting reviewers soon, if you have any ideas for potential reviewers, you can suggest them here --- please read the guidelines in the editorialbot's first comment on how to search for reviewers and how to mention them here (don't "@" them, please).

I will be back shortly! 🙂 🌱

britta-wstnr commented 1 week ago

PS: @epacuit our trusty editorialbot has flagged a few DOIs as missing in your paper, see here. Can you have a look?

epacuit commented 1 week ago

@britta-wstnr: We have updated all of the DOIs in the article:

Fixed

Added a DOI

No DOI, but added link to the article on arXiv

Fixe

Added a DOI

Added a DOI

This is not the correct DOI for our citation. There is no DOI for this book.

Added a DOI

Added a link to the paper (there is no DOI for this article).

Added a link to the paper (there is no DOI for this article).

Fixed

Added a link to the paper on arXiv (there is no DOI for this article).

DOI added

DOI added

Fixed

There is no DOI for this article, but a link to the online article is provided.

DOI added.

There is no DOI for this, but a link to the GitHub repository is provide.

There is no DOI for this, but a link to the website is provided.

There is no DOI for this, but a link to the GitHub repository is provided.

There is no DOI for this, but a link to the GitHub repository is provided.

britta-wstnr commented 6 days ago

@editorialbot check references

editorialbot commented 6 days ago 
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.12987/9780300186987 is OK
- 10.1016/S1574-0110(02)80014-5 is OK
- 10.1007/978-3-319-91908-9_4 is OK
- 10.1016/S1574-0110(02)80008-X is OK
- 10.7551/mitpress/9780262015134.003.0001 is OK
- 10.1017/CBO9781107446984 is OK
- 10.1007/978-1-4020-9688-4_14 is OK
- 10.1007/978-3-642-20441-8_3 is OK
- 10.1515/9781400868339 is OK
- 10.2307/1911681 is OK
- 10.1007/s00355-015-0909-0 is OK
- 10.1007/978-3-662-09925-4 is OK
- 10.21105/joss.04880 is OK
- 10.1007/978-3-642-41575-3_20 is OK
- 10.1515/9781400859504 is OK
- 10.1017/CBO9780511605864 is OK
- 10.1007/978-94-009-3985-1 is OK
- 10.1007/978-3-662-03782-9 is OK
- 10.4159/9780674974616 is OK
- 10.1017/cbo9780511614316 is OK
- 10.4324/9781315259963 is OK
- 10.1017/cbo9781107446984.003 is OK

MISSING DOIs

- No DOI given, and none found for title: Guide to Numerical Experiments on Elections in Com...
- 10.1093/oso/9780190934163.003.0003 may be a valid DOI for title: Voting Procedures
- No DOI given, and none found for title: Computer-aided Methods for Social Choice Theory
- No DOI given, and none found for title: Rolling the dice: Recent results in probabilistic ...
- No DOI given, and none found for title: Learning to Manipulate under Limited Information
- No DOI given, and none found for title: Voting Methods
- No DOI given, and none found for title: Votelib: Evaluation of voting systems in Python
- No DOI given, and none found for title: Pref.Tools: Tools that are useful for analyzing pr...
- No DOI given, and none found for title: abif
- No DOI given, and none found for title: VoteKit

INVALID DOIs

- https://doi.org/10.1007/978-0-387-49896-6 is INVALID because of 'https://doi.org/' prefix
britta-wstnr commented 6 days ago

@editorialbot generate pdf

editorialbot commented 6 days ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

editorialbot commented 6 days ago

Five most similar historical JOSS papers:

PyEI: A Python package for ecological inference Submitting author: @karink520 Handling editor: @drvinceknight (Active) Reviewers: @matt-graham, @pmyteh Similarity score: 0.7382

electiondata: a Python package for consolidating, checking, analyzing, visualizing and exporting election results Submitting author: @sfsinger19103 Handling editor: @ajstewartlang (Active) Reviewers: @vaneseltine, @andrewheiss Similarity score: 0.7292

bwsample: Processing Best-Worst Scaling data Submitting author: @ulf1 Handling editor: @mikldk (Retired) Reviewers: @ejhigson, @jakryd Similarity score: 0.7122

IDCeMPy: Python Package for Inflated Discrete Choice Models Submitting author: @hknd23 Handling editor: @galessiorob (Active) Reviewers: @cmaimone, @jungtaekkim, @tmickleydoyle Similarity score: 0.6990

Prest: Open-Source Software for Computational Revealed Preference Analysis Submitting author: @georgiosgerasimou Handling editor: @arfon (Active) Reviewers: @HaoZeke Similarity score: 0.6982

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before considering asking the reviewers of these papers to review again for JOSS.

britta-wstnr commented 6 days ago

Thanks for checking the DOIs, @epacuit

I reached out to a couple of potential reviewers via email. @epacuit if you can recommend additional reviewers, that would be great as this is not directly my own field. For instruction on that, see here

epacuit commented 5 days ago

Here are two people that seem like they might be good reviewers:

Stephen Francis Mann: https://reviewers.joss.theoj.org/reviewers/3439 Maximilian Stahlberg: https://reviewers.joss.theoj.org/reviewers/1964

Another suggestion from the computational social choice community is Martin Lackner (https://martin.lackner.xyz/). He is the main developer for the abcvoting package (https://abcvoting.readthedocs.io/en/latest/index.html), which is a related Python package, with a JOSS paper: https://joss.theoj.org/papers/10.21105/joss.04880

Some additional suggestions are the reviewers for the abcvoting JOSS paper:

Stefan McCabe: https://github.com/sdmccabe Christopher Barrie: https://github.com/cjbarrie

Another suggestion from the computational social choice community is Dominik Peters (https://dominik-peters.de/).

britta-wstnr commented 1 hour ago

Thanks for the list @epacuit - I really appreciate it! I am still in the process of contacting reviewers.

@dmnapolitano has agreed via email to review this submission - thanks a lot! As mentioned, the review will start once a sufficient number of reviewers are found.

Viech commented 1 hour ago

Maximilian Stahlberg here. I'm always happy to review for JOSS but my defense is coming up, so I will only be available from the 25th onward. If you are still short by then, don't hesitate to give me another ping!

britta-wstnr commented 1 hour ago

Hi @Viech - thanks so much for your quick response to my email! Sounds great - and good luck with your defense! 🍀