search

openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[PRE REVIEW]: BioSigKit: A Matlab Toolbox and Interface for Analysis of BioSignals #669

Closed whedon closed 6 years ago

whedon commented 6 years ago

Submitting author: @hooman650 (Hooman Sedghamiz) Repository: https://github.com/hooman650/BioSigKit Version: V1.0.0 Editor: @Kevin-Mattheus-Moerman Reviewers: @marianux

Author instructions

Thanks for submitting your paper to JOSS @hooman650. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@hooman650 if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
whedon commented 6 years ago

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands
whedon commented 6 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 6 years ago

--> Check article proof :page_facing_up: <--

hooman650 commented 6 years ago

@whedon commands

whedon commented 6 years ago

Here are some things you can ask me to do:

# List all of Whedon's capabilities
@whedon commands

# Assign a GitHub user as the sole reviewer of this submission
@whedon assign @username as reviewer

# Add a GitHub user to the reviewers of this submission
@whedon add @username as reviewer

# Remove a GitHub user from the reviewers of this submission
@whedon remove @username as reviewer

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Change editorial assignment
@whedon assign @username as editor

# Set the software archive DOI at the top of the issue e.g.
@whedon set 10.0000/zenodo.00000 as archive

# Open the review issue
@whedon start review

🚧 🚧 🚧 Experimental Whedon features 🚧 🚧 🚧

# Compile the paper
@whedon generate pdf
hooman650 commented 6 years ago

@whedon generate pdf

whedon commented 6 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 6 years ago

--> Check article proof :page_facing_up: <--

hooman650 commented 6 years ago

@whedon generate pdf

whedon commented 6 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 6 years ago

--> Check article proof :page_facing_up: <--

hooman650 commented 6 years ago

@whedon generate pdf

whedon commented 6 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 6 years ago

--> Check article proof :page_facing_up: <--

hooman650 commented 6 years ago

@whedon generate pdf

whedon commented 6 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 6 years ago

--> Check article proof :page_facing_up: <--

hooman650 commented 6 years ago

@whedon generate pdf

whedon commented 6 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 6 years ago

--> Check article proof :page_facing_up: <--

hooman650 commented 6 years ago

@whedon generate pdf

whedon commented 6 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 6 years ago

--> Check article proof :page_facing_up: <--

hooman650 commented 6 years ago

@whedon generate pdf

whedon commented 6 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 6 years ago

--> Check article proof :page_facing_up: <--

hooman650 commented 6 years ago

@whedon generate pdf

whedon commented 6 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 6 years ago

--> Check article proof :page_facing_up: <--

hooman650 commented 6 years ago

@whedon generate pdf

whedon commented 6 years ago 
Attempting PDF compilation. Reticulating splines etc...
whedon commented 6 years ago

--> Check article proof :page_facing_up: <--

hooman650 commented 6 years ago

Hi @Kevin-Mattheus-Moerman do you mind reviewing this paper?

hooman650 commented 6 years ago

Hi @cMadan do you mind reviewing this paper?

hooman650 commented 6 years ago

Hi, @arfon , whedon was not able to compile my .bib file properly, I attempted several times and the .bib file looks okay but the compiled pdf does not. Apologies if I was not supposed to rebuild the pdf...

Kevin-Mattheus-Moerman commented 6 years ago

@whedon assign @Kevin-Mattheus-Moerman as editor

whedon commented 6 years ago

OK, the editor is @Kevin-Mattheus-Moerman

Kevin-Mattheus-Moerman commented 6 years ago

@cMadan @keevindoherty @germangh @marianux would you be interested in reviewing this JOSS submission? Here is the article and this is the project repo. The review focuses largely on the software, see our review guidelines.

arfon commented 6 years ago

Hi, @arfon , whedon was not able to compile my .bib file properly, I attempted several times and the .bib file looks okay but the compiled pdf does not. Apologies if I was not supposed to rebuild the pdf...

@hooman650 - could you describe the problem? The PDF looks OK to me.

hooman650 commented 6 years ago

@arfon - the name of the author is missing in one of the references (the one prior to the last-"Complete PAn-Tompkins implemetation" )...

marianux commented 6 years ago

Yes, happy to review it. When is the deadline ?

Best, m.

2018-04-11 13:28 GMT-03:00 Kevin Mattheus Moerman notifications@github.com :

@cMadan https://github.com/cMadan @keevindoherty https://github.com/keevindoherty @germangh https://github.com/germangh @marianux https://github.com/marianux would you be interested in reviewing this JOSS http://joss.theoj.org/ submission? Here is the article https://github.com/openjournals/joss-papers/blob/joss.00669/joss.00669/10.21105.joss.00669.pdf and this is the project repo https://github.com/hooman650/BioSigKit. The review focuses largely on the software, see our review guidelines http://joss.theoj.org/about#reviewer_guidelines.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openjournals/joss-reviews/issues/669#issuecomment-380514350, or mute the thread https://github.com/notifications/unsubscribe-auth/AEMWNCUUx8sTfQAWHA14QdzXemGqBD_Iks5tni9IgaJpZM4TM9tN .

arfon commented 6 years ago

@arfon - the name of the author is missing in one of the references (the one prior to the last-"Complete PAn-Tompkins implemetation" )...

This is very strange. I have literally no idea what's going on here. I tried debugging this locally but couldn't easily fix. I suggest we proceed with the submission and revisit this later.

keevindoherty commented 6 years ago

Sorry, I don't think I could review this; I haven't been doing anything related to this space for a few years, and I'm a bit out of touch.

Kevin-Mattheus-Moerman commented 6 years ago

@whedon assign @marianux as reviewer

whedon commented 6 years ago

OK, the reviewer is @marianux

Kevin-Mattheus-Moerman commented 6 years ago

@keevindoherty I understand. Thanks for your reply

Kevin-Mattheus-Moerman commented 6 years ago

@whedon start review magic-word=bananas

whedon commented 6 years ago

OK, I've started the review over in https://github.com/openjournals/joss-reviews/issues/671. Feel free to close this issue now!

cMadan commented 6 years ago

@hooman650, @arfon - Isn't the reference/bib 'issue' just the replacement of a repeated author across references with the dash? (E.g., https://tex.stackexchange.com/questions/29381/is-it-normal-for-bibtex-to-replace-similar-author-names-with)

Is there something that I'm missing?

hooman650 commented 6 years ago

@cMadan Smart!Thanks! This is the first time I see something like this and you seem to be right! @arfon