[REVIEW]: scikit-eo: A Python package for Remote Sensing Data Analysis

editorialbot commented 5 months ago

Submitting author: !--author-handle-->@ytarazona@mikemahoney218<!--end-editor-- Reviewers: @dbuscombe-usgs, @KBodolai Archive: 10.5281/zenodo.12688708

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/46bccc5be81d7ea886e05807cfe6790c"><img src="https://joss.theoj.org/papers/46bccc5be81d7ea886e05807cfe6790c/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/46bccc5be81d7ea886e05807cfe6790c/status.svg)](https://joss.theoj.org/papers/46bccc5be81d7ea886e05807cfe6790c)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@dbuscombe-usgs & @KBodolai, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @mikemahoney218 know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @dbuscombe-usgs

📝 Checklist for @KBodolai

mikemahoney218 commented 2 months ago

@editorialbot generate pdf

editorialbot commented 2 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

mikemahoney218 commented 2 months ago

@yotarazona , looking closer at Figure 1, I think the main issue is that the figure is too wide for the paper format -- the aspect ratio is so wide (and relatively short), so when it gets automatically resized for the paper, the text gets a bit squashed and winds up looking a bit fuzzy and harder to read. If you wanted it to be more legible, I wonder if you'd be able to "rotate" the figure so that it's taller than it is wide -- ideally by changing the orientation of the flow chart, but also potentially by rotating the image in Photoshop or similar.

If you don't mind how Figure 1 looks, I suppose this doesn't need to be a blocker -- but I think it would improve the legibility for the final paper if the figure is a bit clearer!

mikemahoney218 commented 2 months ago

Also: opened https://github.com/yotarazona/scikit-eo/pull/24, https://github.com/yotarazona/scikit-eo/pull/25, https://github.com/yotarazona/scikit-eo/pull/26 to fix bibtex issues

yotarazona commented 2 months ago

Hi @mikemahoney218, a new workflow was uploaded in the paper folder: https://github.com/yotarazona/scikit-eo/blob/main/paper/workflow_updated.png.

Open issues were merged as well. Thanks for that!

mikemahoney218 commented 2 months ago

@editorialbot generate pdf

mikemahoney218 commented 2 months ago

@yotarazona I see the new figure is uploaded -- would you be able to change paper.md so that it uses the new figure?

editorialbot commented 2 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

yotarazona commented 2 months ago

@mikemahoney218 done!. Let me know if you need anything else.

mikemahoney218 commented 2 months ago

@editorialbot generate pdf

editorialbot commented 2 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

mikemahoney218 commented 2 months ago

🎉 With everything looking good on my end, it's time for me to hand this back to the EiC for last steps. Thanks @yotarazona for the submission, and thank you so much to @dbuscombe-usgs and @KBodolai for reviewing!

mikemahoney218 commented 2 months ago

@editorialbot recommend-accept

editorialbot commented 2 months ago

Attempting dry run of processing paper acceptance...

editorialbot commented 2 months ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1080/07038992.2021.1941823 is OK
- 10.1016/j.rsase.2020.100337 is OK
- 10.1016/j.ecolind.2018.07.012 is OK
- 10.1016/j.rse.2014.02.015 is OK
- 10.1016/j.isprsjprs.2021.04.015 is OK
- 10.3390/rs12183062 is OK
- 10.1080/10095020.2019.1710438 is OK
- 10.1038/nclimate1908 is OK
- 10.1038/s41559-022-01702-5 is OK
- 10.1016/J.RSE.2021.112577 is OK
- 10.5281/ZENODO.3233986 is OK
- 10.1038/s41558-017-0049-x is OK
- 10.1038/s41586-021-03436-z is OK

MISSING DOIs

- None

INVALID DOIs

- None

mikemahoney218 commented 2 months ago

(And as one brief note: Kristen, our EiC, is at SciPy this week, so there may be a bit of a delay before she's able to process this submission -- just so you know!)

editorialbot commented 2 months ago

:wave: @openjournals/ese-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5596, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

kthyng commented 2 months ago

Hi! I'll take over now as Track Associate Editor in Chief to do some final submission editing checks. After these checks are complete, I will publish your submission!

[x] Are checklists all checked off?
[x] Check that version was updated and make sure the version from JOSS matches github and Zenodo.
[x] Check that software archive exists, has been input to JOSS, and title and author list match JOSS paper (or purposefully do not).
[x] Check paper.

kthyng commented 2 months ago

@editorialbot accept

everything was ready to go!

editorialbot commented 2 months ago

Doing it live! Attempting automated processing of paper acceptance...

editorialbot commented 2 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Tarazona given-names: Yonatan orcid: "https://orcid.org/0000-0002-5208-1004" - family-names: Benitez-Paez given-names: Fernando orcid: "https://orcid.org/0000-0002-9884-6471" - family-names: Nowosad given-names: Jakub orcid: "https://orcid.org/0000-0002-1057-3721" - family-names: Drenkhan given-names: Fabian orcid: "https://orcid.org/0000-0002-9443-9596" - family-names: Timaná given-names: Martín E. orcid: "https://orcid.org/0000-0003-1559-4449" doi: 10.5281/zenodo.12688708 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Tarazona given-names: Yonatan orcid: "https://orcid.org/0000-0002-5208-1004" - family-names: Benitez-Paez given-names: Fernando orcid: "https://orcid.org/0000-0002-9884-6471" - family-names: Nowosad given-names: Jakub orcid: "https://orcid.org/0000-0002-1057-3721" - family-names: Drenkhan given-names: Fabian orcid: "https://orcid.org/0000-0002-9443-9596" - family-names: Timaná given-names: Martín E. orcid: "https://orcid.org/0000-0003-1559-4449" date-published: 2024-07-16 doi: 10.21105/joss.06692 issn: 2475-9066 issue: 99 journal: Journal of Open Source Software publisher: name: Open Journals start: 6692 title: "scikit-eo: A Python package for Remote Sensing Data Analysis" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06692" volume: 9 title: "scikit-eo: A Python package for Remote Sensing Data Analysis" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 2 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 2 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5636
Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06692
If everything looks good, then close this review issue.
Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

kthyng commented 2 months ago

Congratulations on your new publication @ytarazona! Many thanks to @mikemahoney218 and to reviewers @dbuscombe-usgs and @KBodolai for your time, hard work, and expertise!! JOSS wouldn't be able to function nor succeed without your efforts.

editorialbot commented 2 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06692/status.svg)](https://doi.org/10.21105/joss.06692)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06692">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06692/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06692/status.svg
   :target: https://doi.org/10.21105/joss.06692

This is how it will look in your documentation:

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

Volunteering to review for us sometime in the future. You can add your name to the reviewer list here: https://reviewers.joss.theoj.org/join
Making a small donation to support our running costs here: https://numfocus.org/donate-to-joss

kthyng commented 2 months ago

@yotarazona If you're interested in joining as a reviewer, please register here: https://reviewers.joss.theoj.org/!

yotarazona commented 2 months ago

Congratulations on your new publication @ytarazona! Many thanks to @mikemahoney218 and to reviewers @dbuscombe-usgs and @KBodolai for your time, hard work, and expertise!! JOSS wouldn't be able to function nor succeed without your efforts.

Thank you so much @kthyng, @mikemahoney218, @dbuscombe-usgs and @KBodolai for your time and effort during this process!. Hard work for everyone!. Thanks a lot. A hug!.

yotarazona commented 2 months ago

@yotarazona If you're interested in joining as a reviewer, please register here: https://reviewers.joss.theoj.org/!

Thanks @kthyng for this invitation!. Done :)

openjournals / joss-reviews