[REVIEW]: movement_primitives: Imitation Learning of Cartesian Motion with Movement Primitives

editorialbot commented 2 weeks ago

Submitting author: !--author-handle-->@AlexanderFabisch@ymzayek<!--end-editor-- Reviewers: @ishaanamahajan, @gautam-sharma1 Archive: Pending

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/4d348048fb0c9a972bbdd90965b23a79"><img src="https://joss.theoj.org/papers/4d348048fb0c9a972bbdd90965b23a79/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/4d348048fb0c9a972bbdd90965b23a79/status.svg)](https://joss.theoj.org/papers/4d348048fb0c9a972bbdd90965b23a79)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@ishaanamahajan & @gautam-sharma1, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @ymzayek know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

📝 Checklist for @gautam-sharma1

📝 Checklist for @ishaanamahajan

editorialbot commented 2 weeks ago

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

editorialbot commented 2 weeks ago

Software report:

github.com/AlDanial/cloc v 1.90  T=0.12 s (995.4 files/s, 147075.2 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          97           2563           3218           7056
XML                              9              3             18           2482
Markdown                         3            147              0            542
Cython                           1            179            286            422
TeX                              1             22              0            228
reStructuredText                 2             59             77             31
YAML                             1              4              2             28
DOS Batch                        1              8              1             26
make                             1              4              7              9
Dockerfile                       1              2              3              5
TOML                             1              0              0              3
-------------------------------------------------------------------------------
SUM:                           118           2991           3612          10832
-------------------------------------------------------------------------------

Commit count by author:

   663  Alexander Fabisch
    17  jklemm
     3  Marc Otto
     2  wood
     1  Baptiste Busch
     1  Enrico Eberhard
     1  mulo01

editorialbot commented 2 weeks ago

Paper file info:

📄 Wordcount for paper.md is 2195

✅ The paper includes a Statement of need section

editorialbot commented 2 weeks ago

License info:

🟡 License found: Other (Check here for OSI approval)

editorialbot commented 2 weeks ago

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1109/ROBOT.2002.1014739 is OK
- 10.1109/ROBOT.2009.5152385 is OK
- 10.1162/NECO_a_00393 is OK
- 10.1177/0278364912472380 is OK
- 10.1109/IROS.2013.6697172 is OK
- 10.1109/ICRA.2014.6907291 is OK
- 10.1007/s10514-016-9556-2 is OK
- 10.1007/s10514-017-9648-7 is OK
- 10.21105/joss.01159 is OK
- 10.1177/02783649231201196 is OK
- 10.21105/joss.01225 is OK
- 10.1177/1729881420913741 is OK
- 10.21105/joss.03054 is OK
- 10.1016/j.robot.2021.103779 is OK
- 10.26092/elib/1547 is OK
- 10.1038/s41586-020-2649-2 is OK
- 10.1109/ICRA46639.2022.9811843 is OK
- 10.1109/MCSE.2010.118 is OK

MISSING DOIs

- No DOI given, and none found for title: Active Contextual Policy Search
- No DOI given, and none found for title: Probabilistic Movement Primitives
- No DOI given, and none found for title: Open3D: A Modern Library for 3D Data Processing
- No DOI given, and none found for title: PyBullet, a Python module for physics simulation f...

INVALID DOIs

- None

editorialbot commented 2 weeks ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

ymzayek commented 2 weeks ago

@gautam-sharma1 and @ishaanamahajan - Dear reviewers, you can start your review by creating your tasklist with the following command:

@editorialbot generate my checklist

In that list, there are several tasks. Whenever you perform a task, you can check on the corresponding checkbox. You can also reference the JOSS reviewer guidelines which is linked in first comment in this thread. Since the review process of JOSS is interactive, you can always interact with the author, the other reviewers, and the editor during the process. You can open issues and pull requests in the target repo. Please mention the url of this page in there so that we can keep tracking what is going on.

Thank you in advance.

gautam-sharma1 commented 1 week ago

Review checklist for @gautam-sharma1

Conflict of interest

[x] I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

[x] I confirm that I read and will adhere to the JOSS code of conduct.

General checks

[x] Repository: Is the source code for this software available at the https://github.com/dfki-ric/movement_primitives/?
[x] License: Does the repository contain a plain-text LICENSE or COPYING file with the contents of an OSI approved software license?
[x] Contribution and authorship: Has the submitting author (@AlexanderFabisch) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
[x] Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
[x] Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
[x] Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
[x] Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

[x] Installation: Does installation proceed as outlined in the documentation?
[ ] Functionality: Have the functional claims of the software been confirmed?
[ ] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

[ ] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[x] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
[x] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
[x] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
[x] Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
[x] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

[ ] Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
[ ] A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
[x] State of the field: Do the authors describe how this software compares to other commonly-used packages?
[x] Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
[x] References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

gautam-sharma1 commented 1 week ago

Created an issue related to test (https://github.com/dfki-ric/movement_primitives/issues/42), author resolved it, so marking tests as complete.

gautam-sharma1 commented 1 week ago

Created few issues in the main repo:

ymzayek commented 1 week ago

@ishaanamahajan let me know if you are able to get started on this soon. Thanks!

ishaanamahajan commented 1 week ago

@ishaanamahajan let me know if you are able to get started on this soon. Thanks!

I will be able to get started on it this weekend, hope that is fine.

ymzayek commented 1 week ago

@ishaanamahajan great thanks for the update!

ishaanamahajan commented 3 days ago

Review checklist for @ishaanamahajan

Conflict of interest

[x] I confirm that I have read the JOSS conflict of interest (COI) policy and that: I have no COIs with reviewing this work or that any perceived COIs have been waived by JOSS for the purpose of this review.

Code of Conduct

[x] I confirm that I read and will adhere to the JOSS code of conduct.

General checks

[x] Repository: Is the source code for this software available at the https://github.com/dfki-ric/movement_primitives/?
[x] License: Does the repository contain a plain-text LICENSE or COPYING file with the contents of an OSI approved software license?
[x] Contribution and authorship: Has the submitting author (@AlexanderFabisch) made major contributions to the software? Does the full list of paper authors seem appropriate and complete?
[x] Substantial scholarly effort: Does this submission meet the scope eligibility described in the JOSS guidelines
[x] Data sharing: If the paper contains original data, data are accessible to the reviewers. If the paper contains no original data, please check this item.
[x] Reproducibility: If the paper contains original results, results are entirely reproducible by reviewers. If the paper contains no original results, please check this item.
[x] Human and animal research: If the paper contains original data research on humans subjects or animals, does it comply with JOSS's human participants research policy and/or animal research policy? If the paper contains no such data, please check this item.

Functionality

[x] Installation: Does installation proceed as outlined in the documentation?
[ ] Functionality: Have the functional claims of the software been confirmed?
[ ] Performance: If there are any performance claims of the software, have they been confirmed? (If there are no claims, please check off this item.)

Documentation

[ ] A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
[ ] Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
[x] Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
[x] Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g., API method documentation)?
[ ] Automated tests: Are there automated tests or manual steps described so that the functionality of the software can be verified?
[x] Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

[ ] Summary: Has a clear description of the high-level functionality and purpose of the software for a diverse, non-specialist audience been provided?
[ ] A statement of need: Does the paper have a section titled 'Statement of need' that clearly states what problems the software is designed to solve, who the target audience is, and its relation to other work?
[ ] State of the field: Do the authors describe how this software compares to other commonly-used packages?
[ ] Quality of writing: Is the paper well written (i.e., it does not require editing for structure, language, or writing quality)?
[ ] References: Is the list of references complete, and is everything cited appropriately that should be cited (e.g., papers, datasets, software)? Do references in the text use the proper citation syntax?

ymzayek commented 19 hours ago

Hi, just checking in to see if there are any updates on the review status. Let me know if I can be of any help.

openjournals / joss-reviews