openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[REVIEW]: naturf: a package for generating urban parameters for numerical weather modeling #6712

Closed editorialbot closed 6 months ago

editorialbot commented 7 months ago

Submitting author: !--author-handle-->@levisweetbreu<!--end-author-handle-- (Levi Sweet-Breu) Repository: https://github.com/IMMM-SFA/naturf.git Branch with paper.md (empty if default branch): Version: v1.0.3 Editor: !--editor-->@cheginit<!--end-editor-- Reviewers: @praneethd7, @caimeng2 Archive: 10.5281/zenodo.11454159

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/e52937327089a970773a331a5cf643fd"><img src="https://joss.theoj.org/papers/e52937327089a970773a331a5cf643fd/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/e52937327089a970773a331a5cf643fd/status.svg)](https://joss.theoj.org/papers/e52937327089a970773a331a5cf643fd)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@praneethd7 & @caimeng2, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @cheginit know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

πŸ“ Checklist for @praneethd7

πŸ“ Checklist for @caimeng2

kthyng commented 6 months ago

Ok looks good!

kthyng commented 6 months ago

@editorialbot accept

editorialbot commented 6 months ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 6 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Sweet-Breu given-names: Levi T. orcid: "https://orcid.org/0000-0003-3325-8086" - family-names: Rexer given-names: Em orcid: "https://orcid.org/0000-0002-0327-183X" - family-names: Vernon given-names: Chris R. orcid: "https://orcid.org/0000-0002-3406-6214" - family-names: Allen-Dumas given-names: Melissa R. orcid: "https://orcid.org/0000-0002-3319-0846" - family-names: Krawczyk given-names: Stefan orcid: "https://orcid.org/0009-0006-1112-1459" doi: 10.5281/zenodo.11454159 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Sweet-Breu given-names: Levi T. orcid: "https://orcid.org/0000-0003-3325-8086" - family-names: Rexer given-names: Em orcid: "https://orcid.org/0000-0002-0327-183X" - family-names: Vernon given-names: Chris R. orcid: "https://orcid.org/0000-0002-3406-6214" - family-names: Allen-Dumas given-names: Melissa R. orcid: "https://orcid.org/0000-0002-3319-0846" - family-names: Krawczyk given-names: Stefan orcid: "https://orcid.org/0009-0006-1112-1459" date-published: 2024-06-06 doi: 10.21105/joss.06712 issn: 2475-9066 issue: 98 journal: Journal of Open Source Software publisher: name: Open Journals start: 6712 title: "naturf: a package for generating urban parameters for numerical weather modeling" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06712" volume: 9 title: "naturf: a package for generating urban parameters for numerical weather modeling" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 6 months ago

🐘🐘🐘 πŸ‘‰ Toot for this paper πŸ‘ˆ 🐘🐘🐘

editorialbot commented 6 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5463
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06712
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! πŸŽ‰πŸŒˆπŸ¦„πŸ’ƒπŸ‘»πŸ€˜

Any issues? Notify your editorial technical team...

kthyng commented 6 months ago

Congratulations on your new publication @levisweetbreu! Many thanks to @cheginit and to reviewers @praneethd7 and @caimeng2 for your time, hard work, and expertise!! JOSS wouldn't be able to function nor succeed without your efforts.

editorialbot commented 6 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06712/status.svg)](https://doi.org/10.21105/joss.06712)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06712">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06712/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06712/status.svg
   :target: https://doi.org/10.21105/joss.06712

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

kthyng commented 6 months ago

@levisweetbreu If you're interested in helping JOSS as a reviewer, please sign up at https://reviewers.joss.theoj.org/!