openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
725 stars 38 forks source link

[REVIEW]: Catalyst: a Python JIT compiler for auto-differentiable hybrid quantum programs #6720

Closed editorialbot closed 4 months ago

editorialbot commented 7 months ago

Submitting author: !--author-handle-->@josh146<!--end-author-handle-- (Joshua Izaac) Repository: https://github.com/PennyLaneAI/catalyst Branch with paper.md (empty if default branch): joss-paper Version: v0.7.0 Editor: !--editor-->@danielskatz<!--end-editor-- Reviewers: @pmcao, @otbrown Archive: 10.5281/zenodo.12696447

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/b3f1cdf932e9d3f5725e3957d84f8fee"><img src="https://joss.theoj.org/papers/b3f1cdf932e9d3f5725e3957d84f8fee/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/b3f1cdf932e9d3f5725e3957d84f8fee/status.svg)](https://joss.theoj.org/papers/b3f1cdf932e9d3f5725e3957d84f8fee)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@pmcao & @otbrown, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @danielskatz know.

✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨

Checklists

πŸ“ Checklist for @otbrown

πŸ“ Checklist for @pmcao

josh146 commented 5 months ago

@editorialbot check references

josh146 commented 5 months ago

@editorialbot generate pdf

editorialbot commented 5 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/arXiv.1811.04968 is OK
- 10.5281/zenodo.6385575 is OK
- 10.1088/1367-2630/18/2/023023 is OK
- 10.48550/arXiv.1411.4028 is OK
- 10.1103/physreva.104.052402 is OK
- 10.1109/CGO.2004.1281665 is OK
- 10.1109/CGO51591.2021.9370308 is OK
- 10.1038/s41586-022-04725-x is OK
- 10.22331/q-2022-03-30-677 is OK
- 10.1103/physreva.99.032331 is OK
- 10.48550/arXiv.1810.08061 is OK

MISSING DOIs

- No DOI given, and none found for title: IBM Quantum Experience
- 10.1201/9781003374404-3 may be a valid DOI for title: Qiskit
- No DOI given, and none found for title: Cirq
- No DOI given, and none found for title: Amazon Braket
- No DOI given, and none found for title: JAX: composable transformations of Python+NumPy pr...
- No DOI given, and none found for title: PennyLane Lightning: fast state-vector simulators ...
- No DOI given, and none found for title:  Instead of Rewriting Foreign Code for Machine Lea...
- No DOI given, and none found for title: QIR Specification
- No DOI given, and none found for title: Efficient and modular implicit differentiation
- No DOI given, and none found for title: PennyLane Demos

INVALID DOIs

- None
editorialbot commented 5 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

josh146 commented 4 months ago

Hi @danielskatz, our release is now done so I can complete the process:

Make a tagged release of your software, and list the version tag of the archived version here.

The tag is v0.7.0, and it also has an associated release.

Archive the reviewed software in Zenodo or a similar service (e.g., figshare, an institutional repository). Please list the DOI of the archived version here.

The archived reviewed software is here: 10.5281/zenodo.12696447.

danielskatz commented 4 months ago

@editorialbot set 10.5281/zenodo.12696447 as archive

editorialbot commented 4 months ago

Done! archive is now 10.5281/zenodo.12696447

danielskatz commented 4 months ago

@editorialbot set v0.7.0 as version

editorialbot commented 4 months ago

Done! version is now v0.7.0

danielskatz commented 4 months ago

@editorialbot recommend-accept

editorialbot commented 4 months ago
Attempting dry run of processing paper acceptance...
editorialbot commented 4 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/arXiv.1811.04968 is OK
- 10.5281/zenodo.6385575 is OK
- 10.1088/1367-2630/18/2/023023 is OK
- 10.48550/arXiv.1411.4028 is OK
- 10.1103/physreva.104.052402 is OK
- 10.1109/CGO.2004.1281665 is OK
- 10.1109/CGO51591.2021.9370308 is OK
- 10.1038/s41586-022-04725-x is OK
- 10.22331/q-2022-03-30-677 is OK
- 10.1103/physreva.99.032331 is OK
- 10.48550/arXiv.1810.08061 is OK

MISSING DOIs

- No DOI given, and none found for title: IBM Quantum Experience
- 10.1201/9781003374404-3 may be a valid DOI for title: Qiskit
- No DOI given, and none found for title: Cirq
- No DOI given, and none found for title: Amazon Braket
- No DOI given, and none found for title: JAX: composable transformations of Python+NumPy pr...
- No DOI given, and none found for title: PennyLane Lightning: fast state-vector simulators ...
- No DOI given, and none found for title:  Instead of Rewriting Foreign Code for Machine Lea...
- No DOI given, and none found for title: QIR Specification
- No DOI given, and none found for title: Efficient and modular implicit differentiation
- No DOI given, and none found for title: PennyLane Demos

INVALID DOIs

- None
editorialbot commented 4 months ago

:wave: @openjournals/csism-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5591, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

danielskatz commented 4 months ago

@editorialbot accept

editorialbot commented 4 months ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 4 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Ittah given-names: David orcid: "https://orcid.org/0000-0003-0975-6448" - family-names: Asadi given-names: Ali - family-names: Lopez given-names: Erick Ochoa - family-names: Mironov given-names: Sergei - family-names: Banning given-names: Samuel - family-names: Moyard given-names: Romain orcid: "https://orcid.org/0000-0003-0837-6451" - family-names: Peng given-names: Mai Jacob orcid: "https://orcid.org/0000-0002-2377-264X" - family-names: Izaac given-names: Josh orcid: "https://orcid.org/0000-0003-2640-0734" contact: - family-names: Izaac given-names: Josh orcid: "https://orcid.org/0000-0003-2640-0734" doi: 10.5281/zenodo.12696447 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Ittah given-names: David orcid: "https://orcid.org/0000-0003-0975-6448" - family-names: Asadi given-names: Ali - family-names: Lopez given-names: Erick Ochoa - family-names: Mironov given-names: Sergei - family-names: Banning given-names: Samuel - family-names: Moyard given-names: Romain orcid: "https://orcid.org/0000-0003-0837-6451" - family-names: Peng given-names: Mai Jacob orcid: "https://orcid.org/0000-0002-2377-264X" - family-names: Izaac given-names: Josh orcid: "https://orcid.org/0000-0003-2640-0734" date-published: 2024-07-09 doi: 10.21105/joss.06720 issn: 2475-9066 issue: 99 journal: Journal of Open Source Software publisher: name: Open Journals start: 6720 title: "Catalyst: a Python JIT compiler for auto-differentiable hybrid quantum programs" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06720" volume: 9 title: "Catalyst: a Python JIT compiler for auto-differentiable hybrid quantum programs" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 4 months ago

🐘🐘🐘 πŸ‘‰ Toot for this paper πŸ‘ˆ 🐘🐘🐘

editorialbot commented 4 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5593
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06720
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! πŸŽ‰πŸŒˆπŸ¦„πŸ’ƒπŸ‘»πŸ€˜

Any issues? Notify your editorial technical team...

danielskatz commented 4 months ago

Congratulations to @josh146 (Joshua Izaac) and co-authors on your publication!!

And thanks to @pmcao and @otbrown for reviewing! JOSS depends on volunteers and couldn't succeed without you

editorialbot commented 4 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06720/status.svg)](https://doi.org/10.21105/joss.06720)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06720">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06720/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06720/status.svg
   :target: https://doi.org/10.21105/joss.06720

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

josh146 commented 4 months ago

thank you @danielskatz @pmcao @otbrown!