openjournals / joss-reviews

Reviews for the Journal of Open Source Software
Creative Commons Zero v1.0 Universal
721 stars 38 forks source link

[REVIEW]: OpenGeoSysUncertaintyQuantification.jl: a Julia library implementing an uncertainty quantification toolbox for OpenGeoSys #6725

Closed editorialbot closed 4 months ago

editorialbot commented 6 months ago

Submitting author: !--author-handle-->@baxmittens<!--end-author-handle-- (maximilian bittens) Repository: https://github.com/baxmittens/OpenGeoSysUncertaintyQuantification.jl Branch with paper.md (empty if default branch): Version: v0.1.6 Editor: !--editor-->@kanishkan91<!--end-editor-- Reviewers: @ziyiyin97, @dannys4 Archive: 10.5281/zenodo.11923516

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/58a9a8e2572ccdd13f109776b92ca3bd"><img src="https://joss.theoj.org/papers/58a9a8e2572ccdd13f109776b92ca3bd/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/58a9a8e2572ccdd13f109776b92ca3bd/status.svg)](https://joss.theoj.org/papers/58a9a8e2572ccdd13f109776b92ca3bd)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@ziyiyin97 & @dannys4, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review. First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @kanishkan91 know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

📝 Checklist for @ziyiyin97

📝 Checklist for @dannys4

editorialbot commented 4 months ago
Attempting dry run of processing paper acceptance...
editorialbot commented 4 months ago
Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.48550/arXiv.1509.01462 is OK
- 10.21105/joss.04300 is OK
- 10.21105/joss.05003 is OK
- 10.1007/s12665-012-1546-x is OK
- 10.5281/zenodo.2647458 is OK
- 10.5194/adgeo-56-67-2021 is OK
- 10.1007/s12665-023-11346-8 is OK

MISSING DOIs

- None

INVALID DOIs

- None
editorialbot commented 4 months ago

:wave: @openjournals/ese-eics, this paper is ready to be accepted and published.

Check final proof :point_right::page_facing_up: Download article

If the paper PDF and the deposit XML files look good in https://github.com/openjournals/joss-papers/pull/5510, then you can now move forward with accepting the submission by compiling again with the command @editorialbot accept

kthyng commented 4 months ago

Hi! I'll take over now as Track Associate Editor in Chief to do some final submission editing checks. After these checks are complete, I will publish your submission!

kthyng commented 4 months ago

@baxmittens Can you update the metadata on your Zenodo archive so the title and author list exactly match your JOSS paper? This is a request and not a requirement to make a cohesive archive with your paper publication.

kthyng commented 4 months ago

@baxmittens In your paper please check the capitalization in your references. You can preserve capitalization by placing {} around characters/words in your .bib file. For example, "julia" and "germany" are not capitalized; please check for others.

baxmittens commented 4 months ago

@editorialbot generate pdf

editorialbot commented 4 months ago

:point_right::page_facing_up: Download article proof :page_facing_up: View article proof on GitHub :page_facing_up: :point_left:

baxmittens commented 4 months ago

@dannys4 @ziyiyin97 Thank you for your review. The usability of my package has been greatly improved because of you guys. Appreciate it!

baxmittens commented 4 months ago

@kthyng I altered the Zenodo title and updated the capitalization in the references.

kthyng commented 4 months ago

Ok looks ready to go!

kthyng commented 4 months ago

@editorialbot accept

editorialbot commented 4 months ago
Doing it live! Attempting automated processing of paper acceptance...
editorialbot commented 4 months ago

Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository.

If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file.

You can copy the contents for your CITATION.cff file here:

CITATION.cff

``` cff-version: "1.2.0" authors: - family-names: Bittens given-names: Maximilian orcid: "https://orcid.org/0000-0001-9954-294X" doi: 10.5281/zenodo.11923516 message: If you use this software, please cite our article in the Journal of Open Source Software. preferred-citation: authors: - family-names: Bittens given-names: Maximilian orcid: "https://orcid.org/0000-0001-9954-294X" date-published: 2024-06-20 doi: 10.21105/joss.06725 issn: 2475-9066 issue: 98 journal: Journal of Open Source Software publisher: name: Open Journals start: 6725 title: "OpenGeoSysUncertaintyQuantification.jl: a Julia library implementing an uncertainty quantification toolbox for OpenGeoSys" type: article url: "https://joss.theoj.org/papers/10.21105/joss.06725" volume: 9 title: "OpenGeoSysUncertaintyQuantification.jl: a Julia library implementing an uncertainty quantification toolbox for OpenGeoSys" ```

If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation.

Find more information on .cff files here and here.

editorialbot commented 4 months ago

🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘

editorialbot commented 4 months ago

🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨

Here's what you must now do:

  1. Check final PDF and Crossref metadata that was deposited :point_right: https://github.com/openjournals/joss-papers/pull/5516
  2. Wait five minutes, then verify that the paper DOI resolves https://doi.org/10.21105/joss.06725
  3. If everything looks good, then close this review issue.
  4. Party like you just published a paper! 🎉🌈🦄💃👻🤘

Any issues? Notify your editorial technical team...

kthyng commented 4 months ago

Congratulations on your new publication @baxmittens! Many thanks to @kanishkan91 and to reviewers @ziyiyin97 and @dannys4 for your time, hard work, and expertise!! JOSS wouldn't be able to function nor succeed without your efforts.

editorialbot commented 4 months ago

:tada::tada::tada: Congratulations on your paper acceptance! :tada::tada::tada:

If you would like to include a link to your paper from your README use the following code snippets:

Markdown:
[![DOI](https://joss.theoj.org/papers/10.21105/joss.06725/status.svg)](https://doi.org/10.21105/joss.06725)

HTML:
<a style="border-width:0" href="https://doi.org/10.21105/joss.06725">
  <img src="https://joss.theoj.org/papers/10.21105/joss.06725/status.svg" alt="DOI badge" >
</a>

reStructuredText:
.. image:: https://joss.theoj.org/papers/10.21105/joss.06725/status.svg
   :target: https://doi.org/10.21105/joss.06725

This is how it will look in your documentation:

DOI

We need your help!

The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:

kthyng commented 4 months ago

@baxmittens If you're interested in joining JOSS as a reviewer, please register at https://reviewers.joss.theoj.org/.

baxmittens commented 4 months ago

Once again, thank you all for reviewing my software project.

@kthyng I recently did a review in JOSS, and I am willing to continue doing reviews. I completed my profile. JOSS is an excellent journal!